New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 650258 link

Starred by 1 user
Status: Fixed
Owner:
pastarmovj@chromium.org
Closed: Nov 2016
Cc:
█ blumberg@chromium.org
pav...@chromium.org
mastiz@chromium.org
█ tschumann@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Feature

Blocking:
issue 646653
issue 651409
issue 651411
issue 651415



Sign in to add a comment

Implement a loopback server to handle locally sync updates from the client.

Project Member Reported by pastarmovj@chromium.org, Sep 26 2016 
This component will play the role of the sync server but instead of doing over the network the data will be stored on disk. 

It is based on the FakeServer implementation and will potentially replace it for tests as well to reduce the code duplication and make sure this part gets on the critical path of every future sync change.

Comment 1 by pastarmovj@chromium.org, Sep 29 2016

Blocking: 651409

Comment 2 by pastarmovj@chromium.org, Sep 29 2016

Blocking: 651411

Comment 3 by pastarmovj@chromium.org, Sep 29 2016

Blocking: 651415
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 21 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b71840a8a2693a61d215fa29986f3a7d47315777

commit b71840a8a2693a61d215fa29986f3a7d47315777
Author: pastarmovj <pastarmovj@chromium.org>
Date: Fri Oct 21 10:13:36 2016

[Sync] Implements the loopback sync server.

The LoopbackServer implements a local sync server that keeps track of the
synced data. It is not meant for concurent operation with multiple clients
but rather serves as a persistent storage for the user profile e.g. for the
purpose of using Chrome with roaming profiles on Windows.

The implementation is based on the FakeSyncServer used for testing the
sync client.

BUG= 650258 
TEST=components_unittests:LoopbackServerTest.*

Review-Url: https://chromiumcodereview.appspot.com/2360703002
Cr-Commit-Position: refs/heads/master@{#426761}

[modify] https://crrev.com/b71840a8a2693a61d215fa29986f3a7d47315777/components/sync/BUILD.gn
[add] https://crrev.com/b71840a8a2693a61d215fa29986f3a7d47315777/components/sync/engine_impl/loopback_server/DEPS
[add] https://crrev.com/b71840a8a2693a61d215fa29986f3a7d47315777/components/sync/engine_impl/loopback_server/loopback_connection_manager.cc
[add] https://crrev.com/b71840a8a2693a61d215fa29986f3a7d47315777/components/sync/engine_impl/loopback_server/loopback_connection_manager.h
[add] https://crrev.com/b71840a8a2693a61d215fa29986f3a7d47315777/components/sync/engine_impl/loopback_server/loopback_server.cc
[add] https://crrev.com/b71840a8a2693a61d215fa29986f3a7d47315777/components/sync/engine_impl/loopback_server/loopback_server.h
[add] https://crrev.com/b71840a8a2693a61d215fa29986f3a7d47315777/components/sync/engine_impl/loopback_server/loopback_server_entity.cc
[add] https://crrev.com/b71840a8a2693a61d215fa29986f3a7d47315777/components/sync/engine_impl/loopback_server/loopback_server_entity.h
[add] https://crrev.com/b71840a8a2693a61d215fa29986f3a7d47315777/components/sync/engine_impl/loopback_server/loopback_server_unittest.cc
[add] https://crrev.com/b71840a8a2693a61d215fa29986f3a7d47315777/components/sync/engine_impl/loopback_server/persistent_bookmark_entity.cc
[add] https://crrev.com/b71840a8a2693a61d215fa29986f3a7d47315777/components/sync/engine_impl/loopback_server/persistent_bookmark_entity.h
[add] https://crrev.com/b71840a8a2693a61d215fa29986f3a7d47315777/components/sync/engine_impl/loopback_server/persistent_permanent_entity.cc
[add] https://crrev.com/b71840a8a2693a61d215fa29986f3a7d47315777/components/sync/engine_impl/loopback_server/persistent_permanent_entity.h
[add] https://crrev.com/b71840a8a2693a61d215fa29986f3a7d47315777/components/sync/engine_impl/loopback_server/persistent_tombstone_entity.cc
[add] https://crrev.com/b71840a8a2693a61d215fa29986f3a7d47315777/components/sync/engine_impl/loopback_server/persistent_tombstone_entity.h
[add] https://crrev.com/b71840a8a2693a61d215fa29986f3a7d47315777/components/sync/engine_impl/loopback_server/persistent_unique_client_entity.cc
[add] https://crrev.com/b71840a8a2693a61d215fa29986f3a7d47315777/components/sync/engine_impl/loopback_server/persistent_unique_client_entity.h
[modify] https://crrev.com/b71840a8a2693a61d215fa29986f3a7d47315777/components/sync/engine_impl/syncer_proto_util.h
[add] https://crrev.com/b71840a8a2693a61d215fa29986f3a7d47315777/components/sync/protocol/loopback_server.proto
[modify] https://crrev.com/b71840a8a2693a61d215fa29986f3a7d47315777/components/sync/protocol/protocol_sources.gni

Comment 5 by pastarmovj@chromium.org, Nov 10 2016

Status: Fixed (was: Started)
►

Sign in to add a comment