New issue
Advanced search Search tips

Issue 650247 link

Starred by 1 user
Status: Fixed
Owner:
jgruber@chromium.org
Closed: Oct 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Incorrect error message when String.proto.substring is called on null or undefined

Project Member Reported by jgruber@chromium.org, Sep 26 2016 
At commit: eb3573ecd917eb1aadfb3b6bc0e13f3339ca8d14

The error message for 

String.prototype.substring.call(undefined, 1, 3)

is

'TypeError: String.prototype.subString called on null or undefined.'

but should be

'TypeError: String.prototype.substring called on null or undefined.'
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 27 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f3cf8d5ad4bac5e75d51e9da0fd503cff525b050

commit f3cf8d5ad4bac5e75d51e9da0fd503cff525b050
Author: jgruber <jgruber@chromium.org>
Date: Tue Sep 27 07:49:22 2016

Set string-prototype-properties to NeedsManualRebaseline

The expectations incorrectly expect 'subString' instead of 'substring'
in the case when substring is called on null or undefined.

BUG= chromium:650247 

Review-Url: https://codereview.chromium.org/2369003003
Cr-Commit-Position: refs/heads/master@{#421140}

[modify] https://crrev.com/f3cf8d5ad4bac5e75d51e9da0fd503cff525b050/third_party/WebKit/LayoutTests/TestExpectations

Comment 3 by jgruber@chromium.org, Oct 5 2016

Status: Fixed (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 5 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1ac115153c05b826281bab0dd808b251634c7d55

commit 1ac115153c05b826281bab0dd808b251634c7d55
Author: jgruber <jgruber@chromium.org>
Date: Wed Oct 05 12:01:31 2016

Set string-prototype-properties to NeedsRebaseline

The expectations incorrectly expect 'subString' instead of 'substring'
in the case when substring is called on null or undefined.

BUG= chromium:650247 

Review-Url: https://codereview.chromium.org/2395703003
Cr-Commit-Position: refs/heads/master@{#423132}

[modify] https://crrev.com/1ac115153c05b826281bab0dd808b251634c7d55/third_party/WebKit/LayoutTests/TestExpectations
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 27 2016

Labels: merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1ac115153c05b826281bab0dd808b251634c7d55

commit 1ac115153c05b826281bab0dd808b251634c7d55
Author: jgruber <jgruber@chromium.org>
Date: Wed Oct 05 12:01:31 2016

Set string-prototype-properties to NeedsRebaseline

The expectations incorrectly expect 'subString' instead of 'substring'
in the case when substring is called on null or undefined.

BUG= chromium:650247 

Review-Url: https://codereview.chromium.org/2395703003
Cr-Commit-Position: refs/heads/master@{#423132}

[modify] https://crrev.com/1ac115153c05b826281bab0dd808b251634c7d55/third_party/WebKit/LayoutTests/TestExpectations

Comment 8 by dimu@google.com, Nov 4 2016

Labels: -merge-merged-2840
[Automated comment] removing mislabelled merge-merged-2840
►

Sign in to add a comment