New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 650239 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Unnecessary 'REMOVE ALL SHOWN' button is seen for cookies section of chrome://md-settings.

Reported by jshan...@etouch.net, Sep 26 2016

Issue description

Chrome Version: 55.0.2872.0 (Official Build) 5264ac775e58852ece697a6e26117d72181c4f41-refs/heads/master@{#420859}-32/64 bit
OS:Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.10.5, 10.11.4)

Steps:
1. Launch Chrome and navigate to chrome://md-settings/siteSettings/cookies.
2. Type any keyword in search field of 'All cookies and site data' such that nothing is displayed.
3. Observe.

Actual: Unnecessary 'REMOVE ALL SHOWN' button is seen, even though search result is not displayed.

Expected: 'REMOVE ALL SHOWN' button should not be seen when search result is not displayed.

This is non-regression issue,this is new feature introduce in 'M 55' (55.0.2864.0)

@finnur: Please take a look


 
Actual_result.jpg
94.5 KB View Download

Comment 1 by finnur@chromium.org, Sep 26 2016

Owner: finnur@chromium.org
Status: Started (was: Unconfirmed)

Comment 2 by finnur@chromium.org, Sep 28 2016

Status: Fixed (was: Started)
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c1dfa6953598067e94cf4afec495f727c3924000

commit c1dfa6953598067e94cf4afec495f727c3924000
Author: finnur <finnur@chromium.org>
Date: Tue Sep 27 18:25:51 2016

Site Settings Desktop: Only show Remove action if filter hasn't removed all.

BUG= 650239 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2370843002
Cr-Commit-Position: refs/heads/master@{#421275}

[modify] https://crrev.com/c1dfa6953598067e94cf4afec495f727c3924000/chrome/browser/resources/settings/site_settings/site_data.html
[modify] https://crrev.com/c1dfa6953598067e94cf4afec495f727c3924000/chrome/browser/resources/settings/site_settings/site_data.js

Cc: kavvaru@chromium.org
Labels: TE-Verified-55.0.2880.0 TE-Verified-M55
Tested the issue on windows 7, Mac 10.11.6 using chrome version 55.0.2880.0."Remove All shown " is not displayed when the search results is empty. Please find the attached screen cast for the same.

Adding TE-Verified labels.

Note:: Issue verified on 55.0.2879.0 for Linux as the 55.0.2880.0 build got failed for linux due to issue 652581.

Thanks,
650239.mp4
761 KB View Download

Sign in to add a comment