Chrome pdf viewer does not display images
Reported by
andrey.m...@gmail.com,
Sep 26 2016
|
||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/53.0.2785.116 Safari/537.36 Steps to reproduce the problem: 1. open sample pdf in crome 2. open sample pdf in Adobe Reader What is the expected behavior? Pdf are identical What went wrong? Pdf are't identical. In chrome image is missing. Did this work before? No Chrome version: 53.0.2785.116 Channel: stable OS Version: 6.1 (Windows 7, Windows Server 2008 R2) Flash Version: Shockwave Flash 23.0 r0 PDF was created in ABBYY FineReader 11
,
Nov 8 2016
I really like the test example. :)
,
Nov 8 2016
Regressed here: https://chromium.googlesource.com/chromium/src/+log/5eee3f189d59842559c10fd4941a26319a37e923..40b711cfcf4c3a1bc9a20cd5ec118a1cd1a15394 -> r387739 -> Need to manually figure out what caused this in: https://pdfium.googlesource.com/pdfium.git/+log/461129e..2ba3dc7
,
Nov 8 2016
Perhaps https://codereview.chromium.org/1892143003 was too agressive in fixing the other bug?
,
Nov 8 2016
The check is now in core/fpdfapi/render/fpdf_render_loadimage.cpp. For this bug, m_Family is PDFCS_ICCBASED, m_pColorSpace->CountComponents() is 3, and m_nComponents is 1.
,
Nov 8 2016
I suspect we just have to make sure there are enough components for a given type of colorspace, and it is ok to have more. Will whip something up.
,
Nov 9 2016
For the elephants: https://codereview.chromium.org/2486123002
,
Nov 11 2016
The following revision refers to this bug: https://pdfium.googlesource.com/pdfium.git/+/dc40c40f40ed2415605da32f688091a57f53c9e6 commit dc40c40f40ed2415605da32f688091a57f53c9e6 Author: thestig <thestig@chromium.org> Date: Fri Nov 11 20:06:47 2016 Relax colorspace checks in CPDF_DIBSource::CreateDecoder(). Previously the log just made sure the colorspace and the image have exact matches for the number of colorspace components. Now, for some colorspace types, check the type and make sure the number of components meets or exceeds what is required by the spec. Also do some refactoring. BUG= chromium:650230 Review-Url: https://codereview.chromium.org/2486123002 [modify] https://crrev.com/dc40c40f40ed2415605da32f688091a57f53c9e6/core/fpdfapi/page/fpdf_page_colors.cpp [modify] https://crrev.com/dc40c40f40ed2415605da32f688091a57f53c9e6/core/fpdfapi/render/fpdf_render_loadimage.cpp [modify] https://crrev.com/dc40c40f40ed2415605da32f688091a57f53c9e6/core/fxcodec/fx_codec.h
,
Nov 11 2016
,
Nov 11 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2ec3b4f35d623d53e26923d3d19d0cb29f20cd26 commit 2ec3b4f35d623d53e26923d3d19d0cb29f20cd26 Author: pdfium-deps-roller <pdfium-deps-roller@chromium.org> Date: Fri Nov 11 21:12:01 2016 Roll src/third_party/pdfium/ a0d323103..dc40c40f4 (2 commits). https://pdfium.googlesource.com/pdfium.git/+log/a0d323103781..dc40c40f40ed $ git log a0d323103..dc40c40f4 --date=short --no-merges --format='%ad %ae %s' 2016-11-11 thestig Relax colorspace checks in CPDF_DIBSource::CreateDecoder(). 2016-11-11 tsepez Fix sevg above CPDF_PageContentGenerator::ProcessImage() BUG= 650230 , 660756 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Review-Url: https://codereview.chromium.org/2495043002 Cr-Commit-Position: refs/heads/master@{#431644} [modify] https://crrev.com/2ec3b4f35d623d53e26923d3d19d0cb29f20cd26/DEPS |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by andrey.m...@gmail.com
, Sep 30 2016147 KB
147 KB Download