New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 650213 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Email to this user bounced
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 295792



Sign in to add a comment

Validate internalformat/format/type combination for uploading DOM elements with TexImage

Project Member Reported by qiankun....@intel.com, Sep 26 2016

Issue description

When uploading DOM elements to texture using Tex{sub}image2D/3D, the valid internalformat/format/type combination is specified in table: https://www.khronos.org/registry/webgl/specs/latest/2.0/#TEXTURE_TYPES_FORMATS_FROM_DOM_ELEMENTS_TABLE. Chrome doesn't follow this restriction currently.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cf9bdd36fdab41372d9df8f5765f0e388f9d2429

commit cf9bdd36fdab41372d9df8f5765f0e388f9d2429
Author: qiankun.miao <qiankun.miao@intel.com>
Date: Sat Oct 01 18:52:03 2016

Validate internalformat/format/type for uploading DOM elements to texture

When the data source is a DOM elements, supported
internalformat/format/type combination by TexImage is specified in WebGL
2.0 spec:
https://www.khronos.org/registry/webgl/specs/latest/2.0/#TEXTURE_TYPES_FORMATS_FROM_DOM_ELEMENTS_TABLE.

BUG= 650213 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2370703003
Cr-Commit-Position: refs/heads/master@{#422324}

[modify] https://crrev.com/cf9bdd36fdab41372d9df8f5765f0e388f9d2429/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp
[modify] https://crrev.com/cf9bdd36fdab41372d9df8f5765f0e388f9d2429/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h

Project Member

Comment 2 by bugdroid1@chromium.org, Oct 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/da6af8ed7e3bf178abb356fc4c20502400c50469

commit da6af8ed7e3bf178abb356fc4c20502400c50469
Author: qiankun.miao <qiankun.miao@intel.com>
Date: Sun Oct 02 01:29:14 2016

Roll WebGL 1ded271..79ef088

https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/1ded271..79ef088

BUG=644740,  650213 

TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2390453002
Cr-Commit-Position: refs/heads/master@{#422337}

[modify] https://crrev.com/da6af8ed7e3bf178abb356fc4c20502400c50469/DEPS
[modify] https://crrev.com/da6af8ed7e3bf178abb356fc4c20502400c50469/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py

Status: Fixed (was: Assigned)

Sign in to add a comment