Regression: Selected word doesn't reflect while hitting enter in console of devtools |
|||||
Issue descriptionVersion: 55.0.2872.0 dev OS: Ubuntu 14.04,windows What steps will reproduce the problem? (1) Launch chrome >> Open devtools on any page >> Go to Console tab >> Hit any letter (say "n") so that suggestion list appears. Now hit down arrow and hit enter Expected: Selected word should reflect while hitting enter. Actual: Instead selected word doesn't reflect from suggestion list. This is a regression issue broken in M55. Will provide other info soon.
,
Sep 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9926833faef089c9f45c303a0e0664083b0f64ad commit 9926833faef089c9f45c303a0e0664083b0f64ad Author: einbinder <einbinder@chromium.org> Date: Tue Sep 27 03:04:29 2016 DevTools: Move "enter" logic from ConsoleView to ConsolePrompt Also fixes a bug where enter was never captured by the SuggestBox. BUG= 650155 Review-Url: https://codereview.chromium.org/2361273002 Cr-Commit-Position: refs/heads/master@{#421088} [modify] https://crrev.com/9926833faef089c9f45c303a0e0664083b0f64ad/third_party/WebKit/LayoutTests/http/tests/inspector/console-test.js [modify] https://crrev.com/9926833faef089c9f45c303a0e0664083b0f64ad/third_party/WebKit/LayoutTests/inspector/console/console-smart-enter-expected.txt [modify] https://crrev.com/9926833faef089c9f45c303a0e0664083b0f64ad/third_party/WebKit/LayoutTests/inspector/console/console-smart-enter.html [modify] https://crrev.com/9926833faef089c9f45c303a0e0664083b0f64ad/third_party/WebKit/Source/devtools/front_end/Tests.js [modify] https://crrev.com/9926833faef089c9f45c303a0e0664083b0f64ad/third_party/WebKit/Source/devtools/front_end/console/ConsolePrompt.js [modify] https://crrev.com/9926833faef089c9f45c303a0e0664083b0f64ad/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js
,
Sep 29 2016
Issue is working fine in 55.0.2875.0 dev of Linux and Windows. i.e; Selected word from suggest box shows up in console prompt.
,
Sep 29 2016
The same is working fine on the latest canary(55.0.2875.0) on Mac OS 10.11.6 as well. Hence adding the verified label.
,
Oct 7 2016
Closing the issue as Fixed as this is verified as per C#3 and C#4. Please reopen if there is any further work to be done here. Thank you!
,
Oct 28 2016
[Auto-generated comment by a script] We noticed that this issue is targeted for M-55; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-55 label, otherwise remove Merge-TBD label. Thanks.
,
Oct 28 2016
No merge is needed for M55. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by brajkumar@chromium.org
, Sep 26 2016Owner: einbinder@chromium.org
Status: Assigned (was: Unconfirmed)