Issue metadata
Sign in to add a comment
|
Regression:Position of 'USB' permission bubble is misplaced from 'View site info' icon.
Reported by
dmascare...@etouch.net,
Sep 26 2016
|
||||||||||||||||||||||
Issue descriptionChrome Version: 55.0.2871.0 (Official Build) 5728b19d6b9f8c94c83e1736c54e9c0db136e25e-refs/heads/master@{#420831} OS: Windows(7,8,10),Linux Pre-conditon: Enable 'Experimental Web Platform features' flag. What steps will reproduce the problem? (1) Launch chrome, navigate to https://permission.site/ (2) Click on 'USB' button and observe the position of 'USB' permission bubble Actual: Position of 'USB' permission bubble is misplaced from 'View site info' icon. Expected: Position of 'USB' permission bubble should be proper. This is a regression issue, broken in 'M-55', below is bisect info: Good Build: 55.0.2845.0 Bad Build: 55.0.2846.0 Note: Issue is not seen on Mac OS.
,
Sep 26 2016
Hi msr, This should have been fixed at 417932.
,
Sep 29 2016
Issue looks to be related to incorrect positioning of USB permission bubble as per this report and attached screenshot in C#0 is still seen on the latest canary(55.0.2875.0). krb@: Could you please confirm if the present position of bubble is WAI or not? Removing the blocker label as the issue repros only behind the flag. Add it back if someone feels otherwise. Thank you!
,
Sep 29 2016
Hi ajha, I can't get the USB or Bluetooth notifications to pop-up, I assume due to a hardware issue, but all the other notifications "point" to the "Expected" place per the PNG in the problem description. Do the other notifications e.g. Notifications work for you?
,
Sep 29 2016
Please Enable 'Experimental Web Platform features' flag under chrome://flags to check the pop up.
,
Sep 29 2016
It still doesn't show with http. Hope that's WAI. But it does with https, and it's showing the same problem as the earlier bubbles. I'll take a look.
,
Sep 30 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b34fa9422ed84323d7d20ebc9eb69bb946207e87 commit b34fa9422ed84323d7d20ebc9eb69bb946207e87 Author: krb <krb@chromium.org> Date: Fri Sep 30 13:14:28 2016 [omnibox] Return reference to ImageView instead of LocationIconView (2) Found another place where we need to return a reference to the ImageView, not the LocationIconView. From the previous CL: The latter is quite wide when we fill in the label half of it, which we now do with site security level in some cases. The bubble (in the bug that is in the wrong place) anchors to the middle of whatever View you return to it, so we really want to give it the padlock here. BUG= 650140 Review-Url: https://codereview.chromium.org/2379783003 Cr-Commit-Position: refs/heads/master@{#422094} [modify] https://crrev.com/b34fa9422ed84323d7d20ebc9eb69bb946207e87/chrome/browser/ui/views/website_settings/chooser_bubble_ui_view.cc
,
Sep 30 2016
Please let me know if this does or doesn't address your case.
,
Oct 4 2016
Tested the issue on Windows -- Chrome Dev# 55.0.2880.0 and on Linux -- Chrome Dev# 55.0.2879.0 and is no more reproducible. Hence adding TE-Verified-Labels. Attached a screen shot for reference. Thank You. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by msrchandra@chromium.org
, Sep 26 2016Owner: k...@chromium.org
Status: Assigned (was: Unconfirmed)