New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 650140 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression:Position of 'USB' permission bubble is misplaced from 'View site info' icon.

Reported by dmascare...@etouch.net, Sep 26 2016

Issue description

Chrome Version: 55.0.2871.0 (Official Build) 5728b19d6b9f8c94c83e1736c54e9c0db136e25e-refs/heads/master@{#420831}
OS: Windows(7,8,10),Linux

Pre-conditon: Enable 'Experimental Web Platform features' flag.

What steps will reproduce the problem?
(1) Launch chrome, navigate to https://permission.site/
(2) Click on 'USB' button and observe the position of 'USB' permission bubble

Actual: Position of 'USB' permission bubble is misplaced from 'View site info' icon.

Expected: Position of 'USB' permission bubble should be proper.

This is a regression issue, broken in 'M-55', below is bisect info:

Good Build: 55.0.2845.0
Bad Build: 55.0.2846.0

Note: Issue is not seen on Mac OS.
 
usb.png
57.6 KB View Download
Labels: ReleaseBlock-Stable hasbisect-per-revision
Owner: k...@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good build: 55.0.2845.0 (Revision: 415522).
Bad build: 55.0.2846.0 (Revision: 415833).

You are probably looking for a change made after 415655 (known good), but no later than 415656 (first known bad).
CHANGELOG URL:
  https://chromium.googlesource.com/chromium/src/+log/d57cd741ffc0f5e9328222c0f73d3519b4aae9fb..93cfbbd07e3ee8d9465147a1be2601a0cb74632e

@krb -- Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner

Comment 2 by k...@chromium.org, Sep 26 2016

Hi msr,

This should have been fixed at 417932.

Comment 3 by ajha@chromium.org, Sep 29 2016

Labels: -ReleaseBlock-Stable
Issue looks to be related to incorrect positioning of USB permission bubble as per this report and attached screenshot in C#0 is still seen on the latest canary(55.0.2875.0).

krb@: Could you please confirm if the present position of bubble is WAI or not?

Removing the blocker label as the issue repros only behind the flag. Add it back if someone feels otherwise.

Thank you!

Comment 4 by k...@chromium.org, Sep 29 2016

Hi ajha,

I can't get the USB or Bluetooth notifications to pop-up, I assume due to a hardware issue, but all the other notifications "point" to the "Expected" place per the PNG in the problem description. Do the other notifications e.g. Notifications work for you?

Comment 5 by ajha@chromium.org, Sep 29 2016

Please Enable 'Experimental Web Platform features' flag under chrome://flags to check the pop up.

Comment 6 by k...@chromium.org, Sep 29 2016

It still doesn't show with http. Hope that's WAI. But it does with https, and it's showing the same problem as the earlier bubbles. I'll take a look.
Project Member

Comment 7 by bugdroid1@chromium.org, Sep 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b34fa9422ed84323d7d20ebc9eb69bb946207e87

commit b34fa9422ed84323d7d20ebc9eb69bb946207e87
Author: krb <krb@chromium.org>
Date: Fri Sep 30 13:14:28 2016

[omnibox] Return reference to ImageView instead of LocationIconView (2)

Found another place where we need to return a reference to the
ImageView, not the LocationIconView.

From the previous CL:

The latter is quite wide when we fill in the label half of it, which we
now do with site security level in some cases.  The bubble (in the bug
that is in the wrong place) anchors to the middle of whatever View you
return to it, so we really want to give it the padlock here.

BUG= 650140 

Review-Url: https://codereview.chromium.org/2379783003
Cr-Commit-Position: refs/heads/master@{#422094}

[modify] https://crrev.com/b34fa9422ed84323d7d20ebc9eb69bb946207e87/chrome/browser/ui/views/website_settings/chooser_bubble_ui_view.cc

Comment 8 by k...@chromium.org, Sep 30 2016

Status: Fixed (was: Assigned)
Please let me know if this does or doesn't address your case.
Labels: TE-Verified-M55 TE-Verified-55.0.2879.0 TE-Verified-55.0.2880.0
Tested the issue on Windows -- Chrome Dev# 55.0.2880.0 and on Linux -- Chrome Dev# 55.0.2879.0 and is no more reproducible.
Hence adding TE-Verified-Labels.
Attached a screen shot for reference.
Thank You.
650140.png
154 KB View Download

Sign in to add a comment