ccing people you may be interested.

Start to investigate on it.

A snapshot of possible user actions to a pop-up blocking and the place to capture and count the action.

Deleted: Screenshot from 2016-12-16 10:00:59.png 415 KB

	Screenshot from 2016-12-16 10:00:59.png 415 KB View Download

That looks pretty good to me. kcarattini/raymes - any comments?

Looking good.

All of the the histogram values meaningful on desktop and Android other than the infobar/omnibox icon?

Ryan, Do you have a goto page that has a blocked popup we can use to see the behaviour?

This is my favorite test site for popups: http://popuptest.com/

Sorry for the late reply.
On IOS and Android, it only contains two actions: dismiss and always allow.

My question is: Do I need to distinguish the mobile actions with pc actions by different counters?

Deleted: file.jpeg 66.9 KB

	file.jpeg 66.9 KB View Download

Plugins are only counted on desktop because plugins aren't available on Android and iOS. We should could the actions on all platforms, and as long as it doesn't make the CL too big, you should do it all in one.

UMA allows you to filter by platform, so there's no need to introduce platform-specific enum values. Just use the ones in the enum which make the most sense (DISPLAYED_BLOCKED_INFO_BAR, and probably a CLICK_PRIMARY / CLICK_DISMISS or something like that.

I'm not an expert on the actual functionality of the buttons, so I can't help you with that unfortunately.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e5e6f6ee653ae95d6fb7f9a408c7370348e14fee

commit e5e6f6ee653ae95d6fb7f9a408c7370348e14fee
Author: charleszhao <charleszhao@chromium.org>
Date: Fri Jan 06 04:09:38 2017

Add UMA metrics for pop-up blocked page action on desktop
(1) Add counters for popup actions (desktop only in this CL.)
(2) Add unittest.

"Dismiss" is not counted, because it's not very meaningful for desktop
popup actions; There is no single dismiss button, and count in
destructor will count all the displays.

BUG= 650132 

Review-Url: https://codereview.chromium.org/2588273002
Cr-Commit-Position: refs/heads/master@{#441870}

[modify] https://crrev.com/e5e6f6ee653ae95d6fb7f9a408c7370348e14fee/chrome/browser/content_settings/chrome_content_settings_utils.cc
[modify] https://crrev.com/e5e6f6ee653ae95d6fb7f9a408c7370348e14fee/chrome/browser/content_settings/chrome_content_settings_utils.h
[modify] https://crrev.com/e5e6f6ee653ae95d6fb7f9a408c7370348e14fee/chrome/browser/content_settings/tab_specific_content_settings.cc
[modify] https://crrev.com/e5e6f6ee653ae95d6fb7f9a408c7370348e14fee/chrome/browser/ui/content_settings/content_setting_bubble_model.cc
[modify] https://crrev.com/e5e6f6ee653ae95d6fb7f9a408c7370348e14fee/chrome/browser/ui/content_settings/content_setting_bubble_model.h
[modify] https://crrev.com/e5e6f6ee653ae95d6fb7f9a408c7370348e14fee/chrome/browser/ui/content_settings/content_setting_bubble_model_browsertest.cc
[modify] https://crrev.com/e5e6f6ee653ae95d6fb7f9a408c7370348e14fee/tools/metrics/histograms/histograms.xml

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0ab3b67a846c21a42996cf6d0e19a331b31dfacb

commit 0ab3b67a846c21a42996cf6d0e19a331b31dfacb
Author: charleszhao <charleszhao@chromium.org>
Date: Thu Mar 16 00:35:30 2017

Add UMA histogram for popup actions on Android.

This CL adds metrics for the pop-up blocked infobar on Android.

BUG= 650132 

Review-Url: https://codereview.chromium.org/2662163002
Cr-Commit-Position: refs/heads/master@{#457285}

[modify] https://crrev.com/0ab3b67a846c21a42996cf6d0e19a331b31dfacb/chrome/browser/content_settings/chrome_content_settings_utils.h
[modify] https://crrev.com/0ab3b67a846c21a42996cf6d0e19a331b31dfacb/chrome/browser/ui/android/content_settings/popup_blocked_infobar_delegate.cc
[modify] https://crrev.com/0ab3b67a846c21a42996cf6d0e19a331b31dfacb/tools/metrics/histograms/histograms.xml

Should I close this bug?

there are still a slight problem that the ios side is not recorded, 

the ios code need special dependency approval to add histograms there.

I'm comfortable with closing this for now. Anyone else have thoughts?

Thanks everyone,