New issue
Advanced search Search tips

Issue 650118 link

Starred by 1 user
Status: Fixed
Owner:
lgrey@chromium.org
Closed: Jul 19
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug
Team-Accessibility

Blocking:
issue 671916


Show other hotlists

Hotlists containing this issue:
MacViews-Task-Queue


Sign in to add a comment

MacViews: VoiceOver cursor doesn't get drawn inside WebContents when VoiceOver focus is synced to keyboard focus.

Project Member Reported by patricia...@chromium.org, Sep 26 2016 
Version: r423083 (see the CL in #c1)
OS: 10.11.6

What steps will reproduce the problem?
(1) With the gn flag mac_views_browser = true, press Cmd+F5 to turn on VoiceOver. Make sure also that VoiceOver is set to "VoiceOver cursor follows keyboard focus" (go to System Preferences > Accessibility > VoiceOver > VoiceOver Utility > Navigation > check "VoiceOver cursor follows keyboard focus".
(2) Click to focus inside the omnibox, which should get a black rectangle drawn around it (the VoiceOver cursor). Tab until focus is on the three dots / hamburger menu on the right.
(3) Press tab again to enter the WebContents.

What is the expected output?
VoiceOver draws the black rectangle around the element with keyboard focus inside the WebContents and reads out its corresponding a11y text.

What do you see instead?
VoiceOver reads out the corresponding a11y text for the currently keyboard-focused element inside the WebContents, but doesn't redraw the cursor (it's stuck on the hamburger menu button).
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 5 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f8686b58fdf56513efdf5ed2826018560d26bbe2

commit f8686b58fdf56513efdf5ed2826018560d26bbe2
Author: patricialor <patricialor@chromium.org>
Date: Wed Oct 05 05:52:54 2016

MacViews a11y: Sync VoiceOver cursor with keyboard focus.

Move the VoiceOver cursor when changing the keyboard focus if "VoiceOver cursor
follows keyboard focus" is turned on in VoiceOver Utility (System Preferences >
Accessibility > VoiceOver > Open VoiceOver Utility) with MacViews.

BUG= 610585 ,  650118 
TEST=With the #mac-views-native-dialogs flag turned on via chrome:flags, turn on
VoiceOver with Cmd+F5. Click the bookmark star on the right of the omnibox and
press tab to change focus inside it. The VoiceOver cursor should follow keyboard
focus.

Review-Url: https://codereview.chromium.org/2210763002
Cr-Commit-Position: refs/heads/master@{#423083}

[modify] https://crrev.com/f8686b58fdf56513efdf5ed2826018560d26bbe2/content/browser/accessibility/browser_accessibility_cocoa.mm
[modify] https://crrev.com/f8686b58fdf56513efdf5ed2826018560d26bbe2/ui/accessibility/platform/ax_platform_node_mac.mm
[modify] https://crrev.com/f8686b58fdf56513efdf5ed2826018560d26bbe2/ui/views/cocoa/bridged_content_view.mm

Comment 2 by patricia...@chromium.org, Oct 5 2016

Description: Show this description

Comment 3 by dmazz...@chromium.org, Mar 6 2017

Labels: NewComponent-Accessibility-Compatibility

Comment 4 by dmazz...@chromium.org, Mar 27 2017

Labels: NewComponent-Accessibility

Comment 5 by dmazz...@chromium.org, Apr 21 2017

Components: UI>Accessibility>Compatibility

Comment 6 by dmazz...@chromium.org, Apr 21 2017

Components: -UI>Accessibility
Labels: -newcomponent-accessibility-compatibility -newcomponent-accessibility

Comment 7 by tapted@chromium.org, Jun 20 2017

Blocking: 671916
Labels: -Pri-3 Pri-2

Comment 8 by ellyjo...@chromium.org, Mar 29 2018

Labels: M-69 MacViews-Browser Target-69
patricialor: is this fixed?

Comment 9 by patricia...@chromium.org, Apr 3 2018

Status: WontFix (was: Assigned)
Yes, I think so! Just retested with #views-browser-windows turned on in Canary 67.0.3386.0.

Comment 10 by lgrey@chromium.org, Jul 13

Owner: lgrey@chromium.org
Status: Assigned (was: WontFix)
Reopening and taking since
- I can't get this to work
- I'm pretty sure it's related to  Issue 861756

Comment 11 by lgrey@chromium.org, Jul 19

Status: Fixed (was: Assigned)
Fixed by https://chromium-review.googlesource.com/c/chromium/src/+/1138793 (though there's still a delay, presumably because of async hit testing in the web content)
►

Sign in to add a comment