Harmony - blinking insertion point repaints portion of dialog, causes shadow to get darker |
|||
Issue descriptionVersion: 55.0.2871.0 OS: 10.11 What steps will reproduce the problem? (1) Create a new browser window (2) Click the bookmark star icon (3) Turn on Flash screen updates in Quart Debug (4) Click in the Bookmark name textfield What is the expected output? The flashing insertion point should result in an update rect that's the bounds of the insertion point. What do you see instead? Each flash of the insertion point repaints the upper left quadrant of the bookmarks dialog. What's more, this update rect includes the bookmark dialog's drop shadow - because the shadow is transparent, each repaint causes the portion of the shadow intersecting the update rect to get darker. Seen the attached screenshot. Please use labels and text to provide additional information.
,
Jan 28 2017
I don't see this happening on Windows at 1x. Wondering if this is MacViews-specific.
,
Feb 9 2017
Issue 680536 "Use a layer to blink cursor in textfield" may resolve the main performance issues here. I'm not sure what's going on with the shadow -- might be a macOS bug. E.g. like Issue 660257 which I can't repro any more.
,
Feb 9 2017
It looks like the screen updates no longer intersect the shadow so that's probably at least part of why it no longer repos. The update rect, however, is much larger than the insertion point update area - we should still fix that.
,
Feb 23 2017
Since this has no visual manifestation any more, Pri-3.
,
Feb 23 2017
Note that r451179 ( Issue 680536 ) is in Canary now. Blinking cursors in toolkit-views no longer show up in Quartz Debug at all. The only thing I don't like is that clicking in the window updates the entire frame, but that doesn't seem to be uncommon for regular Cocoa windows - the Window server probably raises the window each time its clicked "just in case". I don't think there's anything to do here, so I'm closing this as fixed by r451179. (also kudos for yiyix@chromium.org for the neat performance improvement!) |
|||
►
Sign in to add a comment |
|||
Comment 1 by shrike@chromium.org
, Oct 1 2016