New issue
Advanced search Search tips

Issue 650088 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Closed: Sep 2016
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocking:
issue 648818



Sign in to add a comment

Skia Dash counts now unsigned.

Project Member Reported by cblume@chromium.org, Sep 25 2016

Issue description

The dash counts were signed, but were used in an unsigned way such as indexing into an array.

We are unlikely to need that extra bit. However, it also calls SkAlign2(). SkAlign2() is implemented with bit shifts, which cause undefined behavior on signed ints.


In addition, we want to replace SkAlign?() macros with proper functions. The current set doesn't work on pointer types. Moving to the proper functions requires the calling points be fixed.
 

Comment 1 by cblume@chromium.org, Sep 29 2016

Status: WontFix (was: Assigned)
Skia's APIs do not use unsigned. Closing.

Sign in to add a comment