New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 650082 link

Starred by 3 users
Status: Fixed
Owner: ----
Closed: Feb 2018
Cc:
█ pwan...@gmail.com
█ coron...@gmail.com
EstimatedDays: ----
NextAction: ----
OS: All , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Replace Deprecated version of SetWithoutPathExpansion

Reported by coron...@gmail.com, Sep 25 2016 
UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/53.0.2785.116 Safari/537.36

Steps to reproduce the problem:
There are lots of old version of SetWithoutPathExpansion
We shoud replace it all to newer version
I'm working on extension
https://codereview.chromium.org/2370633002/

What is the expected behavior?

What went wrong?
We shoud replace it all to newer version

Did this work before? N/A 

Chrome version: 53.0.2785.116  Channel: n/a
OS Version: OS X 10.11.6
Flash Version: Shockwave Flash 23.0 r0

Comment 1 by jinho.b...@samsung.com, Sep 25 2016

Cc: pwan...@gmail.com coron...@gmail.com
Labels: -Pri-2 -Via-Wizard OS-All Pri-3
Status: Started (was: Unconfirmed)
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 29 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ac5ff4c30081cf17e1c8b19bccf9615f7840343c

commit ac5ff4c30081cf17e1c8b19bccf9615f7840343c
Author: corona10 <corona10@gmail.com>
Date: Thu Sep 29 18:34:11 2016

replace deprecated version of SetWithoutPathExpansion

BUG= 650082 

Review-Url: https://codereview.chromium.org/2370633002
Cr-Commit-Position: refs/heads/master@{#421877}

[modify] https://crrev.com/ac5ff4c30081cf17e1c8b19bccf9615f7840343c/extensions/browser/api/declarative_webrequest/webrequest_condition_attribute_unittest.cc
[modify] https://crrev.com/ac5ff4c30081cf17e1c8b19bccf9615f7840343c/extensions/browser/api/web_request/upload_data_presenter.cc
[modify] https://crrev.com/ac5ff4c30081cf17e1c8b19bccf9615f7840343c/extensions/browser/api/web_request/upload_data_presenter_unittest.cc
[modify] https://crrev.com/ac5ff4c30081cf17e1c8b19bccf9615f7840343c/extensions/browser/app_window/app_window_geometry_cache.cc
[modify] https://crrev.com/ac5ff4c30081cf17e1c8b19bccf9615f7840343c/extensions/browser/app_window/app_window_geometry_cache_unittest.cc
[modify] https://crrev.com/ac5ff4c30081cf17e1c8b19bccf9615f7840343c/extensions/browser/event_router.cc
[modify] https://crrev.com/ac5ff4c30081cf17e1c8b19bccf9615f7840343c/extensions/browser/extension_prefs.cc
[modify] https://crrev.com/ac5ff4c30081cf17e1c8b19bccf9615f7840343c/extensions/browser/value_store/leveldb_value_store.cc
[modify] https://crrev.com/ac5ff4c30081cf17e1c8b19bccf9615f7840343c/extensions/browser/value_store/value_store_change.cc
[modify] https://crrev.com/ac5ff4c30081cf17e1c8b19bccf9615f7840343c/extensions/common/value_builder.cc
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 10 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/46702995890ed346d8c258c394c6a6093cfa1670

commit 46702995890ed346d8c258c394c6a6093cfa1670
Author: corona10 <corona10@gmail.com>
Date: Mon Oct 10 03:27:12 2016

Replace deprecated version of SetWithoutPathExpansion under src/apps

BUG= 650082 

Review-Url: https://codereview.chromium.org/2402003003
Cr-Commit-Position: refs/heads/master@{#424115}

[modify] https://crrev.com/46702995890ed346d8c258c394c6a6093cfa1670/apps/saved_files_service.cc
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 11 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5037fa115e066741053b02372832295fd7851631

commit 5037fa115e066741053b02372832295fd7851631
Author: pwangkk <pwangkk@gmail.com>
Date: Tue Oct 11 06:29:27 2016

Replace deprecated version of SetWithoutPathExpansion()

change SetWithoutPathExpansion(...,Value* in_value) to
SetWithoutPathExpansion(...,std::unique_ptr<Value> in_value)

I changed to std::unique_ptr<base::DictionaryValue> and
In order to use SetWithoutPathExpansion(...,std::unique_ptr<Value> in_value) used std::move()
in RegisterBackgroundContents of background_contents_service and MergeDataAndStartSyncing and ProcessSyncChanges of supervised_user_sync_service.cc

BUG= 650082 

Review-Url: https://codereview.chromium.org/2378083002
Cr-Commit-Position: refs/heads/master@{#424378}

[modify] https://crrev.com/5037fa115e066741053b02372832295fd7851631/AUTHORS
[modify] https://crrev.com/5037fa115e066741053b02372832295fd7851631/chrome/browser/supervised_user/child_accounts/family_info_fetcher_unittest.cc
[modify] https://crrev.com/5037fa115e066741053b02372832295fd7851631/chrome/browser/supervised_user/legacy/supervised_user_sync_service.cc

Comment 5 by dtapu...@chromium.org, Feb 12 2018

Status: Fixed (was: Started)
►

Sign in to add a comment