Issue metadata
Sign in to add a comment
|
No data received for page_cycler_v2.top_10_mobile from chromium-rel-mac10 since 417246 |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Sep 27 2016
Looks like this page needs to be re-recorded? 'https://www.google.co.uk/#hl=en&q=science', https://codesearch.chromium.org/chromium/src/tools/perf/page_sets/top_10_mobile.py?sq=package:chromium&l=13 How is that done?
,
Sep 27 2016
Issue 650075 has been merged into this issue.
,
Oct 6 2016
Looks like we have... one data point from the last build? Not sure if something actually improved or if it's just super flaky. Not sure about re-recording pages... what made you think that's needed? Kari, is that something you could help with?
,
Oct 6 2016
I think it doesn't makes sense to enable page_cycler_v2.top_10_mobile on non Android platform. Kouhei, Ksakamoto, should we disable the benchmark on dekstop?
,
Oct 6 2016
For the record, the failure here seems to be a recipe failure:
Traceback (most recent call last):
File "/b/rr/tmpjZ4VkX/rw/checkout/infra/.recipe_deps/build/scripts/slave/runtest.py", line 1781, in <module>
sys.exit(main())
File "/b/rr/tmpjZ4VkX/rw/checkout/infra/.recipe_deps/build/scripts/slave/runtest.py", line 1744, in main
result = _MainMac(options, args, extra_env)
File "/b/rr/tmpjZ4VkX/rw/checkout/infra/.recipe_deps/build/scripts/slave/runtest.py", line 1010, in _MainMac
_ResultsDashboardDict(options))
File "/b/rr/tmpjZ4VkX/rw/checkout/infra/.recipe_deps/build/scripts/slave/runtest.py", line 489, in _ResultsDashboardDict
'revisions': _GetPerfDashboardRevisions(options),
File "/b/rr/tmpjZ4VkX/rw/checkout/infra/.recipe_deps/build/scripts/slave/runtest.py", line 397, in _GetPerfDashboardRevisions
return slave_utils.GetPerfDashboardRevisions(
AttributeError: 'module' object has no attribute 'GetPerfDashboardRevisions'
@@@STEP_CURSOR@page_cycler_v2.top_10_mobile@@@
I file another bug about this: issue 653653
,
Oct 6 2016
You re-record by running tools/perf/record_wpr on the benchmark or storyset. But I would agree with Ned that top_10_mobile probably isn't intended to run on desktop platforms. Hopefully Kouhei or Kunihiko can confirm that.
,
Nov 22 2016
ping on comment #5.
,
Dec 2 2016
Escalation to help with finding time to pay attention to this bug. Thanks!
,
Dec 2 2016
I agree that we should disable page_cycler_v2.top_10_mobile on desktop platforms. I'll make a patch.
,
Dec 2 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c1c2eff354215eb43e9b2ae9af9ddad22641c10d commit c1c2eff354215eb43e9b2ae9af9ddad22641c10d Author: ksakamoto <ksakamoto@chromium.org> Date: Fri Dec 02 06:51:43 2016 Disable page_cycler_v2.top_10_mobile on desktop platforms BUG= 650076 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq Review-Url: https://codereview.chromium.org/2543123002 Cr-Commit-Position: refs/heads/master@{#435872} [modify] https://crrev.com/c1c2eff354215eb43e9b2ae9af9ddad22641c10d/tools/perf/benchmarks/page_cycler_v2.py
,
Dec 2 2016
|
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by benjhayden@chromium.org
, Sep 25 2016