Issue metadata
Sign in to add a comment
|
3.8%-11.1% regression in thread_times.key_idle_power_cases at 420019:420049 |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Sep 25 2016
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/9000579453844578736
,
Sep 25 2016
=== Auto-CCing suspected CL author hpayer@chromium.org === Hi hpayer@chromium.org, the bisect results pointed to your CL below as possibly causing a regression. Please have a look at this info and see whether your CL be related. ===== BISECT JOB RESULTS ===== Status: completed ===== SUSPECTED CL(s) ===== Subject : [heap] Make slot set state and operations atomic. Author : hpayer Commit description: Here we only change the type of the slot set fields to atomic values and use CAS to change the state. There is no change in behavior or semantics of the slot set. BUG= chromium:648568 Review-Url: https://codereview.chromium.org/2353553003 Cr-Commit-Position: refs/heads/master@{#39557} Commit : e05e735a8ab39b5f871c9356b993d52d562e7fee Date : Tue Sep 20 14:58:54 2016 ===== TESTED REVISIONS ===== Revision Mean Std Dev N Good? chromium@420026 0.438877 0.00579774 5 good chromium@420027 0.434448 0.0108191 5 good chromium@420027,v8@b88df1c9e4 0.434937 0.00781767 5 good chromium@420027,v8@b88d132f4c 0.433598 0.00892304 5 good chromium@420027,v8@57d8193764 0.436999 0.00461641 5 good chromium@420027,v8@e05e735a8a 0.476339 0.00584841 5 bad <-- chromium@420028 0.475217 0.00640253 5 bad chromium@420029 0.474536 0.00692454 5 bad chromium@420031 0.475225 0.00985015 5 bad Bisect job ran on: android_s5_perf_bisect Bug ID: 649993 Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --also-run-disabled-tests thread_times.key_idle_power_cases Test Metric: thread_total_all_cpu_time_per_second/css-animation.html Relative Change: 8.28% Score: 99.9 Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_s5_perf_bisect/builds/1030 Job details: https://chromeperf.appspot.com/buildbucket_job_status/9000579453844578736 Not what you expected? We'll investigate and get back to you! https://chromeperf.appspot.com/bad_bisect?try_job_id=5337276010201088 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Tests>AutoBisect. Thank you!
,
Oct 11 2016
Perf sheriff ping
,
Oct 19 2016
hpayer@, from the description of that CL, I assume that that couldn't have affected performance, right?
,
Oct 19 2016
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8998350842859946304
,
Oct 19 2016
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8998350830599838960
,
Oct 19 2016
Bisect failed: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_s5_perf_bisect/builds/1115 Failure reason: the build has failed. Additional errors: The metric was not found in the test output. Either of the initial "good" or "bad" revisions failed to be tested or built.
,
Oct 19 2016
Bisect failed: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_nexus7_perf_bisect/builds/3417 Failure reason: the build has failed. Additional errors: The metric was not found in the test output. Either of the initial "good" or "bad" revisions failed to be tested or built.
,
Dec 16 2016
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8993079578141718080
,
Dec 16 2016
+skyostil, do you know the current status of this benchmark? It looks like it was dropped or renamed. What's your recommended action here?
,
Dec 17 2016
===== BISECT JOB RESULTS ===== Status: completed ===== TESTED REVISIONS ===== Revision Mean Std Dev N Good? chromium@420026 0.312787 0.0470189 9 good chromium@420027 0.316346 0.0719153 9 good chromium@420028 0.334618 0.00887121 9 bad chromium@420029 0.335468 0.0221839 9 bad chromium@420032 0.335379 0.0102566 9 bad chromium@420038 0.336713 0.0125151 9 bad chromium@420049 0.344792 0.0387506 9 bad Bisect job ran on: android_nexus7_perf_bisect Bug ID: 649993 Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=set.timeout.html thread_times.key_idle_power_cases Test Metric: thread_total_all_cpu_time_per_second/set-timeout.html Relative Change: 10.23% Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_nexus7_perf_bisect/builds/3564 Job details: https://chromeperf.appspot.com/buildbucket_job_status/8993079578141718080 Not what you expected? We'll investigate and get back to you! https://chromeperf.appspot.com/bad_bisect?try_job_id=5329351413858304 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Tests>AutoBisect. Thank you!
,
Dec 19 2016
This benchmark is still very valid, but what it's guarding against isn't small fluctuations like this but big spikes when something breaks in our throttling logic (see some past instances on the charts). I think it's fine WontFix this one.
,
Dec 21 2016
,
Apr 11 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8982584705052245296 |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by benjhayden@chromium.org
, Sep 25 2016