New issue
Advanced search Search tips

Issue 649991 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Oct 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

11.5% regression in dromaeo.domcoretraverse at 420019:420034

Project Member Reported by benjhayden@chromium.org, Sep 25 2016

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=649991

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgxej_ugoM


Bot(s) for this bug's original alert(s):

android-galaxy-s5
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Sep 25 2016


===== BISECT JOB RESULTS =====
Status: completed


=== Bisection aborted ===
The bisect was aborted because The metric values for the initial "good" and "bad" revisions do not represent a clear regression.
Please contact the the team (see below) if you believe this is in error.

=== Warnings ===
The following warnings were raised by the bisect job:

 * Bisect failed to reproduce the regression with enough confidence.

===== TESTED REVISIONS =====
Revision         Mean     Std Dev  N   Good?
chromium@420018  146.493  2.89854  18  good
chromium@420034  146.135  2.75442  18  bad

Bisect job ran on: android_s5_perf_bisect
Bug ID: 649991

Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --also-run-disabled-tests dromaeo.domcoretraverse
Test Metric: dom/dom
Relative Change: 2.08%
Score: 0

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_s5_perf_bisect/builds/1029
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9000579479587696608


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5827338690887680

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!

===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Change the CompilerDispatcherJob to take a SharedFunctionInfo
Author  : jochen
Commit description:
  
This means we can no longer take the closure's context to parse, but
need to rely on the outer scope info.

Since it's not possible to get that, however, for lazy functions, we
introduce a new field to SharedFunctionInfo that stores the outer scope
info whenever available.

BUG= v8:5215 
R=marja@chromium.org,verwaest@chromium.org,jgruber@chromium.org

Review-Url: https://codereview.chromium.org/2358503002
Cr-Commit-Position: refs/heads/master@{#39548}
Commit  : 0f0912dd23911eec6d1c5e6d3ebba1ece0ff3361
Date    : Tue Sep 20 12:08:42 2016


===== TESTED REVISIONS =====
Revision                       Mean     Std Dev  N   Good?
chromium@420018                147.163  1.44019  12  good
chromium@420026                148.571  1.68538  12  good
chromium@420027                148.275  2.18336  12  good
chromium@420027,v8@4f5695229e  146.851  3.59123  12  good
chromium@420027,v8@0f0912dd23  143.4    2.17526  12  bad    <--
chromium@420027,v8@05eb56798e  144.635  2.01584  8   bad
chromium@420027,v8@b88df1c9e4  146.257  3.54202  8   bad
chromium@420028                145.767  2.93199  8   bad
chromium@420030                144.948  3.69813  12  bad
chromium@420034                144.974  2.33817  12  bad

Bisect job ran on: android_s5_perf_bisect
Bug ID: 649991

Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --also-run-disabled-tests dromaeo.domcoretraverse
Test Metric: dom/dom
Relative Change: 0.32%
Score: 90.0

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_s5_perf_bisect/builds/1054
Job details: https://chromeperf.appspot.com/buildbucket_job_status/8999842208431851440


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5318309468176384

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Cc: benjhayden@chromium.org
Owner: jochen@chromium.org
Jochen, PTAL at the above regression graphs and bisect.
Perf sheriff ping

Comment 8 by jochen@chromium.org, Oct 12 2016

Status: WontFix (was: Assigned)
I don't see a similar change on any other bot, and my change almost only affects code that isn't shipping yet, so I'll close this as wontfix for now
Sounds good, thanks :-)

Sign in to add a comment