New issue
Advanced search Search tips

Issue 649984 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Sep 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

22.4%-340.1% regression in smoothness.top_25_smooth at 419372:419388

Project Member Reported by benjhayden@chromium.org, Sep 25 2016

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=649984

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgxf2joAoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgxbuJsQoM


Bot(s) for this bug's original alert(s):

chromium-rel-win7-gpu-intel
chromium-rel-win8-dual
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Sep 25 2016

Cc: japhet@chromium.org
Owner: japhet@chromium.org

=== Auto-CCing suspected CL author japhet@chromium.org ===

Hi japhet@chromium.org, the bisect results pointed to your CL below as possibly
causing a regression. Please have a look at this info and see whether
your CL be related.


===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Listen to didReceiveResponse() to get the response in WebViewPlugin.
Author  : japhet
Commit description:
  
This is a partial revert of the WebViewPlugin changes in
https://crrev.com/8489f1bf78c2c6f296e0df6c529751d29e8a0188

BUG= 641028 

Review-Url: https://codereview.chromium.org/2349443003
Cr-Commit-Position: refs/heads/master@{#419387}
Commit  : 8ed4bf69eca5e2696aeab731a8e9a15e8f379f2b
Date    : Sat Sep 17 22:26:21 2016


===== TESTED REVISIONS =====
Revision         Mean     Std Dev    N  Good?
chromium@419371  2.748    0.0641522  5  good
chromium@419380  2.963    0.643056   5  good
chromium@419385  3.2776   1.38997    5  good
chromium@419386  2.867    0.333799   5  good
chromium@419387  19.4868  2.66368    5  bad    <--
chromium@419388  19.5114  3.09229    5  bad

Bisect job ran on: winx64intel_perf_bisect
Bug ID: 649984

Test Command: src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --upload-results --also-run-disabled-tests smoothness.top_25_smooth
Test Metric: mean_input_event_latency/http___techcrunch.com
Relative Change: 610.02%
Score: 99.9

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/winx64intel_perf_bisect/builds/1172
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9000579583843161088


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5850163220840448

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Status: WontFix (was: Assigned)
It looks like browse_news is the only subpageset in v8.browsing_desktop that regressed, and it seems to have recovered.
The regression in v8.browsing_desktop / v8-gc-total_sum recovered between 420102 - 420168 .
The regression in v8.browsing_desktop / v8-gc-latency-mark-compactor_sum  recovered between 420098 - 420153 .
The regression in v8.browsing_desktop / v8-gc-incremental-finalize_sum recovered between 420074 - 420145 .

The regression in Weather.com in smoothness.top25/percentage_smooth seems to have roughly tracked ref and looks insignificant compared to everything else going on.

The regression in mean_input_event_latency / techcrunch looks like it was returning to normal levels after a strange temporary improvement, before and after which it was roughly on par with ref.

japhet suggests that, if his change did cause a regression, it was because his change caused flash to correctly instantiate where it was brokenly not instantiating: 641028 .

sgtm! Closing.

Sign in to add a comment