probably something like https://codereview.chromium.org/23757130

@thakis it looks like that link is broken

I think it's https://codereview.chromium.org/2375713002/

Sorry looks like the last two digits got cut off: https://codereview.chromium.org/2375713002

Made a CL to remove a couple of apparently redundant checks: https://codereview.chromium.org/2768073003

In addition, we probably want to remove third_party/WebKit from the top-level presubmit _EXCLUDED_PATHS list, and then remove the PanProjectChecks call in third_party/WebKit.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5e1457c6a247571aa25c76364693863b7bdd4b7f

commit 5e1457c6a247571aa25c76364693863b7bdd4b7f
Author: qyearsley <qyearsley@chromium.org>
Date: Thu Mar 23 23:14:39 2017

Remove redundant checks from third_party/WebKit/PRESUBMIT.py.

Redudant checks removed in this CL:
    _CheckForVersionControlConflicts
    _CheckPatchFiles
    _CheckFilePermissions

These checks are already in _CommonChecks in the top-level PRESUBMIT.py,
and they apply in third_party/WebKit from that already.
(https://cs.chromium.org/chromium/src/PRESUBMIT.py?l=2093)

Note that third_party/WebKit is in an _EXCLUDED_PATHS global in that
file, but it's not excluded from these checks in the top-level presubmit
since that global isn't taken into consideration for these checks.

BUG=649970

Review-Url: https://codereview.chromium.org/2768073003
Cr-Commit-Position: refs/heads/master@{#459270}

[modify] https://crrev.com/5e1457c6a247571aa25c76364693863b7bdd4b7f/third_party/WebKit/PRESUBMIT.py

This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Doing Blink > Infra bugs triage.

qyearsley@: is there still more to do for this bug?

I think so -- I don't think that the Blink presubmit needs to include PanProjectChecks, since that's already covered by the top-level presubmit. Although it's different now for Blink than for the rest of Chromium, since the Blink one is more lax with regards to line length and license header. There are also other little things like CheckTreeIsOpen that are done twice now.

Main presubmit:
https://cs.chromium.org/chromium/src/PRESUBMIT.py

Pre-move Blink presubmit:
https://cs.chromium.org/chromium/src/third_party/WebKit/PRESUBMIT.py

Post-move Blink presubmit:
https://cs.chromium.org/chromium/src/third_party/blink/PRESUBMIT.py