New issue
Advanced search Search tips

Issue 649969 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 563793



Sign in to add a comment

Blink clang-format preparation

Project Member Reported by dcheng@chromium.org, Sep 25 2016

Issue description

Catch-all bug for various things we need to fix prior to using clang-format on Blink.

For example, the presubmit scripts in third_party/WebKit/Source/core/frame/PRESUBMIT.py need to be updated.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1817af69e71e157c64e2961839a5c9ba45dbaca2

commit 1817af69e71e157c64e2961839a5c9ba45dbaca2
Author: dcheng <dcheng@chromium.org>
Date: Sun Sep 25 13:02:41 2016

Preformat UseCounter.h to avoid clang-format confusing the UMA scripts.

There are a number of python scripts that parse this file and expect
lines to be formatted a certain way. If a line is too long, clang-format
will wrap it and break the format that the python script is expecting.

BUG= 649969 

Review-Url: https://codereview.chromium.org/2364383002
Cr-Commit-Position: refs/heads/master@{#420858}

[modify] https://crrev.com/1817af69e71e157c64e2961839a5c9ba45dbaca2/third_party/WebKit/Source/core/frame/UseCounter.h

Project Member

Comment 2 by bugdroid1@chromium.org, Sep 26 2016

Project Member

Comment 3 by bugdroid1@chromium.org, Sep 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c4c4814a47286093f5ea69a9ae5070d14dd48572

commit c4c4814a47286093f5ea69a9ae5070d14dd48572
Author: dcheng <dcheng@chromium.org>
Date: Fri Sep 30 02:47:16 2016

Update PRESUBMIT check for use counters to handle C++ formatting changes

Long-term, we probably want to consider generating this somehow, rather
than using regex to try to parse stuff out of C++.

BUG= 649969 

Review-Url: https://codereview.chromium.org/2380003003
Cr-Commit-Position: refs/heads/master@{#422017}

[modify] https://crrev.com/c4c4814a47286093f5ea69a9ae5070d14dd48572/third_party/WebKit/Source/core/frame/PRESUBMIT.py

Status: Fixed (was: Started)

Sign in to add a comment