New issue
Advanced search Search tips

Issue 649938 link

Starred by 2 users
Status: Verified
Owner: ----
Closed: Mar 2017
Cc:
pkasting@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

tab to search hint still displayed when unfocus omnibox

Reported by jhwon0...@gmail.com, Sep 24 2016 
UserAgent: Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/53.0.2785.116 Safari/537.36

Steps to reproduce the problem:
1. write search engine like google.com in omnibox
2. when tab to search hint display, unfocus
3. still tab to search displayed

What is the expected behavior?
because omnibox is not focused, cannot search when press tab, so tab to search hit have to disapear

What went wrong?
tab to search still displayed

Did this work before? N/A 

Chrome version: 53.0.2785.116  Channel: stable
OS Version: 10.0
Flash Version: Shockwave Flash 23.0 r0

I wonder this thing is intended, or not

Comment 1 by kei98...@gmail.com, Oct 1 2016 

Attach
ActualResult.mp4
496 KB View Download
ExpectedResult.mp4
619 KB View Download

Comment 2 by simonh...@chromium.org, Oct 1 2016

Cc: pkasting@chromium.org
Labels: OS-Linux OS-Mac

Comment 3 by pkasting@chromium.org, Oct 2 2016

Labels: -Pri-2 OS-Chrome Pri-3
Status: Available (was: Unconfirmed)
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8af82bd5840c4c51bb1e31055446808abda90e7b

commit 8af82bd5840c4c51bb1e31055446808abda90e7b
Author: kei98301 <kei98301@gmail.com>
Date: Wed Mar 08 11:04:08 2017

Fix a bug that viewed Omnibox hint when hint loses focus.

In the current implementation, If we input search engine
such as 'google.com' in omnibox, 'Press tab to search' hint
displays. Then the hint does not disappear in spite of
the loss of omnibox focus. So, I modified OnFocus() and
OnBlur() in omnibox_view_views.cc that focus changes affect
the visibility of any keyword hint.

BUG= 649938 

Review-Url: https://codereview.chromium.org/2373773002
Cr-Commit-Position: refs/heads/master@{#455429}

[modify] https://crrev.com/8af82bd5840c4c51bb1e31055446808abda90e7b/AUTHORS
[modify] https://crrev.com/8af82bd5840c4c51bb1e31055446808abda90e7b/chrome/browser/ui/views/location_bar/location_bar_view.cc
[modify] https://crrev.com/8af82bd5840c4c51bb1e31055446808abda90e7b/chrome/browser/ui/views/omnibox/omnibox_view_views.cc

Comment 5 by pkasting@chromium.org, Mar 8 2017

Status: Fixed (was: Available)
Assuming fixed in r455429

Comment 6 by sdantul...@chromium.org, May 8 2017

Status: Verified (was: Fixed)
9532.0.0, 60.0.3092.0
►

Sign in to add a comment