Video Player spacebar behaviour not consistent
Reported by
jonathan...@gmail.com,
Sep 24 2016
|
|||||||||
Issue descriptionChrome Version: 52.0.2743.116 Chrome OS Version: 8350.68.0 (Official Build) Chrome OS Platform: Dell Chromebook 11 Steps To Reproduce: (1) Start playing a video file from within Chrome OS Files so it loads the Video Player (2) Make the video full screen by clicking the fullscreen icon (3) Press spacebar Expected Result: Video should play/pause Actual Result: Video toggles fullscreen - How frequently does this problem reproduce? Always when opening a video file and clicking the fullscreen icon first before pressing space. However if, after opening the video, spacebar is pressed straight away it does work to action play/pause. Essentially, the bug only shows if the last mouse clicked action in the Video Player is the toggle fullscreen icon. If the last mouse clicked action within the Video Player was play/pause then the spacebar still always works as expected. - What is the impact to the user, and is there a workaround? The impact is that the spacebar is inconsistent with expected behaviour from every other video player ever and it's not clear at any given time from the interface what action the spacebar will cause. Google's own YouTube and most other online video playback services have one action only that the spacebar performs and that is play/pause. This bug has only been there since the Material Design revamp of the Video Player within Chrome OS.
,
Sep 28 2016
jonathantrengrove@ This is a expected behavior of the video player in chromeOS as focus is on fullscreen icon. fukino@ please confirm, Thanks!
,
Sep 29 2016
We should try and fix this. fukino@, if this is expected behavior today then should we file a feature request to change it?
,
Sep 29 2016
The problem is that there isn't any indication that either icon has focus at any time. The interface always looks the same. On the attached screenshot how can we tell beforehand what action will occur by pressing spacebar? We can't. Expected outcomes from human computer interactions should always be consistent for a good user experience. My vote would be for spacebar to be play/pause at all times; as it was on the original Chrome OS Video Player and as it is on macOS QuickTime Player, Windows Media Player, VLC media player and also on YouTube.
,
Sep 30 2016
We can't always toggle play/pause on spacebar. For keyboard accessibility, pressing spacebar should press a button when it has focus. (For example, if you click mute button on Youtube and then press space bar, it toggles mute state rather than the pause state). That said, on Youtube, when the player get fullscreen, the focus is reset to the player and it makes spacebar usable for play/pause. (On exiting fullscreen, this doesn't occur) I feel this is a reasonable twist, and we can do the same.
,
Sep 30 2016
,
Sep 30 2016
I've just tried with YouTube and you're right, I had never noticed this before. Your proposed twist sounds reasonable and would fix the main place where I find the spacebar doesn't behave as I would like (which is after making a video fullscreen and then later wanting to pause with the spacebar).
,
Sep 30 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c16ace9166eaa0dc45f613c74a8f81b21c36c79f commit c16ace9166eaa0dc45f613c74a8f81b21c36c79f Author: fukino <fukino@chromium.org> Date: Fri Sep 30 10:45:27 2016 Video player: Reset the focus on entering fullscree mode. To use spacebar for pause/play, we need to reset the focus on entering fullscreen mode. Without this code, spacebar will toggle fullscreen state and it is not consistent with Youtube. BUG= 649926 TEST=manually tested CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2382993003 Cr-Commit-Position: refs/heads/master@{#422076} [modify] https://crrev.com/c16ace9166eaa0dc45f613c74a8f81b21c36c79f/ui/file_manager/video_player/js/media_controls.js
,
Sep 30 2016
The patch landed on main branch, and will be shipped with Chrome 55. Thank you jonathantrengrove@ for pointing it out!
,
Nov 19 2016
,
Apr 17 2017
,
Apr 18 2017
Verified on 9460.1.0, 59.0.3071.8 |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by jonathan...@gmail.com
, Sep 27 2016