New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 649892 link

Starred by 3 users

Issue metadata

Status: WontFix
Owner:
Last visit > 30 days ago
Closed: Oct 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome
Pri: 2
Type: Bug

Blocking:
issue 630357



Sign in to add a comment

Harmony - Buttons missing drop shadow during hover and press

Project Member Reported by shrike@chromium.org, Sep 24 2016

Issue description

Version: 55.0.2869.0
OS: Win10, 10.11

The Harmony spec says that Default buttons should have a slight drop shadow when pressed. This shadow is not visible on Windows or Mac, so I think it's not being drawn.

Attached is a screenshot of the pressed state on Windows.

 
Screen Shot 2016-09-23 at 5.42.34 PM.png
43.3 KB View Download

Comment 1 by shrike@chromium.org, Sep 24 2016

Summary: Harmony - Buttons missing drop shadow during hover and press (was: Harmony - Default buttons missing drop shadow when pressed)
Actually, I realize the spec says there's a drop shadow during hover and press, and for both normal and Default buttons. I'm not able to check how regular buttons appear on hover but I suspect they don't have a shadow right now either.

Comment 2 by est...@chromium.org, Sep 26 2016

the shadow does not appear on normal buttons yet. The spec changed in that regard and I haven't yet updated the implementation.

A shadow does already appear on hover/press for the prominent buttons. Are you sure it doesn't appear on Windows? It works on CrOS and Linux.

The reason it doesn't work on Mac is that it uses an ink drop-based hover effect, and we disable ink drops on Mac. We probably need to enable ink drop hover effects while leaving the ripple effects off.

Comment 3 by shrike@chromium.org, Sep 26 2016

> A shadow does already appear on hover/press for the prominent buttons. Are you sure it doesn't appear on Windows? It works on CrOS and Linux.

The screenshot above is from a Windows machine, so it seems like the shadow is not present on Windows (for whatever reason).

Comment 4 by est...@chromium.org, Sep 26 2016

yea, but I also don't see a cursor in that screenshot, which makes me think that however you're taking the screenshot might remove the cursor + hover.

Comment 5 by shrike@chromium.org, Sep 27 2016

The screenshot documents what I saw (I would not be reporting this problem if I saw the shadow when clicking the button).

You should round up a Windows machine and take a look for yourself.

Owner: shrike@chromium.org
Labels: -M-55 Proj-HarmonyControls M-56
Labels: -OS-Mac
Status: WontFix (was: Assigned)
Why is this wontfix? Does the shadow appear on Windows?
I checked it again and it's there when I hover, and when I click.

Sign in to add a comment