New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 649888 link

Starred by 2 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Valid origin headers should probably not include Chrome specific schemes

Project Member Reported by jww@chromium.org, Sep 24 2016

Issue description

While working on https://codereview.chromium.org/2332263002/ which changes the check for valid origin headers in content/browser/loader/resource_dispatcher_host_impl.cc from using committable URLs to specific origin-header-allowable URLs, it was pointed out that this allows URLs with schemes such as chrome: or view-source: to be in the Origin header. It doesn't feel right that these URLs should be sent out to the web generally. We should track down whether we can ban them in the origin header outright, and if so, update the new ChildProcessSecurityPolicyImpl::CanSetAsOriginHeader() method to do a check for those.
 

Comment 1 by mkwst@chromium.org, Feb 23 2017

Labels: -OS-All OS-Android OS-Chrome OS-Linux OS-Mac OS-Windows
Status: Available (was: Untriaged)

Comment 2 by est...@chromium.org, Nov 10 2017

Labels: Hotlist-EnamelAndFriendsFixIt

Comment 3 by est...@chromium.org, Feb 18 2018

Labels: -Hotlist-EnamelAndFriendsFixIt

Sign in to add a comment