NQE should experiment with different statistics |
||||||||||
Issue descriptionCurrently, NQE computes the weighted median of RTT and throughput observations, and uses the weighted median value for estimating the network quality. Besides the weighted median, NQE should also experiment with other statistics (e.g., average, weighted average). For this, NQE should use these different statistics, and only record the accuracy in histograms without actually changing any of the public APIs. If the accuracy results are better than weighted median, we should eventually consider moving the public APIs.
,
Oct 19 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d53a4ba712f3941e9c7f9f70dbc75fd2136ff14e commit d53a4ba712f3941e9c7f9f70dbc75fd2136ff14e Author: tbansal <tbansal@chromium.org> Date: Wed Oct 19 00:04:37 2016 NQE: Add more statistics to ObservationBuffer class Add APIs to compute weighted average and unweighted average to the ObservationBuffer class. These statistics would be used to compute the network quality, and then compare their accuracy with the weighted median statistic (which is currently in use). CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.android:android_cronet BUG= 649887 Review-Url: https://codereview.chromium.org/2411833003 Cr-Commit-Position: refs/heads/master@{#426095} [modify] https://crrev.com/d53a4ba712f3941e9c7f9f70dbc75fd2136ff14e/net/nqe/observation_buffer.h [modify] https://crrev.com/d53a4ba712f3941e9c7f9f70dbc75fd2136ff14e/net/nqe/observation_buffer_unittest.cc
,
Nov 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5dc7d494a315b2a728a30b46130258269a1a1b06 commit 5dc7d494a315b2a728a30b46130258269a1a1b06 Author: tbansal <tbansal@chromium.org> Date: Mon Nov 07 21:49:44 2016 NQE: Store the current network quality in a single variable Network Quality Estimator (NQE): Store the current network quality in a single variable instead of 3 different variables. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester BUG= 649887 Review-Url: https://codereview.chromium.org/2461833002 Cr-Commit-Position: refs/heads/master@{#430385} [modify] https://crrev.com/5dc7d494a315b2a728a30b46130258269a1a1b06/net/nqe/network_quality_estimator.cc [modify] https://crrev.com/5dc7d494a315b2a728a30b46130258269a1a1b06/net/nqe/network_quality_estimator.h [modify] https://crrev.com/5dc7d494a315b2a728a30b46130258269a1a1b06/net/nqe/network_quality_estimator_test_util.cc [modify] https://crrev.com/5dc7d494a315b2a728a30b46130258269a1a1b06/net/nqe/network_quality_estimator_test_util.h [modify] https://crrev.com/5dc7d494a315b2a728a30b46130258269a1a1b06/net/nqe/network_quality_estimator_unittest.cc
,
Feb 13 2017
,
Feb 14 2017
,
Feb 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b17f5a4f08fcccd4b4787e3c9d2e683183f5d7b3 commit b17f5a4f08fcccd4b4787e3c9d2e683183f5d7b3 Author: tbansal <tbansal@chromium.org> Date: Tue Feb 21 23:05:38 2017 NQE: Cleanup the calls to the observation buffer In Network Quality Estimator (NQE), cleanup the calls to the observation buffer, and reduce duplication. This CL makes it simpler to record accuracy of different statistics (see the linked bug). BUG= 649887 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester Review-Url: https://codereview.chromium.org/2707633002 Cr-Commit-Position: refs/heads/master@{#451854} [modify] https://crrev.com/b17f5a4f08fcccd4b4787e3c9d2e683183f5d7b3/net/nqe/network_quality_estimator.cc [modify] https://crrev.com/b17f5a4f08fcccd4b4787e3c9d2e683183f5d7b3/net/nqe/network_quality_estimator.h
,
Feb 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0b44f01eabbb3d90eb98b37f4bffceb98e7bbf07 commit 0b44f01eabbb3d90eb98b37f4bffceb98e7bbf07 Author: tbansal <tbansal@chromium.org> Date: Tue Feb 28 03:03:40 2017 Record RTT prediction accuracy when using average algorithms In Network Quality Estimator (NQE), record the accuracy of HTTP RTT prediction when using weighted average and unweighted average algorithms. Also, record the HTTP RTT computed using weighted average algorithm. BUG= 649887 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester Review-Url: https://codereview.chromium.org/2710973003 Cr-Commit-Position: refs/heads/master@{#453480} [modify] https://crrev.com/0b44f01eabbb3d90eb98b37f4bffceb98e7bbf07/net/nqe/network_quality_estimator.cc [modify] https://crrev.com/0b44f01eabbb3d90eb98b37f4bffceb98e7bbf07/net/nqe/network_quality_estimator.h [modify] https://crrev.com/0b44f01eabbb3d90eb98b37f4bffceb98e7bbf07/net/nqe/network_quality_estimator_test_util.cc [modify] https://crrev.com/0b44f01eabbb3d90eb98b37f4bffceb98e7bbf07/net/nqe/network_quality_estimator_test_util.h [modify] https://crrev.com/0b44f01eabbb3d90eb98b37f4bffceb98e7bbf07/net/nqe/network_quality_estimator_unittest.cc [modify] https://crrev.com/0b44f01eabbb3d90eb98b37f4bffceb98e7bbf07/tools/metrics/histograms/histograms.xml
,
Mar 23 2017
,
Apr 30 2017
,
May 30 2017
,
Aug 18 2017
Opening the bug back to track the work for experimenting with other statistical algorithms (e.g., extrapolation).
,
Aug 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c880b491b82e6d95631dedba25c3f698f42bf460 commit c880b491b82e6d95631dedba25c3f698f42bf460 Author: Tarun Bansal <tbansal@chromium.org> Date: Tue Aug 22 19:13:18 2017 NQE: Remove logic for computing network quality using different statistics Remove the logic for computing weighted averages and unweighted averages. That experiment is no longer running. Bug: 649887 , 722667, 722664 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester Change-Id: Ieb01bfe680f56fcb87185be5fc9a2447f38b49f2 Reviewed-on: https://chromium-review.googlesource.com/615182 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Reviewed-by: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#496395} [modify] https://crrev.com/c880b491b82e6d95631dedba25c3f698f42bf460/net/nqe/network_quality_estimator.cc [modify] https://crrev.com/c880b491b82e6d95631dedba25c3f698f42bf460/net/nqe/network_quality_estimator.h [modify] https://crrev.com/c880b491b82e6d95631dedba25c3f698f42bf460/net/nqe/network_quality_estimator_unittest.cc [modify] https://crrev.com/c880b491b82e6d95631dedba25c3f698f42bf460/net/nqe/observation_buffer.cc [modify] https://crrev.com/c880b491b82e6d95631dedba25c3f698f42bf460/net/nqe/observation_buffer.h [modify] https://crrev.com/c880b491b82e6d95631dedba25c3f698f42bf460/net/nqe/observation_buffer_unittest.cc [modify] https://crrev.com/c880b491b82e6d95631dedba25c3f698f42bf460/tools/metrics/histograms/histograms.xml
,
Dec 1 2017
,
Dec 1 2017
,
Dec 1 2017
|
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by bugdroid1@chromium.org
, Oct 1 2016