Move more fields from NavigationEntry to FrameNavigationEntry |
|||
Issue descriptionNow that we keep track of subframe navigations in FrameNavigationEntry, we should move frame-specific fields from NavigationEntry to FrameNavigationEntry. This likely includes at least: - transition_type - original_request_url - http_status_code - post_data - should_replace_entry - redirect_chain - frame_tree_node_id (or remove it)
,
Oct 4 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e6b67c20b5159f5fa10108b8ebccb9cf95c18479 commit e6b67c20b5159f5fa10108b8ebccb9cf95c18479 Author: arthursonzogni <arthursonzogni@chromium.org> Date: Tue Oct 04 09:46:04 2016 Move redirect_chain from NavigationEntry to FrameNavigationEntry. Now that we keep track of subframe navigations in FrameNavigationEntry, this CL move the redirect_chain field from NavigationEntry to FrameNavigationEntry. BUG=649879 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2368183004 Cr-Commit-Position: refs/heads/master@{#422737} [modify] https://crrev.com/e6b67c20b5159f5fa10108b8ebccb9cf95c18479/content/browser/frame_host/frame_navigation_entry.cc [modify] https://crrev.com/e6b67c20b5159f5fa10108b8ebccb9cf95c18479/content/browser/frame_host/frame_navigation_entry.h [modify] https://crrev.com/e6b67c20b5159f5fa10108b8ebccb9cf95c18479/content/browser/frame_host/navigation_controller_impl.cc [modify] https://crrev.com/e6b67c20b5159f5fa10108b8ebccb9cf95c18479/content/browser/frame_host/navigation_controller_impl_browsertest.cc [modify] https://crrev.com/e6b67c20b5159f5fa10108b8ebccb9cf95c18479/content/browser/frame_host/navigation_entry_impl.cc [modify] https://crrev.com/e6b67c20b5159f5fa10108b8ebccb9cf95c18479/content/browser/frame_host/navigation_entry_impl.h [modify] https://crrev.com/e6b67c20b5159f5fa10108b8ebccb9cf95c18479/content/browser/frame_host/navigator_impl.cc [add] https://crrev.com/e6b67c20b5159f5fa10108b8ebccb9cf95c18479/content/test/data/navigation_controller/page_with_iframe_redirect.html
,
Oct 4 2017
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 4 2017
This is important to do. I'll try to find time. (See issue 769048 .)
,
Oct 4 2017
Issue 769048 has been merged into this issue. |
|||
►
Sign in to add a comment |
|||
Comment 1 by arthurso...@chromium.org
, Sep 26 2016