Certificate viewer lays out badly on 10.12 |
|||||||||||
Issue descriptionFollow-up to bug 643123 . In that bug, the certificate viewer sheet was opening up with a ridiculously large height on 10.12, often too large to fit entirely on the screen, meaning that the OK button wasn’t reachable and the content area appeared blank. Trent found that there were autolayout gremlins and that they went away when we built with the 10.11 SDK (we’re now using 10.10 for official builds, we’d like to upgrade this but there’s bug 624049 for that). He fixed this in bug 643123 by constraining the height to 400px, but that was kind of a hack. So now we’ve got a sheet that at least sizes so that it can be displayed on any monitor, but its content is still wonky. The attached screenshot shows a bunch of whitespace before the Details disclosure thing. Yuck.
,
Sep 26 2016
How far out is bug 624049 ? If bumping the SDK fixes it, that seems ideal…
,
Sep 26 2016
Part of the work will be getting Chrome to build cleanly when linked against the 10.12 SDK - that's probably a decent chunk of work?
,
Sep 26 2016
I (and I think thakis@ and some other folks) have been developing with the 10.12 SDK since its stable release. Right now, the only open bugs I see related to it are: - bug 649696 : content_shell_helper_app doesn't link in component builds (fixed, should probably be closed) - bug 649698 : build warning (sounds like fix will just be filtering out the warning) - bug 648017 : CUPS issue (works for me, based on line numbers and the linked bug their checkout may be out of date). I get a clean build at ToT right now.
,
Sep 26 2016
Chrome builds with the 10.12 SDK without problems.
,
Sep 26 2016
Sorry - I realize I was thinking about the issues with changing the min deployment target.
,
Sep 26 2016
,
Oct 17 2016
rdar update: Our report, rdar://28380422 has been marked a duplicate of another, rdar://27743145. Still open.
,
Oct 19 2016
Issue 657096 has been merged into this issue.
,
Nov 23 2016
,
Nov 30 2016
,
Dec 20 2016
,
Jan 3 2017
In 10.12.2, the certificate viewer looks better. I think that we can close this and possibly also back out the workaround in bug 643123 .
,
Jan 11 2017
Yup - rdar://28380422 was updated on Jan 5th to say rdar://27743145 is now closed. Although I'd say this is bad enough that we'd want to enable the workaround still for 10.12.{0,1} until we are linking against SDK 10.12. (or maybe that's close enough that we just wait until we're linking against 10.12.)
,
Jan 31 2017
,
Mar 15 2017
,
Aug 8 2017
,
Nov 10 2017
,
Feb 18 2018
,
Sep 13
Archiving old bugs that haven't been actively assigned in over 180 days. If you feel this issue should still be addressed, feel free to reopen it or to file a new issue. Thanks!
,
Sep 13
Archiving old bugs that haven't been actively assigned in over 180 days. If you feel this issue should still be addressed, feel free to reopen it or to file a new issue. Thanks! |
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by calamity@chromium.org
, Sep 26 2016