New issue
Advanced search Search tips

Issue 649863 link

Starred by 2 users
Status: Fixed
Owner:
jmad...@chromium.org
Closed: Nov 2016
Cc:
jmad...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug

Blocked on:
issue 648709
issue 649503


Sign in to add a comment

Rename "Win7 Release (AMD R7 240)"

Project Member Reported by kbr@chromium.org, Sep 23 2016 
In Issue 648709 this bot:

https://build.chromium.org/p/chromium.gpu.fyi/builders/Win7%20Release%20%28AMD%20R7%20240%29

had one of the older AMD GPUs installed in it to act as a canary.

It should be renamed. I think the card is an R5 230 but am not 100% sure.

This will require changes in:

- tools/build/masters/master.chromium.gpu.fyi/slaves.cfg
- tools/build/scripts/slave/recipe_modules/chromium_tests/chromium_gpu_fyi.py
- Recipes need to be retrained
- chromium.gpu.fyi waterfall needs to be restarted
- chrome/src/content/test/gpu/generate_buildbot_json.py and that generation script re-run

Comment 1 by kbr@chromium.org, Sep 30 2016

Blockedon: 649503
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 27 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/01b12a365a3f04f97d9dadd3263c7760348b0740

commit 01b12a365a3f04f97d9dadd3263c7760348b0740
Author: jmadill <jmadill@chromium.org>
Date: Thu Oct 27 23:27:07 2016

gpu: Add duplicate AMD bot configs.

Many of the AMD configs were referring to themselves as ATI, which is
very out of date. Change this to AMD. Also update bot names as
required, and PCI device ids where needed.

This will require two more steps: one to update the build side
integration, and finally to remove the old configs.

BUG=639353, 649863 , 641080 
R=kbr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
NOTRY=true

Review-Url: https://codereview.chromium.org/2449163002
Cr-Commit-Position: refs/heads/master@{#428207}

[modify] https://crrev.com/01b12a365a3f04f97d9dadd3263c7760348b0740/content/test/gpu/generate_buildbot_json.py
[modify] https://crrev.com/01b12a365a3f04f97d9dadd3263c7760348b0740/testing/buildbot/chromium.gpu.fyi.json

Comment 3 by jmad...@chromium.org, Nov 1 2016

Owner: jmad...@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 2 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/130d87891c84466c4410d13e124b433d694e2acd

commit 130d87891c84466c4410d13e124b433d694e2acd
Author: jmadill <jmadill@chromium.org>
Date: Wed Nov 02 02:58:53 2016

Rename Windows and Mac AMD GPU bots.

These were sometimes calling the bots "ATI" when the name for the
past several years has been "AMD". This change lines up with the
src side-changes. Once it lands and the master is restarted, we
can remove the old bot configs in src.

BUG=639353,  649863 ,  641080 
R=kbr@chromium.org
TBR=dpranke@chromium.org

Review-Url: https://codereview.chromium.org/2467923002

[modify] https://crrev.com/130d87891c84466c4410d13e124b433d694e2acd/masters/master.chromium.gpu.fyi/slaves.cfg
[modify] https://crrev.com/130d87891c84466c4410d13e124b433d694e2acd/scripts/slave/recipe_modules/chromium_tests/chromium_gpu_fyi.py
[modify] https://crrev.com/130d87891c84466c4410d13e124b433d694e2acd/scripts/slave/recipe_modules/chromium_tests/trybots.py
[modify] https://crrev.com/130d87891c84466c4410d13e124b433d694e2acd/scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_GPU_Linux_Builder.json
[modify] https://crrev.com/130d87891c84466c4410d13e124b433d694e2acd/scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_GPU_Mac_Builder.json
[modify] https://crrev.com/130d87891c84466c4410d13e124b433d694e2acd/scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_GPU_Mac_Builder__dbg_.json
[modify] https://crrev.com/130d87891c84466c4410d13e124b433d694e2acd/scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_GPU_Win_Builder.json
[modify] https://crrev.com/130d87891c84466c4410d13e124b433d694e2acd/scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_GPU_Win_Builder__dbg_.json
[rename] https://crrev.com/130d87891c84466c4410d13e124b433d694e2acd/scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_Linux_Release__AMD_R5_230_.json
[rename] https://crrev.com/130d87891c84466c4410d13e124b433d694e2acd/scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_Mac_10_10_Debug__AMD_.json
[rename] https://crrev.com/130d87891c84466c4410d13e124b433d694e2acd/scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_Mac_10_10_Release__AMD_.json
[rename] https://crrev.com/130d87891c84466c4410d13e124b433d694e2acd/scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_Optional_Win7_Release__AMD_.json
[rename] https://crrev.com/130d87891c84466c4410d13e124b433d694e2acd/scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_Win7_Debug__AMD_.json
[rename] https://crrev.com/130d87891c84466c4410d13e124b433d694e2acd/scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_Win7_Release__AMD_.json
[rename] https://crrev.com/130d87891c84466c4410d13e124b433d694e2acd/scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_Win7_Release__AMD_R5_230_.json
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 2 2016 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/master-manager.git/+/a759cc7cd1ff5849d058c03f818216ccf1f16014

commit a759cc7cd1ff5849d058c03f818216ccf1f16014
Author: kbr <kbr@google.com>
Date: Wed Nov 02 03:36:07 2016
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 11 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/adeb70eb00de392da98c8cd0239d7309cd694de8

commit adeb70eb00de392da98c8cd0239d7309cd694de8
Author: jmadill <jmadill@chromium.org>
Date: Fri Nov 11 01:22:35 2016

gpu: Remove duplicated AMD bot configs.

Now that we've got the new names successfully running, we can
remove the old configurations.

BUG=639353, 649863 , 641080 
R=kbr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2492023002
Cr-Commit-Position: refs/heads/master@{#431440}

[modify] https://crrev.com/adeb70eb00de392da98c8cd0239d7309cd694de8/content/test/gpu/generate_buildbot_json.py
[modify] https://crrev.com/adeb70eb00de392da98c8cd0239d7309cd694de8/testing/buildbot/chromium.gpu.fyi.json

Comment 7 by jmad...@chromium.org, Nov 11 2016

Status: Fixed (was: Started)
Project Member

Comment 8 by bugdroid1@chromium.org, Nov 30 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/81fcc4bc6123ace8dd37db74fd2592e3e15ea46a

commit 81fcc4bc6123ace8dd37db74fd2592e3e15ea46a
Author: jmadill <jmadill@chromium.org>
Date: Wed Nov 30 20:14:47 2016

Add new Intel GPU bot names, remove old AMD.

One AMD config persisted from the renaming fixes from
earlier. Remove this as well as add the Win10 Intel bot config.

BUG= 649863 , 665968 
R=kbr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2536853002
Cr-Commit-Position: refs/heads/master@{#435394}

[modify] https://crrev.com/81fcc4bc6123ace8dd37db74fd2592e3e15ea46a/content/test/gpu/generate_buildbot_json.py
[modify] https://crrev.com/81fcc4bc6123ace8dd37db74fd2592e3e15ea46a/testing/buildbot/chromium.gpu.fyi.json
►

Sign in to add a comment