New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 649837 link

Starred by 4 users
Status: Assigned
Owner:
█ lushnikov@chromium.org
Last visit 29 days ago
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , All
Pri: 2
Type: Bug

Blocked on:
issue 670180
issue 652982


Sign in to add a comment

DevTools: introduce persistence/ module

Project Member Reported by lushnikov@chromium.org, Sep 23 2016 
Introduce a "persistence" module which will encapsulate all 
persistence-related functionality.

Ideally, the following should happen:
- the only module depending on persistence/ is sources/
- the following files move under persistence/:
  - FileManager
  - FileSystemMapping
  - IsolatedFileSystem
  - IsolatedFileSystemManager
  - FileSystemWorkspaceBinding
- NetworkMapping is purged (yay!)
- UISourceCode gets freed from persistent-related methods:
  - hasUnsavedCommittedChanges
  - forceLoadOnCheckContent
  - saveAs
  - checkContentUpdated
- ResourceScriptMapping/StylesSourceMapping are in charge of creating UISourceCodes for the Script/StyleSheet. Design doc for this last change: https://goo.gl/rt9RAS



A document, explaining the motivation and design goals:
https://docs.google.com/document/d/12EU7HgFNWBsP_3syPCviHEOmU-Yn-q4kiF6RT_kBmO0/edit#
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 26 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/685dabec5c99680300ced571e7aed09d43b2e9d3

commit 685dabec5c99680300ced571e7aed09d43b2e9d3
Author: lushnikov <lushnikov@chromium.org>
Date: Mon Sep 26 21:53:24 2016

DevTools: introduce persistence/ module

This patch introduces the persistence/ module. Most of the DevTools
code is unaware of the module; the only exception is sources/.

The patch starts unconditionally creating UISourceCodes for
network resources. WI.Persistence is responsible for synchronization
of network UISourceCodes with corresponding file system UISourceCodes.

The patch makes establishing file system mappings instantaneous.

As a pleasant side-effect of the patch, the node debugging with
workspaces now supports live edit.

Please, see bug for the outlined plan and design document.

BUG=649837
R=dgozman, pfeldman

Review-Url: https://codereview.chromium.org/2349343002
Cr-Commit-Position: refs/heads/master@{#421007}

[modify] https://crrev.com/685dabec5c99680300ced571e7aed09d43b2e9d3/third_party/WebKit/LayoutTests/http/tests/inspector/debugger-test.js
[modify] https://crrev.com/685dabec5c99680300ced571e7aed09d43b2e9d3/third_party/WebKit/LayoutTests/http/tests/inspector/isolated-filesystem-test.js
[add] https://crrev.com/685dabec5c99680300ced571e7aed09d43b2e9d3/third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-do-not-bind-dirty-sourcecode-expected.txt
[add] https://crrev.com/685dabec5c99680300ced571e7aed09d43b2e9d3/third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-do-not-bind-dirty-sourcecode.html
[add] https://crrev.com/685dabec5c99680300ced571e7aed09d43b2e9d3/third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-go-to-file-dialog-expected.txt
[add] https://crrev.com/685dabec5c99680300ced571e7aed09d43b2e9d3/third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-go-to-file-dialog.html
[add] https://crrev.com/685dabec5c99680300ced571e7aed09d43b2e9d3/third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-merge-editor-tabs-expected.txt
[add] https://crrev.com/685dabec5c99680300ced571e7aed09d43b2e9d3/third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-merge-editor-tabs.html
[add] https://crrev.com/685dabec5c99680300ced571e7aed09d43b2e9d3/third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-move-breakpoints-expected.txt
[add] https://crrev.com/685dabec5c99680300ced571e7aed09d43b2e9d3/third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-move-breakpoints.html
[add] https://crrev.com/685dabec5c99680300ced571e7aed09d43b2e9d3/third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-navigator-expected.txt
[add] https://crrev.com/685dabec5c99680300ced571e7aed09d43b2e9d3/third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-navigator.html
[add] https://crrev.com/685dabec5c99680300ced571e7aed09d43b2e9d3/third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-rename-mapped-file-expected.txt
[add] https://crrev.com/685dabec5c99680300ced571e7aed09d43b2e9d3/third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-rename-mapped-file.html
[add] https://crrev.com/685dabec5c99680300ced571e7aed09d43b2e9d3/third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-search-across-all-files-expected.txt
[add] https://crrev.com/685dabec5c99680300ced571e7aed09d43b2e9d3/third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-search-across-all-files.html
[add] https://crrev.com/685dabec5c99680300ced571e7aed09d43b2e9d3/third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-sync-content-expected.txt
[add] https://crrev.com/685dabec5c99680300ced571e7aed09d43b2e9d3/third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-sync-content-nodejs-expected.txt
[add] https://crrev.com/685dabec5c99680300ced571e7aed09d43b2e9d3/third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-sync-content-nodejs.html
[add] https://crrev.com/685dabec5c99680300ced571e7aed09d43b2e9d3/third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-sync-content.html
[add] https://crrev.com/685dabec5c99680300ced571e7aed09d43b2e9d3/third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-tabbed-editor-opens-network-uisourcecode-expected.txt
[add] https://crrev.com/685dabec5c99680300ced571e7aed09d43b2e9d3/third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-tabbed-editor-opens-network-uisourcecode.html
[add] https://crrev.com/685dabec5c99680300ced571e7aed09d43b2e9d3/third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-test.js
[add] https://crrev.com/685dabec5c99680300ced571e7aed09d43b2e9d3/third_party/WebKit/LayoutTests/http/tests/inspector/persistence/resources/foo.js
[modify] https://crrev.com/685dabec5c99680300ced571e7aed09d43b2e9d3/third_party/WebKit/LayoutTests/http/tests/inspector/search/sources-search-scope-in-files-expected.txt
[modify] https://crrev.com/685dabec5c99680300ced571e7aed09d43b2e9d3/third_party/WebKit/LayoutTests/inspector/file-system-project-expected.txt
[modify] https://crrev.com/685dabec5c99680300ced571e7aed09d43b2e9d3/third_party/WebKit/LayoutTests/inspector/file-system-project.html
[modify] https://crrev.com/685dabec5c99680300ced571e7aed09d43b2e9d3/third_party/WebKit/LayoutTests/inspector/initial-modules-load-expected.txt
[modify] https://crrev.com/685dabec5c99680300ced571e7aed09d43b2e9d3/third_party/WebKit/LayoutTests/inspector/open-with-rendering-option-enabled-expected.txt
[modify] https://crrev.com/685dabec5c99680300ced571e7aed09d43b2e9d3/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/scripts-panel.html
[modify] https://crrev.com/685dabec5c99680300ced571e7aed09d43b2e9d3/third_party/WebKit/LayoutTests/inspector/sources/debugger/file-system-project-mapping-expected.txt
[modify] https://crrev.com/685dabec5c99680300ced571e7aed09d43b2e9d3/third_party/WebKit/LayoutTests/inspector/sources/debugger/file-system-project-mapping.html
[modify] https://crrev.com/685dabec5c99680300ced571e7aed09d43b2e9d3/third_party/WebKit/LayoutTests/inspector/workspace-mapping-expected.txt
[modify] https://crrev.com/685dabec5c99680300ced571e7aed09d43b2e9d3/third_party/WebKit/LayoutTests/inspector/workspace-mapping.html
[modify] https://crrev.com/685dabec5c99680300ced571e7aed09d43b2e9d3/third_party/WebKit/Source/devtools/BUILD.gn
[modify] https://crrev.com/685dabec5c99680300ced571e7aed09d43b2e9d3/third_party/WebKit/Source/devtools/front_end/bindings/CompilerScriptMapping.js
[modify] https://crrev.com/685dabec5c99680300ced571e7aed09d43b2e9d3/third_party/WebKit/Source/devtools/front_end/bindings/FileSystemWorkspaceBinding.js
[modify] https://crrev.com/685dabec5c99680300ced571e7aed09d43b2e9d3/third_party/WebKit/Source/devtools/front_end/bindings/NetworkMapping.js
[modify] https://crrev.com/685dabec5c99680300ced571e7aed09d43b2e9d3/third_party/WebKit/Source/devtools/front_end/bindings/NetworkProject.js
[modify] https://crrev.com/685dabec5c99680300ced571e7aed09d43b2e9d3/third_party/WebKit/Source/devtools/front_end/bindings/ResourceScriptMapping.js
[modify] https://crrev.com/685dabec5c99680300ced571e7aed09d43b2e9d3/third_party/WebKit/Source/devtools/front_end/bindings/SASSSourceMapping.js
[modify] https://crrev.com/685dabec5c99680300ced571e7aed09d43b2e9d3/third_party/WebKit/Source/devtools/front_end/bindings/StylesSourceMapping.js
[modify] https://crrev.com/685dabec5c99680300ced571e7aed09d43b2e9d3/third_party/WebKit/Source/devtools/front_end/inspector.json
[modify] https://crrev.com/685dabec5c99680300ced571e7aed09d43b2e9d3/third_party/WebKit/Source/devtools/front_end/main/Main.js
[modify] https://crrev.com/685dabec5c99680300ced571e7aed09d43b2e9d3/third_party/WebKit/Source/devtools/front_end/main/module.json
[add] https://crrev.com/685dabec5c99680300ced571e7aed09d43b2e9d3/third_party/WebKit/Source/devtools/front_end/persistence/Persistence.js
[add] https://crrev.com/685dabec5c99680300ced571e7aed09d43b2e9d3/third_party/WebKit/Source/devtools/front_end/persistence/module.json
[modify] https://crrev.com/685dabec5c99680300ced571e7aed09d43b2e9d3/third_party/WebKit/Source/devtools/front_end/sources/FilteredUISourceCodeListDelegate.js
[modify] https://crrev.com/685dabec5c99680300ced571e7aed09d43b2e9d3/third_party/WebKit/Source/devtools/front_end/sources/InplaceFormatterEditorAction.js
[modify] https://crrev.com/685dabec5c99680300ced571e7aed09d43b2e9d3/third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js
[modify] https://crrev.com/685dabec5c99680300ced571e7aed09d43b2e9d3/third_party/WebKit/Source/devtools/front_end/sources/OpenResourceDialog.js
[modify] https://crrev.com/685dabec5c99680300ced571e7aed09d43b2e9d3/third_party/WebKit/Source/devtools/front_end/sources/ScriptFormatterEditorAction.js
[modify] https://crrev.com/685dabec5c99680300ced571e7aed09d43b2e9d3/third_party/WebKit/Source/devtools/front_end/sources/SourcesSearchScope.js
[modify] https://crrev.com/685dabec5c99680300ced571e7aed09d43b2e9d3/third_party/WebKit/Source/devtools/front_end/sources/SourcesView.js
[modify] https://crrev.com/685dabec5c99680300ced571e7aed09d43b2e9d3/third_party/WebKit/Source/devtools/front_end/sources/TabbedEditorContainer.js
[modify] https://crrev.com/685dabec5c99680300ced571e7aed09d43b2e9d3/third_party/WebKit/Source/devtools/front_end/sources/UISourceCodeFrame.js
[modify] https://crrev.com/685dabec5c99680300ced571e7aed09d43b2e9d3/third_party/WebKit/Source/devtools/front_end/sources/WorkspaceMappingTip.js
[modify] https://crrev.com/685dabec5c99680300ced571e7aed09d43b2e9d3/third_party/WebKit/Source/devtools/front_end/sources/module.json
[modify] https://crrev.com/685dabec5c99680300ced571e7aed09d43b2e9d3/third_party/WebKit/Source/devtools/front_end/ui/TabbedPane.js
[modify] https://crrev.com/685dabec5c99680300ced571e7aed09d43b2e9d3/third_party/WebKit/Source/devtools/front_end/workspace/UISourceCode.js
[modify] https://crrev.com/685dabec5c99680300ced571e7aed09d43b2e9d3/third_party/WebKit/Source/devtools/front_end/workspace/Workspace.js
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 28 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/33cd9203a8749a54951037fa1017ec12c483a0aa

commit 33cd9203a8749a54951037fa1017ec12c483a0aa
Author: lushnikov <lushnikov@chromium.org>
Date: Wed Sep 28 21:19:45 2016

DevTools: remove WI.NetworkMapping.networkURL

Since crrev.com/2349343002, we can safely use UISourceCode.url()
everywhere instead of networkMapping.networkURL().

BUG=649837
R=dgozman, pfeldman

Review-Url: https://codereview.chromium.org/2376583002
Cr-Commit-Position: refs/heads/master@{#421640}

[modify] https://crrev.com/33cd9203a8749a54951037fa1017ec12c483a0aa/third_party/WebKit/LayoutTests/http/tests/inspector/compiler-script-mapping.html
[modify] https://crrev.com/33cd9203a8749a54951037fa1017ec12c483a0aa/third_party/WebKit/LayoutTests/http/tests/inspector/elements/styles/update-locations-on-filesystem-scss-load.html
[modify] https://crrev.com/33cd9203a8749a54951037fa1017ec12c483a0aa/third_party/WebKit/LayoutTests/http/tests/inspector/search/sources-search-scope-many-projects-expected.txt
[modify] https://crrev.com/33cd9203a8749a54951037fa1017ec12c483a0aa/third_party/WebKit/LayoutTests/http/tests/inspector/stylesheet-source-mapping.html
[modify] https://crrev.com/33cd9203a8749a54951037fa1017ec12c483a0aa/third_party/WebKit/LayoutTests/http/tests/inspector/workspace-test.js
[modify] https://crrev.com/33cd9203a8749a54951037fa1017ec12c483a0aa/third_party/WebKit/LayoutTests/inspector/extensions/extensions-panel.html
[modify] https://crrev.com/33cd9203a8749a54951037fa1017ec12c483a0aa/third_party/WebKit/LayoutTests/inspector/jump-to-previous-editing-location.html
[modify] https://crrev.com/33cd9203a8749a54951037fa1017ec12c483a0aa/third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/breakpoint-manager.html
[modify] https://crrev.com/33cd9203a8749a54951037fa1017ec12c483a0aa/third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/breakpoint-manager.js
[modify] https://crrev.com/33cd9203a8749a54951037fa1017ec12c483a0aa/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/ui-source-code-display-name.html
[modify] https://crrev.com/33cd9203a8749a54951037fa1017ec12c483a0aa/third_party/WebKit/LayoutTests/inspector/sources/debugger/file-system-project-mapping.html
[modify] https://crrev.com/33cd9203a8749a54951037fa1017ec12c483a0aa/third_party/WebKit/Source/devtools/front_end/Tests.js
[modify] https://crrev.com/33cd9203a8749a54951037fa1017ec12c483a0aa/third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js
[modify] https://crrev.com/33cd9203a8749a54951037fa1017ec12c483a0aa/third_party/WebKit/Source/devtools/front_end/bindings/BreakpointManager.js
[modify] https://crrev.com/33cd9203a8749a54951037fa1017ec12c483a0aa/third_party/WebKit/Source/devtools/front_end/bindings/CompilerScriptMapping.js
[modify] https://crrev.com/33cd9203a8749a54951037fa1017ec12c483a0aa/third_party/WebKit/Source/devtools/front_end/bindings/NetworkMapping.js
[modify] https://crrev.com/33cd9203a8749a54951037fa1017ec12c483a0aa/third_party/WebKit/Source/devtools/front_end/bindings/NetworkProject.js
[modify] https://crrev.com/33cd9203a8749a54951037fa1017ec12c483a0aa/third_party/WebKit/Source/devtools/front_end/bindings/ResourceScriptMapping.js
[modify] https://crrev.com/33cd9203a8749a54951037fa1017ec12c483a0aa/third_party/WebKit/Source/devtools/front_end/bindings/StylesSourceMapping.js
[modify] https://crrev.com/33cd9203a8749a54951037fa1017ec12c483a0aa/third_party/WebKit/Source/devtools/front_end/components/Linkifier.js
[modify] https://crrev.com/33cd9203a8749a54951037fa1017ec12c483a0aa/third_party/WebKit/Source/devtools/front_end/main/Main.js
[modify] https://crrev.com/33cd9203a8749a54951037fa1017ec12c483a0aa/third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js
[modify] https://crrev.com/33cd9203a8749a54951037fa1017ec12c483a0aa/third_party/WebKit/Source/devtools/front_end/sources/CallStackSidebarPane.js
[modify] https://crrev.com/33cd9203a8749a54951037fa1017ec12c483a0aa/third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js
[modify] https://crrev.com/33cd9203a8749a54951037fa1017ec12c483a0aa/third_party/WebKit/Source/devtools/front_end/sources/ScriptFormatterEditorAction.js
[modify] https://crrev.com/33cd9203a8749a54951037fa1017ec12c483a0aa/third_party/WebKit/Source/devtools/front_end/sources/SourcesNavigator.js
[modify] https://crrev.com/33cd9203a8749a54951037fa1017ec12c483a0aa/third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js
[modify] https://crrev.com/33cd9203a8749a54951037fa1017ec12c483a0aa/third_party/WebKit/Source/devtools/front_end/sources/SourcesSearchScope.js
[modify] https://crrev.com/33cd9203a8749a54951037fa1017ec12c483a0aa/third_party/WebKit/Source/devtools/front_end/sources/SourcesView.js

Comment 4 by paulir...@chromium.org, Sep 29 2016

Components: Platform>DevTools>Authoring

Comment 5 by paulir...@chromium.org, Sep 29 2016

Components: Platform>DevTools

Comment 6 by dgozman@chromium.org, Sep 30 2016

Components:
One more improvement: let's remove file system UISourceCode when the file has been removed.
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 4 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/95acf245ca23fb15b188601eba248d89fef046ca

commit 95acf245ca23fb15b188601eba248d89fef046ca
Author: pfeldman <pfeldman@chromium.org>
Date: Tue Oct 04 00:48:54 2016

DevTools: split Sources tree into Network and Filesystem trees.

BUG=649837

Review-Url: https://codereview.chromium.org/2384783003
Cr-Commit-Position: refs/heads/master@{#422640}

[modify] https://crrev.com/95acf245ca23fb15b188601eba248d89fef046ca/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/scripts-panel.html
[modify] https://crrev.com/95acf245ca23fb15b188601eba248d89fef046ca/third_party/WebKit/Source/devtools/front_end/main/Main.js
[modify] https://crrev.com/95acf245ca23fb15b188601eba248d89fef046ca/third_party/WebKit/Source/devtools/front_end/persistence/Persistence.js
[modify] https://crrev.com/95acf245ca23fb15b188601eba248d89fef046ca/third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js
[modify] https://crrev.com/95acf245ca23fb15b188601eba248d89fef046ca/third_party/WebKit/Source/devtools/front_end/sources/SourcesNavigator.js
[modify] https://crrev.com/95acf245ca23fb15b188601eba248d89fef046ca/third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js
[modify] https://crrev.com/95acf245ca23fb15b188601eba248d89fef046ca/third_party/WebKit/Source/devtools/front_end/sources/TabbedEditorContainer.js
[modify] https://crrev.com/95acf245ca23fb15b188601eba248d89fef046ca/third_party/WebKit/Source/devtools/front_end/sources/module.json
[modify] https://crrev.com/95acf245ca23fb15b188601eba248d89fef046ca/third_party/WebKit/Source/devtools/front_end/ui/TabbedPane.js

Comment 8 by horo@chromium.org, Oct 5 2016

Blockedon: 652982

Comment 9 by lushnikov@chromium.org, Nov 8 2016

beautiful-icons.png
154 KB View Download
Project Member

Comment 10 by bugdroid1@chromium.org, Nov 9 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/936f3c8b78a9297a79938cce8261de72cff78acd

commit 936f3c8b78a9297a79938cce8261de72cff78acd
Author: lushnikov <lushnikov@chromium.org>
Date: Wed Nov 09 22:09:46 2016

DevTools: introduce beautiful checkmarks in navigator and editor tabs

These checkmarks should designate that the file syncs with a network
resource.

BUG=649837
R=dgozman

Review-Url: https://codereview.chromium.org/2482073002
Cr-Commit-Position: refs/heads/master@{#431048}

[modify] https://crrev.com/936f3c8b78a9297a79938cce8261de72cff78acd/third_party/WebKit/Source/devtools/BUILD.gn
[modify] https://crrev.com/936f3c8b78a9297a79938cce8261de72cff78acd/third_party/WebKit/Source/devtools/front_end/Images/smallIcons.png
[modify] https://crrev.com/936f3c8b78a9297a79938cce8261de72cff78acd/third_party/WebKit/Source/devtools/front_end/Images/smallIcons_2x.png
[modify] https://crrev.com/936f3c8b78a9297a79938cce8261de72cff78acd/third_party/WebKit/Source/devtools/front_end/Images/src/optimize_png.hashes
[modify] https://crrev.com/936f3c8b78a9297a79938cce8261de72cff78acd/third_party/WebKit/Source/devtools/front_end/Images/src/smallIcons.svg
[modify] https://crrev.com/936f3c8b78a9297a79938cce8261de72cff78acd/third_party/WebKit/Source/devtools/front_end/Images/src/svg2png.hashes
[add] https://crrev.com/936f3c8b78a9297a79938cce8261de72cff78acd/third_party/WebKit/Source/devtools/front_end/persistence/PersistenceUtils.js
[modify] https://crrev.com/936f3c8b78a9297a79938cce8261de72cff78acd/third_party/WebKit/Source/devtools/front_end/persistence/module.json
[modify] https://crrev.com/936f3c8b78a9297a79938cce8261de72cff78acd/third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js
[modify] https://crrev.com/936f3c8b78a9297a79938cce8261de72cff78acd/third_party/WebKit/Source/devtools/front_end/sources/TabbedEditorContainer.js
[modify] https://crrev.com/936f3c8b78a9297a79938cce8261de72cff78acd/third_party/WebKit/Source/devtools/front_end/sources/navigatorTree.css
[modify] https://crrev.com/936f3c8b78a9297a79938cce8261de72cff78acd/third_party/WebKit/Source/devtools/front_end/ui/Icon.js

Comment 11 by lushnikov@chromium.org, Nov 9 2016 

The screenshot of checkmarks in SSP
ssp-green-checkmarks.png
89.5 KB View Download
Project Member

Comment 12 by bugdroid1@chromium.org, Nov 10 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/63f16e1e6c6dfe924fec9fed09b5380d5039af4d

commit 63f16e1e6c6dfe924fec9fed09b5380d5039af4d
Author: lushnikov <lushnikov@chromium.org>
Date: Thu Nov 10 02:54:36 2016

DevTools: [Persistence] update source editor tab icons on binding change

This patch updates source editor tab icons and title when bindings come
and go.

BUG=649837
R=dgozman

Review-Url: https://codereview.chromium.org/2486073005
Cr-Commit-Position: refs/heads/master@{#431153}

[modify] https://crrev.com/63f16e1e6c6dfe924fec9fed09b5380d5039af4d/third_party/WebKit/Source/devtools/front_end/sources/TabbedEditorContainer.js
Project Member

Comment 14 by bugdroid1@chromium.org, Nov 12 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5972fcc35fcb2b663c413888c3d7d0c498ff9899

commit 5972fcc35fcb2b663c413888c3d7d0c498ff9899
Author: lushnikov <lushnikov@chromium.org>
Date: Sat Nov 12 01:31:37 2016

DevTools: unhide Persistence2.0 experiment

BUG=649837
R=dgozman
NOTRY=true

Review-Url: https://codereview.chromium.org/2494263002
Cr-Commit-Position: refs/heads/master@{#431727}

[modify] https://crrev.com/5972fcc35fcb2b663c413888c3d7d0c498ff9899/third_party/WebKit/Source/devtools/front_end/main/Main.js
Project Member

Comment 15 by bugdroid1@chromium.org, Nov 15 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c7500edf7716fe6af09e4462edbe8dfc7c1e524b

commit c7500edf7716fe6af09e4462edbe8dfc7c1e524b
Author: lushnikov <lushnikov@chromium.org>
Date: Tue Nov 15 20:52:14 2016

DevTools: remove Bindings.NetworkMapping.addMapping/removeMapping methods

This patch removes fileSystemMapping from Bindings.NetworkMapping. As a
result, the fileSystemMapping starts to listen to FileSystemAdded/FileSystemRemoved
events by itself.

BUG=649837
R=dgozman

Review-Url: https://codereview.chromium.org/2506463002
Cr-Commit-Position: refs/heads/master@{#432252}

[modify] https://crrev.com/c7500edf7716fe6af09e4462edbe8dfc7c1e524b/third_party/WebKit/LayoutTests/http/tests/inspector/isolated-filesystem-test.js
[modify] https://crrev.com/c7500edf7716fe6af09e4462edbe8dfc7c1e524b/third_party/WebKit/LayoutTests/http/tests/inspector/workspace-test.js
[modify] https://crrev.com/c7500edf7716fe6af09e4462edbe8dfc7c1e524b/third_party/WebKit/LayoutTests/inspector/file-system-mapping-overrides.html
[modify] https://crrev.com/c7500edf7716fe6af09e4462edbe8dfc7c1e524b/third_party/WebKit/LayoutTests/inspector/file-system-mapping.html
[modify] https://crrev.com/c7500edf7716fe6af09e4462edbe8dfc7c1e524b/third_party/WebKit/LayoutTests/inspector/sources/debugger/file-system-project-mapping.html
[modify] https://crrev.com/c7500edf7716fe6af09e4462edbe8dfc7c1e524b/third_party/WebKit/Source/devtools/front_end/bindings/NetworkMapping.js
[modify] https://crrev.com/c7500edf7716fe6af09e4462edbe8dfc7c1e524b/third_party/WebKit/Source/devtools/front_end/main/Main.js
[modify] https://crrev.com/c7500edf7716fe6af09e4462edbe8dfc7c1e524b/third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js
[modify] https://crrev.com/c7500edf7716fe6af09e4462edbe8dfc7c1e524b/third_party/WebKit/Source/devtools/front_end/workspace/FileSystemMapping.js
Project Member

Comment 16 by bugdroid1@chromium.org, Nov 16 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bf39ff5451922af54ddd414d5bfee16f63276da5

commit bf39ff5451922af54ddd414d5bfee16f63276da5
Author: lushnikov <lushnikov@chromium.org>
Date: Wed Nov 16 02:37:20 2016

DevTools: move revealSourceLine handler from Networkmapping to Main

This is necessary since NetworkMapping is not needed anymore and is
scheduled for removal.

BUG=649837
R=dgozman

Review-Url: https://codereview.chromium.org/2500233002
Cr-Commit-Position: refs/heads/master@{#432362}

[modify] https://crrev.com/bf39ff5451922af54ddd414d5bfee16f63276da5/third_party/WebKit/Source/devtools/front_end/bindings/NetworkMapping.js
[modify] https://crrev.com/bf39ff5451922af54ddd414d5bfee16f63276da5/third_party/WebKit/Source/devtools/front_end/main/Main.js
Project Member

Comment 17 by bugdroid1@chromium.org, Nov 16 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/41358950d29405ed01f24cf39489c91bd10e6f93

commit 41358950d29405ed01f24cf39489c91bd10e6f93
Author: lushnikov <lushnikov@chromium.org>
Date: Wed Nov 16 18:21:45 2016

DevTools: kill Bindings.NetworkMapping

This patch kills Bindings.NetworkMapping class. Two of its methods
were moved under the NetworkProject (since there's no better place for now):
- uiSourceCodeForScriptURL
- uiSourceCodeForStyleURL

BUG=649837
R=dgozman

Review-Url: https://codereview.chromium.org/2501883002
Cr-Commit-Position: refs/heads/master@{#432559}

[modify] https://crrev.com/41358950d29405ed01f24cf39489c91bd10e6f93/third_party/WebKit/LayoutTests/http/tests/inspector/workspace-test.js
[modify] https://crrev.com/41358950d29405ed01f24cf39489c91bd10e6f93/third_party/WebKit/LayoutTests/inspector/sources/debugger/navigator-view.html
[modify] https://crrev.com/41358950d29405ed01f24cf39489c91bd10e6f93/third_party/WebKit/LayoutTests/inspector/sources/debugger/resource-script-mapping.html
[modify] https://crrev.com/41358950d29405ed01f24cf39489c91bd10e6f93/third_party/WebKit/Source/devtools/BUILD.gn
[modify] https://crrev.com/41358950d29405ed01f24cf39489c91bd10e6f93/third_party/WebKit/Source/devtools/front_end/bindings/CSSWorkspaceBinding.js
[modify] https://crrev.com/41358950d29405ed01f24cf39489c91bd10e6f93/third_party/WebKit/Source/devtools/front_end/bindings/CompilerScriptMapping.js
[modify] https://crrev.com/41358950d29405ed01f24cf39489c91bd10e6f93/third_party/WebKit/Source/devtools/front_end/bindings/DebuggerWorkspaceBinding.js
[delete] https://crrev.com/a3ea24ae1987d24b536859dad3d18537dd917242/third_party/WebKit/Source/devtools/front_end/bindings/NetworkMapping.js
[modify] https://crrev.com/41358950d29405ed01f24cf39489c91bd10e6f93/third_party/WebKit/Source/devtools/front_end/bindings/NetworkProject.js
[modify] https://crrev.com/41358950d29405ed01f24cf39489c91bd10e6f93/third_party/WebKit/Source/devtools/front_end/bindings/ResourceScriptMapping.js
[modify] https://crrev.com/41358950d29405ed01f24cf39489c91bd10e6f93/third_party/WebKit/Source/devtools/front_end/bindings/ResourceUtils.js
[modify] https://crrev.com/41358950d29405ed01f24cf39489c91bd10e6f93/third_party/WebKit/Source/devtools/front_end/bindings/SASSSourceMapping.js
[modify] https://crrev.com/41358950d29405ed01f24cf39489c91bd10e6f93/third_party/WebKit/Source/devtools/front_end/bindings/StylesSourceMapping.js
[modify] https://crrev.com/41358950d29405ed01f24cf39489c91bd10e6f93/third_party/WebKit/Source/devtools/front_end/bindings/module.json
[modify] https://crrev.com/41358950d29405ed01f24cf39489c91bd10e6f93/third_party/WebKit/Source/devtools/front_end/components/HandlerRegistry.js
[modify] https://crrev.com/41358950d29405ed01f24cf39489c91bd10e6f93/third_party/WebKit/Source/devtools/front_end/components/Linkifier.js
[modify] https://crrev.com/41358950d29405ed01f24cf39489c91bd10e6f93/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js
[modify] https://crrev.com/41358950d29405ed01f24cf39489c91bd10e6f93/third_party/WebKit/Source/devtools/front_end/extensions/ExtensionServer.js
[modify] https://crrev.com/41358950d29405ed01f24cf39489c91bd10e6f93/third_party/WebKit/Source/devtools/front_end/main/Main.js
[modify] https://crrev.com/41358950d29405ed01f24cf39489c91bd10e6f93/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js
[modify] https://crrev.com/41358950d29405ed01f24cf39489c91bd10e6f93/third_party/WebKit/Source/devtools/front_end/sources/SourceMapNamesResolver.js
[modify] https://crrev.com/41358950d29405ed01f24cf39489c91bd10e6f93/third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js
Project Member

Comment 18 by bugdroid1@chromium.org, Nov 19 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8237ed8ad1d23a7f95c5ebafb9692fe79754180e

commit 8237ed8ad1d23a7f95c5ebafb9692fe79754180e
Author: lushnikov <lushnikov@chromium.org>
Date: Sat Nov 19 01:30:45 2016

DevTools: move FileSystemWorkspaceBinding under persistence/

This patch moves FileSystemWorkspaceBinding under persistence/ module,
as planned before.

Ideally, the creation of FileSystemWorkspaceBinding should be moved
inside persistence as well; however, tests push back to this change,
thus the change hasn't been made.

BUG=649837
R=dgozman

Review-Url: https://codereview.chromium.org/2515583002
Cr-Commit-Position: refs/heads/master@{#433370}

[modify] https://crrev.com/8237ed8ad1d23a7f95c5ebafb9692fe79754180e/third_party/WebKit/LayoutTests/http/tests/inspector/elements/styles/edit-css-with-source-url.html
[modify] https://crrev.com/8237ed8ad1d23a7f95c5ebafb9692fe79754180e/third_party/WebKit/LayoutTests/http/tests/inspector/persistence/automapping-test.js
[modify] https://crrev.com/8237ed8ad1d23a7f95c5ebafb9692fe79754180e/third_party/WebKit/LayoutTests/http/tests/inspector/workspace-test.js
[modify] https://crrev.com/8237ed8ad1d23a7f95c5ebafb9692fe79754180e/third_party/WebKit/LayoutTests/inspector/sources/debugger/file-system-project-mapping.html
[modify] https://crrev.com/8237ed8ad1d23a7f95c5ebafb9692fe79754180e/third_party/WebKit/Source/devtools/BUILD.gn
[modify] https://crrev.com/8237ed8ad1d23a7f95c5ebafb9692fe79754180e/third_party/WebKit/Source/devtools/front_end/bindings/module.json
[modify] https://crrev.com/8237ed8ad1d23a7f95c5ebafb9692fe79754180e/third_party/WebKit/Source/devtools/front_end/main/Main.js
[modify] https://crrev.com/8237ed8ad1d23a7f95c5ebafb9692fe79754180e/third_party/WebKit/Source/devtools/front_end/persistence/Automapping.js
[modify] https://crrev.com/8237ed8ad1d23a7f95c5ebafb9692fe79754180e/third_party/WebKit/Source/devtools/front_end/persistence/DefaultMapping.js
[rename] https://crrev.com/8237ed8ad1d23a7f95c5ebafb9692fe79754180e/third_party/WebKit/Source/devtools/front_end/persistence/FileSystemWorkspaceBinding.js
[modify] https://crrev.com/8237ed8ad1d23a7f95c5ebafb9692fe79754180e/third_party/WebKit/Source/devtools/front_end/persistence/module.json
[modify] https://crrev.com/8237ed8ad1d23a7f95c5ebafb9692fe79754180e/third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js
[modify] https://crrev.com/8237ed8ad1d23a7f95c5ebafb9692fe79754180e/third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js
Project Member

Comment 19 by bugdroid1@chromium.org, Nov 22 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/26af32c71333cfe9e18e19e94deb11d52165fb93

commit 26af32c71333cfe9e18e19e94deb11d52165fb93
Author: lushnikov <lushnikov@chromium.org>
Date: Tue Nov 22 03:37:21 2016

DevTools: cleanup breakpointManager after removal of NetworkMapping

This patch gets rid of the notion of sourceFileId inside BreakpointManager.
Back in the days, sourceFileId defined a URL, translated through NetworkMapping.

Nowadays, just a URL could be used.

BUG=649837
R=dgozman

Review-Url: https://codereview.chromium.org/2515213005
Cr-Commit-Position: refs/heads/master@{#433776}

[modify] https://crrev.com/26af32c71333cfe9e18e19e94deb11d52165fb93/third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/breakpoint-manager.html
[modify] https://crrev.com/26af32c71333cfe9e18e19e94deb11d52165fb93/third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/breakpoint-manager.js
[modify] https://crrev.com/26af32c71333cfe9e18e19e94deb11d52165fb93/third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/dynamic-scripts-breakpoints.html
[modify] https://crrev.com/26af32c71333cfe9e18e19e94deb11d52165fb93/third_party/WebKit/LayoutTests/inspector/sources/debugger/live-edit-breakpoints.html
[modify] https://crrev.com/26af32c71333cfe9e18e19e94deb11d52165fb93/third_party/WebKit/Source/devtools/front_end/bindings/BreakpointManager.js
[modify] https://crrev.com/26af32c71333cfe9e18e19e94deb11d52165fb93/third_party/WebKit/Source/devtools/front_end/common/Settings.js
Project Member

Comment 20 by bugdroid1@chromium.org, Nov 22 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6d8345816cfb1b1f268ca4e2cf24a4e7f2f2c9af

commit 6d8345816cfb1b1f268ca4e2cf24a4e7f2f2c9af
Author: lushnikov <lushnikov@chromium.org>
Date: Tue Nov 22 23:17:35 2016

DevTools: [Persistence] properly copy breakpoints to filesystem during reload

Persitence takes care of synchronizing breakpoints between filesystem and
network files:
- when the PersistenceBinding comes, breakpoints are moved from fileSystem
  to Network uiSourceCode
- when the PersistenceBinding gets removed, breakpoints are copied
  from Network uiSourcecode to filesystem

Problem:
  When the network uiSourceCode gets removed (e.g. page reload happened),
  the breakpoint manager cleans up all breakpoints associated with this
  UISourceCode.
  As a result, persistence fails to copy breakpoints over to the filesystem.

This patch starts using breakpointsForURL to set breakpoints on FileSystem
UISourceCode.

BUG=649837
R=dgozman

Review-Url: https://codereview.chromium.org/2522753002
Cr-Commit-Position: refs/heads/master@{#434017}

[modify] https://crrev.com/6d8345816cfb1b1f268ca4e2cf24a4e7f2f2c9af/third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js
[add] https://crrev.com/6d8345816cfb1b1f268ca4e2cf24a4e7f2f2c9af/third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-move-breakpoints-on-reload-expected.txt
[add] https://crrev.com/6d8345816cfb1b1f268ca4e2cf24a4e7f2f2c9af/third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-move-breakpoints-on-reload.html
[modify] https://crrev.com/6d8345816cfb1b1f268ca4e2cf24a4e7f2f2c9af/third_party/WebKit/Source/devtools/front_end/bindings/BreakpointManager.js
[modify] https://crrev.com/6d8345816cfb1b1f268ca4e2cf24a4e7f2f2c9af/third_party/WebKit/Source/devtools/front_end/persistence/Persistence.js
Project Member

Comment 21 by bugdroid1@chromium.org, Nov 29 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f0fe6d5aaedd8efaedfc651c92e4e9eda31c2046

commit f0fe6d5aaedd8efaedfc651c92e4e9eda31c2046
Author: lushnikov <lushnikov@chromium.org>
Date: Tue Nov 29 01:45:06 2016

DevTools: move message management from UISourceCodeFrame to UISourceCode

Today, UISourceCodeFrame removes all messages from UISourceCode whenever
the working copy of UISourceCode gets changed. This is a "wag the dog"
situation.

This patch makes UISourceCode to decide on the lifetime on its messages.
This will help to implement the message merging logic.

Drive-by: converts UISourceCodeFrame._rawMessageBucket into Map.

BUG=649837

Review-Url: https://codereview.chromium.org/2514323008
Cr-Commit-Position: refs/heads/master@{#434819}

[modify] https://crrev.com/f0fe6d5aaedd8efaedfc651c92e4e9eda31c2046/third_party/WebKit/LayoutTests/inspector-enabled/sources/debugger/script-formatter-console-expected.txt
[modify] https://crrev.com/f0fe6d5aaedd8efaedfc651c92e4e9eda31c2046/third_party/WebKit/LayoutTests/inspector-enabled/sources/debugger/script-formatter-console.html
[modify] https://crrev.com/f0fe6d5aaedd8efaedfc651c92e4e9eda31c2046/third_party/WebKit/LayoutTests/inspector/sources/compile-javascript.html
[modify] https://crrev.com/f0fe6d5aaedd8efaedfc651c92e4e9eda31c2046/third_party/WebKit/Source/devtools/front_end/sources/UISourceCodeFrame.js
[modify] https://crrev.com/f0fe6d5aaedd8efaedfc651c92e4e9eda31c2046/third_party/WebKit/Source/devtools/front_end/workspace/UISourceCode.js
Project Member

Comment 22 by bugdroid1@chromium.org, Nov 29 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0496be2799d97a95ace380e2e45e454f549d6b2d

commit 0496be2799d97a95ace380e2e45e454f549d6b2d
Author: lushnikov <lushnikov@chromium.org>
Date: Tue Nov 29 02:53:19 2016

DevTools: teach UISourceCodeFrame to merge messages

This patch teaches UISourceCodeFrame to display messages from both
UISourceCodes of PersistenceBinding. This is reasonable, since
there might be different "builders" which add messages to either
of the source codes.

This patch also slightly modifies the handling of decorations:
in case of persistence binding, we prefer network uiSourceCode decorations
over the fileSystem ones: it's hard to merge decorations.

This is also an imperative step towards displaying fileSystem file
by default in the editor.

BUG=649837
R=dgozman

Review-Url: https://codereview.chromium.org/2530483002
Cr-Commit-Position: refs/heads/master@{#434847}

[modify] https://crrev.com/0496be2799d97a95ace380e2e45e454f549d6b2d/third_party/WebKit/LayoutTests/http/tests/inspector/debugger-test.js
[add] https://crrev.com/0496be2799d97a95ace380e2e45e454f549d6b2d/third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-sourceframe-messages-expected.txt
[add] https://crrev.com/0496be2799d97a95ace380e2e45e454f549d6b2d/third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-sourceframe-messages.html
[modify] https://crrev.com/0496be2799d97a95ace380e2e45e454f549d6b2d/third_party/WebKit/LayoutTests/inspector/sources/compile-javascript-expected.txt
[modify] https://crrev.com/0496be2799d97a95ace380e2e45e454f549d6b2d/third_party/WebKit/LayoutTests/inspector/sources/compile-javascript.html
[modify] https://crrev.com/0496be2799d97a95ace380e2e45e454f549d6b2d/third_party/WebKit/Source/devtools/front_end/sources/UISourceCodeFrame.js

Comment 23 by dgozman@chromium.org, Dec 1 2016

Blockedon: 670180
Project Member

Comment 24 by bugdroid1@chromium.org, Dec 2 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/70b1c266df857360b1cbf99d1d0735006c70d775

commit 70b1c266df857360b1cbf99d1d0735006c70d775
Author: lushnikov <lushnikov@chromium.org>
Date: Fri Dec 02 05:02:30 2016

DevTools: [Persistence] sync working copies of UISourceCodes

Today, persistence reacts only on UISourceCode's "commit" events to
sync content between UISourceCodes.

This patch teaches Persistence to also sync working copies between
UISourceCodes.

This is a prerequisite for showing filesystem file instead of
network uisourcecode.

BUG=649837
R=dgozman

Review-Url: https://codereview.chromium.org/2537233003
Cr-Commit-Position: refs/heads/master@{#435862}

[modify] https://crrev.com/70b1c266df857360b1cbf99d1d0735006c70d775/third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-sync-content-expected.txt
[modify] https://crrev.com/70b1c266df857360b1cbf99d1d0735006c70d775/third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-sync-content-nodejs-expected.txt
[modify] https://crrev.com/70b1c266df857360b1cbf99d1d0735006c70d775/third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-sync-content-nodejs.html
[modify] https://crrev.com/70b1c266df857360b1cbf99d1d0735006c70d775/third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-sync-content.html
[modify] https://crrev.com/70b1c266df857360b1cbf99d1d0735006c70d775/third_party/WebKit/Source/devtools/front_end/persistence/Persistence.js
[modify] https://crrev.com/70b1c266df857360b1cbf99d1d0735006c70d775/third_party/WebKit/Source/devtools/front_end/sources/SourcesView.js
Project Member

Comment 25 by bugdroid1@chromium.org, Dec 6 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7ac7d36de53c8632613f193adcafa9d1678e4e39

commit 7ac7d36de53c8632613f193adcafa9d1678e4e39
Author: lushnikov <lushnikov@chromium.org>
Date: Tue Dec 06 02:30:15 2016

DevTools: [Persistence] guard against multiple UISourceCodes with similar URL

Currently, we assume that there is a single UISourceCode per URL in the
Workspace.

However, this is not the case. In order to avoid unpredicted behavior,
we should guard against this sitation.

BUG=649837
R=dgozman

Review-Url: https://codereview.chromium.org/2546583003
Cr-Commit-Position: refs/heads/master@{#436486}

[modify] https://crrev.com/7ac7d36de53c8632613f193adcafa9d1678e4e39/third_party/WebKit/Source/devtools/front_end/persistence/Automapping.js
[modify] https://crrev.com/7ac7d36de53c8632613f193adcafa9d1678e4e39/third_party/WebKit/Source/devtools/front_end/persistence/DefaultMapping.js
Project Member

Comment 26 by bugdroid1@chromium.org, Dec 7 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6e5aac4d281da102e231847066148587bd7f4e15

commit 6e5aac4d281da102e231847066148587bd7f4e15
Author: lushnikov <lushnikov@chromium.org>
Date: Wed Dec 07 02:14:55 2016

DevTools: [Persistence] show filesystem file instead of network

Currently, as network UISourceCode gets mapped to the
filesystem UISourceCode, we still show network-based UISourceCode
in the sources panel.

However, network UISourceCodes are not really reliable: they come
and go, e.g. during reload. This results in the content blinking
unpleasantly and the undo stack being vanished. This also complicates the TabbedEditorContainer logic, which juggles tabs in a way to
match user expectations.

This patch switches to showing file-system UISourceCode.

The biggest change happens in JavaScriptSourceFrame: it now
knows about "debuggerSourceCode", which it uses to operate
breakpoints.

BUG=649837

Review-Url: https://codereview.chromium.org/2551233002
Cr-Commit-Position: refs/heads/master@{#436837}

[modify] https://crrev.com/6e5aac4d281da102e231847066148587bd7f4e15/third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-go-to-file-dialog-expected.txt
[modify] https://crrev.com/6e5aac4d281da102e231847066148587bd7f4e15/third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-merge-editor-tabs-expected.txt
[modify] https://crrev.com/6e5aac4d281da102e231847066148587bd7f4e15/third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-merge-editor-tabs.html
[modify] https://crrev.com/6e5aac4d281da102e231847066148587bd7f4e15/third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-move-breakpoints-on-reload-expected.txt
[modify] https://crrev.com/6e5aac4d281da102e231847066148587bd7f4e15/third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-move-breakpoints-on-reload.html
[modify] https://crrev.com/6e5aac4d281da102e231847066148587bd7f4e15/third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-search-across-all-files-expected.txt
[add] https://crrev.com/6e5aac4d281da102e231847066148587bd7f4e15/third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-switch-editor-tab-expected.txt
[add] https://crrev.com/6e5aac4d281da102e231847066148587bd7f4e15/third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-switch-editor-tab.html
[rename] https://crrev.com/6e5aac4d281da102e231847066148587bd7f4e15/third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-tabbed-editor-opens-filesystem-uisourcecode-expected.txt
[rename] https://crrev.com/6e5aac4d281da102e231847066148587bd7f4e15/third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-tabbed-editor-opens-filesystem-uisourcecode.html
[modify] https://crrev.com/6e5aac4d281da102e231847066148587bd7f4e15/third_party/WebKit/Source/devtools/front_end/bindings/CompilerScriptMapping.js
[modify] https://crrev.com/6e5aac4d281da102e231847066148587bd7f4e15/third_party/WebKit/Source/devtools/front_end/bindings/ResourceScriptMapping.js
[modify] https://crrev.com/6e5aac4d281da102e231847066148587bd7f4e15/third_party/WebKit/Source/devtools/front_end/sources/FilteredUISourceCodeListDelegate.js
[modify] https://crrev.com/6e5aac4d281da102e231847066148587bd7f4e15/third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js
[modify] https://crrev.com/6e5aac4d281da102e231847066148587bd7f4e15/third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js
[modify] https://crrev.com/6e5aac4d281da102e231847066148587bd7f4e15/third_party/WebKit/Source/devtools/front_end/sources/SourcesSearchScope.js
[modify] https://crrev.com/6e5aac4d281da102e231847066148587bd7f4e15/third_party/WebKit/Source/devtools/front_end/sources/SourcesView.js
[modify] https://crrev.com/6e5aac4d281da102e231847066148587bd7f4e15/third_party/WebKit/Source/devtools/front_end/sources/TabbedEditorContainer.js
[modify] https://crrev.com/6e5aac4d281da102e231847066148587bd7f4e15/third_party/WebKit/Source/devtools/front_end/sources/UISourceCodeFrame.js
Project Member

Comment 27 by bugdroid1@chromium.org, Dec 10 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7b5206fba773fc4f5ce4ba32691fd825a9eed17a

commit 7b5206fba773fc4f5ce4ba32691fd825a9eed17a
Author: lushnikov <lushnikov@chromium.org>
Date: Sat Dec 10 06:39:03 2016

DevTools: [Persistence] validate persistence binding.

This patch ensures that persistence binding is not established if working copy
of network UISourceCode does not match with the working copy of filesystem
UISourceCode.

This validation is done proactively: whenever automapping reports a binding,
we fetch contents of both network and filesystem UISourceCodes and compare them.

For this to work fast, we do *not* validate the following types of bindings:
- bindings of source map sources. These could be slow to fetch, and they don't break us in any
  way.
- bindings of binary files (e.g. images). These are never going to be edited, and
  thus can't deal any harm.

To sum up, we request contents only of those text resources which were already
succesfully loaded by the website itself, which means they are of manageble size.
However, to be on the safe side, this change is guarded by on-by-default experiment.

BUG=649837
R=dgozman

Review-Url: https://codereview.chromium.org/2542073002
Cr-Commit-Position: refs/heads/master@{#437761}

[modify] https://crrev.com/7b5206fba773fc4f5ce4ba32691fd825a9eed17a/third_party/WebKit/LayoutTests/http/tests/inspector/file-system-project-mapping-expected.txt
[modify] https://crrev.com/7b5206fba773fc4f5ce4ba32691fd825a9eed17a/third_party/WebKit/LayoutTests/http/tests/inspector/file-system-project-mapping.html
[modify] https://crrev.com/7b5206fba773fc4f5ce4ba32691fd825a9eed17a/third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-do-not-bind-dirty-sourcecode-expected.txt
[modify] https://crrev.com/7b5206fba773fc4f5ce4ba32691fd825a9eed17a/third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-do-not-bind-dirty-sourcecode.html
[modify] https://crrev.com/7b5206fba773fc4f5ce4ba32691fd825a9eed17a/third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-merge-editor-tabs-expected.txt
[modify] https://crrev.com/7b5206fba773fc4f5ce4ba32691fd825a9eed17a/third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-merge-editor-tabs.html
[modify] https://crrev.com/7b5206fba773fc4f5ce4ba32691fd825a9eed17a/third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-sync-content-nodejs-expected.txt
[modify] https://crrev.com/7b5206fba773fc4f5ce4ba32691fd825a9eed17a/third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-sync-content-nodejs.html
[modify] https://crrev.com/7b5206fba773fc4f5ce4ba32691fd825a9eed17a/third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-test.js
[modify] https://crrev.com/7b5206fba773fc4f5ce4ba32691fd825a9eed17a/third_party/WebKit/LayoutTests/inspector/sources/debugger/file-system-project-live-edit.html
[modify] https://crrev.com/7b5206fba773fc4f5ce4ba32691fd825a9eed17a/third_party/WebKit/Source/devtools/front_end/main/Main.js
[modify] https://crrev.com/7b5206fba773fc4f5ce4ba32691fd825a9eed17a/third_party/WebKit/Source/devtools/front_end/persistence/Persistence.js
Project Member

Comment 28 by bugdroid1@chromium.org, Dec 21 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/095e1c0df2e2cac1d869127f83fce8c0afdadd37

commit 095e1c0df2e2cac1d869127f83fce8c0afdadd37
Author: lushnikov <lushnikov@chromium.org>
Date: Wed Dec 21 01:49:49 2016

DevTools: [Persistence] implement Persistence.subscribeForBindingEvents

This patch implements per-uiSourceCode subscriptions for binding events.
They allow clients to subscribe to binding status changes of a particular
UISourceCode. This makes event delivery much more efficient.

BUG=649837
R=dgozman

Review-Url: https://codereview.chromium.org/2585393003
Cr-Commit-Position: refs/heads/master@{#439972}

[modify] https://crrev.com/095e1c0df2e2cac1d869127f83fce8c0afdadd37/third_party/WebKit/Source/devtools/front_end/persistence/Persistence.js
[modify] https://crrev.com/095e1c0df2e2cac1d869127f83fce8c0afdadd37/third_party/WebKit/Source/devtools/front_end/sources/SourcesView.js
[modify] https://crrev.com/095e1c0df2e2cac1d869127f83fce8c0afdadd37/third_party/WebKit/Source/devtools/front_end/sources/UISourceCodeFrame.js

Comment 29 by lushnikov@chromium.org, Mar 1 2017

Description: Show this description
Project Member

Comment 30 by bugdroid1@chromium.org, May 6 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/142388b2f4c78a6e59851a1ffadd1169c1c76726

commit 142388b2f4c78a6e59851a1ffadd1169c1c76726
Author: lushnikov <lushnikov@chromium.org>
Date: Sat May 06 18:48:46 2017

DevTools: move FileSystemMapping under persistence/ module

This patch:
- moves Workspace.FileSystemMapping under persistence/ module
- splits out "WorkspaceSettingsTab" from SettingsScreen and moves it
  under persistence/ module. This is needed since WorkspaceSettingsTab
  refers to FileSystemMapping.

The WorkspaceSettingsTab no longer extends Settings.SettingsTab.
For this reason, it creates the content element and header elements
by itself now. It also reuses part of the css from the SettingsScreen
in its workspaceSettingsTab.css.

BUG=649837
R=dgozman

Review-Url: https://codereview.chromium.org/2868543002
Cr-Commit-Position: refs/heads/master@{#469846}

[modify] https://crrev.com/142388b2f4c78a6e59851a1ffadd1169c1c76726/third_party/WebKit/LayoutTests/http/tests/inspector/isolated-filesystem-test.js
[modify] https://crrev.com/142388b2f4c78a6e59851a1ffadd1169c1c76726/third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-test.js
[modify] https://crrev.com/142388b2f4c78a6e59851a1ffadd1169c1c76726/third_party/WebKit/LayoutTests/inspector/file-system-mapping.html
[modify] https://crrev.com/142388b2f4c78a6e59851a1ffadd1169c1c76726/third_party/WebKit/Source/devtools/BUILD.gn
[modify] https://crrev.com/142388b2f4c78a6e59851a1ffadd1169c1c76726/third_party/WebKit/Source/devtools/front_end/main/Main.js
[modify] https://crrev.com/142388b2f4c78a6e59851a1ffadd1169c1c76726/third_party/WebKit/Source/devtools/front_end/persistence/Automapping.js
[modify] https://crrev.com/142388b2f4c78a6e59851a1ffadd1169c1c76726/third_party/WebKit/Source/devtools/front_end/persistence/DefaultMapping.js
[rename] https://crrev.com/142388b2f4c78a6e59851a1ffadd1169c1c76726/third_party/WebKit/Source/devtools/front_end/persistence/EditFileSystemView.js
[rename] https://crrev.com/142388b2f4c78a6e59851a1ffadd1169c1c76726/third_party/WebKit/Source/devtools/front_end/persistence/FileSystemMapping.js
[modify] https://crrev.com/142388b2f4c78a6e59851a1ffadd1169c1c76726/third_party/WebKit/Source/devtools/front_end/persistence/Persistence.js
[add] https://crrev.com/142388b2f4c78a6e59851a1ffadd1169c1c76726/third_party/WebKit/Source/devtools/front_end/persistence/WorkspaceSettingsTab.js
[rename] https://crrev.com/142388b2f4c78a6e59851a1ffadd1169c1c76726/third_party/WebKit/Source/devtools/front_end/persistence/editFileSystemView.css
[modify] https://crrev.com/142388b2f4c78a6e59851a1ffadd1169c1c76726/third_party/WebKit/Source/devtools/front_end/persistence/module.json
[add] https://crrev.com/142388b2f4c78a6e59851a1ffadd1169c1c76726/third_party/WebKit/Source/devtools/front_end/persistence/workspaceSettingsTab.css
[modify] https://crrev.com/142388b2f4c78a6e59851a1ffadd1169c1c76726/third_party/WebKit/Source/devtools/front_end/settings/SettingsScreen.js
[modify] https://crrev.com/142388b2f4c78a6e59851a1ffadd1169c1c76726/third_party/WebKit/Source/devtools/front_end/settings/module.json
[modify] https://crrev.com/142388b2f4c78a6e59851a1ffadd1169c1c76726/third_party/WebKit/Source/devtools/front_end/settings/settingsScreen.css
[modify] https://crrev.com/142388b2f4c78a6e59851a1ffadd1169c1c76726/third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js
[modify] https://crrev.com/142388b2f4c78a6e59851a1ffadd1169c1c76726/third_party/WebKit/Source/devtools/front_end/workspace/module.json
Project Member

Comment 31 by bugdroid1@chromium.org, May 11 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1d43d5f0b13defdc9f637a765a235740c8ef1259

commit 1d43d5f0b13defdc9f637a765a235740c8ef1259
Author: lushnikov <lushnikov@chromium.org>
Date: Thu May 11 06:05:22 2017

DevTools: move IsolatedFileSystem/IsolatedFileSystemManager into persistence/

This patch moves IsoltaedFileSystem/IsolatedFileSystemManager into persistence/
module since they actually belong to it.

BUG=649837

Review-Url: https://codereview.chromium.org/2867783003
Cr-Commit-Position: refs/heads/master@{#470837}

[modify] https://crrev.com/1d43d5f0b13defdc9f637a765a235740c8ef1259/third_party/WebKit/LayoutTests/http/tests/inspector/isolated-filesystem-test.js
[modify] https://crrev.com/1d43d5f0b13defdc9f637a765a235740c8ef1259/third_party/WebKit/LayoutTests/http/tests/inspector/persistence/automapping-test.js
[modify] https://crrev.com/1d43d5f0b13defdc9f637a765a235740c8ef1259/third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-search-across-all-files.html
[modify] https://crrev.com/1d43d5f0b13defdc9f637a765a235740c8ef1259/third_party/WebKit/LayoutTests/http/tests/inspector/search/sources-search-scope-in-files.html
[modify] https://crrev.com/1d43d5f0b13defdc9f637a765a235740c8ef1259/third_party/WebKit/LayoutTests/http/tests/inspector/search/sources-search-scope-many-projects.html
[modify] https://crrev.com/1d43d5f0b13defdc9f637a765a235740c8ef1259/third_party/WebKit/LayoutTests/inspector/file-system-mapping.html
[modify] https://crrev.com/1d43d5f0b13defdc9f637a765a235740c8ef1259/third_party/WebKit/LayoutTests/inspector/file-system-project.html
[modify] https://crrev.com/1d43d5f0b13defdc9f637a765a235740c8ef1259/third_party/WebKit/Source/devtools/BUILD.gn
[modify] https://crrev.com/1d43d5f0b13defdc9f637a765a235740c8ef1259/third_party/WebKit/Source/devtools/front_end/main/Main.js
[modify] https://crrev.com/1d43d5f0b13defdc9f637a765a235740c8ef1259/third_party/WebKit/Source/devtools/front_end/persistence/EditFileSystemView.js
[modify] https://crrev.com/1d43d5f0b13defdc9f637a765a235740c8ef1259/third_party/WebKit/Source/devtools/front_end/persistence/FileSystemMapping.js
[modify] https://crrev.com/1d43d5f0b13defdc9f637a765a235740c8ef1259/third_party/WebKit/Source/devtools/front_end/persistence/FileSystemWorkspaceBinding.js
[rename] https://crrev.com/1d43d5f0b13defdc9f637a765a235740c8ef1259/third_party/WebKit/Source/devtools/front_end/persistence/IsolatedFileSystem.js
[rename] https://crrev.com/1d43d5f0b13defdc9f637a765a235740c8ef1259/third_party/WebKit/Source/devtools/front_end/persistence/IsolatedFileSystemManager.js
[modify] https://crrev.com/1d43d5f0b13defdc9f637a765a235740c8ef1259/third_party/WebKit/Source/devtools/front_end/persistence/WorkspaceSettingsTab.js
[modify] https://crrev.com/1d43d5f0b13defdc9f637a765a235740c8ef1259/third_party/WebKit/Source/devtools/front_end/persistence/module.json
[modify] https://crrev.com/1d43d5f0b13defdc9f637a765a235740c8ef1259/third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js
[modify] https://crrev.com/1d43d5f0b13defdc9f637a765a235740c8ef1259/third_party/WebKit/Source/devtools/front_end/sources/SourcesNavigator.js
[modify] https://crrev.com/1d43d5f0b13defdc9f637a765a235740c8ef1259/third_party/WebKit/Source/devtools/front_end/workspace/module.json
Project Member

Comment 32 by bugdroid1@chromium.org, Oct 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4b54f004db85a1aa65dccf36974c4afdb28ed74e

commit 4b54f004db85a1aa65dccf36974c4afdb28ed74e
Author: Andrey Lushnikov <lushnikov@chromium.org>
Date: Sat Oct 07 02:14:52 2017

DevTools: enable Persistence2.0 by default

This patch enables Persistence2.0 experiment by default.

BUG=649837
R=pfeldman, dgozman

Change-Id: I16b32d62d9395281a0753e6295852b5c3e0faf45
Reviewed-on: https://chromium-review.googlesource.com/703978
Commit-Queue: Pavel Feldman <pfeldman@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#507267}
[modify] https://crrev.com/4b54f004db85a1aa65dccf36974c4afdb28ed74e/third_party/WebKit/Source/devtools/front_end/main/Main.js
Project Member

Comment 33 by bugdroid1@chromium.org, Jan 19 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1d4add3aa8f51a16548d6dc1a07de21c3163ef11

commit 1d4add3aa8f51a16548d6dc1a07de21c3163ef11
Author: Andrey Lushnikov <lushnikov@chromium.org>
Date: Fri Jan 19 20:18:24 2018

DevTools: remove DefaultMapping aka Persistence1 / Workspaces

This patch removes all the code associated with DefaultMapping, used
to manually map NetworkResources to their filesystem counterparts
in the first version of Workspaces.

This patch removes the following classes:
- Persistence.DefaultMapping
- Persistence.FileSystemMapping
- Sources.SelectUISourceCodeForProjectTypesDialog - used to install
  manual mapping
- Sources.SourcesNavigatorView - used to remove mapped files from
  Network Navigator
- Sources.WorkspaceMappingTip - used to onboard users to the initial
  mapping. Removed this since it was broken for a while and no one
  noticed.

Additionally to the removed classes, this patch:
- Removes Persistence.fileSystemMapping global variable
- Kills "persistence2" experiment and all the code paths associated with
  the old persistence

R=dgozman,pfeldman
BUG=649837

Change-Id: I250f053347622004640d4321cc332ffc969894e9
Reviewed-on: https://chromium-review.googlesource.com/872612
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530599}
[modify] https://crrev.com/1d4add3aa8f51a16548d6dc1a07de21c3163ef11/third_party/WebKit/LayoutTests/http/tests/devtools/bindings/dynamic-navigator-frame-attach-detach.js
[modify] https://crrev.com/1d4add3aa8f51a16548d6dc1a07de21c3163ef11/third_party/WebKit/LayoutTests/http/tests/devtools/bindings/navigator-frame-attach-detach.js
[modify] https://crrev.com/1d4add3aa8f51a16548d6dc1a07de21c3163ef11/third_party/WebKit/LayoutTests/http/tests/devtools/bindings/navigator-frame-navigate.js
[modify] https://crrev.com/1d4add3aa8f51a16548d6dc1a07de21c3163ef11/third_party/WebKit/LayoutTests/http/tests/devtools/bindings/navigator-main-frame-navigated.js
[modify] https://crrev.com/1d4add3aa8f51a16548d6dc1a07de21c3163ef11/third_party/WebKit/LayoutTests/http/tests/devtools/bindings/navigator-multiple-frames.js
[modify] https://crrev.com/1d4add3aa8f51a16548d6dc1a07de21c3163ef11/third_party/WebKit/LayoutTests/http/tests/devtools/bindings/shadowdom-navigator.js
[modify] https://crrev.com/1d4add3aa8f51a16548d6dc1a07de21c3163ef11/third_party/WebKit/LayoutTests/http/tests/devtools/bindings/sourcemap-navigator-multiple-frames.js
[modify] https://crrev.com/1d4add3aa8f51a16548d6dc1a07de21c3163ef11/third_party/WebKit/LayoutTests/http/tests/devtools/bindings/suspendtarget-navigator.js
[modify] https://crrev.com/1d4add3aa8f51a16548d6dc1a07de21c3163ef11/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles/styles-do-not-add-inline-stylesheets-in-navigator.js
[delete] https://crrev.com/378959124b9103b0bd426c855ef5a2a74ed0c19b/third_party/WebKit/LayoutTests/http/tests/devtools/file-system-mapping-expected.txt
[delete] https://crrev.com/378959124b9103b0bd426c855ef5a2a74ed0c19b/third_party/WebKit/LayoutTests/http/tests/devtools/file-system-mapping.js
[modify] https://crrev.com/1d4add3aa8f51a16548d6dc1a07de21c3163ef11/third_party/WebKit/LayoutTests/http/tests/devtools/file-system-project.js
[modify] https://crrev.com/1d4add3aa8f51a16548d6dc1a07de21c3163ef11/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/navigator-create-file-copy.js
[modify] https://crrev.com/1d4add3aa8f51a16548d6dc1a07de21c3163ef11/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/persistence-do-not-bind-dirty-sourcecode.js
[delete] https://crrev.com/378959124b9103b0bd426c855ef5a2a74ed0c19b/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/persistence-navigator-expected.txt
[modify] https://crrev.com/1d4add3aa8f51a16548d6dc1a07de21c3163ef11/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/persistence-navigator-unique-names.js
[delete] https://crrev.com/378959124b9103b0bd426c855ef5a2a74ed0c19b/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/persistence-navigator.js
[delete] https://crrev.com/378959124b9103b0bd426c855ef5a2a74ed0c19b/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/persistence-rename-mapped-file-expected.txt
[delete] https://crrev.com/378959124b9103b0bd426c855ef5a2a74ed0c19b/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/persistence-rename-mapped-file.js
[modify] https://crrev.com/1d4add3aa8f51a16548d6dc1a07de21c3163ef11/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/persistence-tabbed-editor-tabs-order.js
[modify] https://crrev.com/1d4add3aa8f51a16548d6dc1a07de21c3163ef11/third_party/WebKit/LayoutTests/http/tests/devtools/sources/css-sourcemaps-toggle-enabled.js
[modify] https://crrev.com/1d4add3aa8f51a16548d6dc1a07de21c3163ef11/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/scripts-panel.js
[modify] https://crrev.com/1d4add3aa8f51a16548d6dc1a07de21c3163ef11/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/scripts-sorting.js
[modify] https://crrev.com/1d4add3aa8f51a16548d6dc1a07de21c3163ef11/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/navigator-view.js
[modify] https://crrev.com/1d4add3aa8f51a16548d6dc1a07de21c3163ef11/third_party/WebKit/LayoutTests/http/tests/devtools/sources/js-sourcemaps-toggle-enabled.js
[modify] https://crrev.com/1d4add3aa8f51a16548d6dc1a07de21c3163ef11/third_party/WebKit/LayoutTests/http/tests/devtools/sources/navigator-view-content-scripts.js
[modify] https://crrev.com/1d4add3aa8f51a16548d6dc1a07de21c3163ef11/third_party/WebKit/Source/devtools/BUILD.gn
[modify] https://crrev.com/1d4add3aa8f51a16548d6dc1a07de21c3163ef11/third_party/WebKit/Source/devtools/front_end/application_test_runner/ResourceTreeTestRunner.js
[modify] https://crrev.com/1d4add3aa8f51a16548d6dc1a07de21c3163ef11/third_party/WebKit/Source/devtools/front_end/bindings_test_runner/IsolatedFilesystemTestRunner.js
[modify] https://crrev.com/1d4add3aa8f51a16548d6dc1a07de21c3163ef11/third_party/WebKit/Source/devtools/front_end/bindings_test_runner/PersistenceTestRunner.js
[modify] https://crrev.com/1d4add3aa8f51a16548d6dc1a07de21c3163ef11/third_party/WebKit/Source/devtools/front_end/main/Main.js
[delete] https://crrev.com/378959124b9103b0bd426c855ef5a2a74ed0c19b/third_party/WebKit/Source/devtools/front_end/persistence/DefaultMapping.js
[modify] https://crrev.com/1d4add3aa8f51a16548d6dc1a07de21c3163ef11/third_party/WebKit/Source/devtools/front_end/persistence/EditFileSystemView.js
[delete] https://crrev.com/378959124b9103b0bd426c855ef5a2a74ed0c19b/third_party/WebKit/Source/devtools/front_end/persistence/FileSystemMapping.js
[modify] https://crrev.com/1d4add3aa8f51a16548d6dc1a07de21c3163ef11/third_party/WebKit/Source/devtools/front_end/persistence/Persistence.js
[modify] https://crrev.com/1d4add3aa8f51a16548d6dc1a07de21c3163ef11/third_party/WebKit/Source/devtools/front_end/persistence/PersistenceUtils.js
[modify] https://crrev.com/1d4add3aa8f51a16548d6dc1a07de21c3163ef11/third_party/WebKit/Source/devtools/front_end/persistence/WorkspaceSettingsTab.js
[modify] https://crrev.com/1d4add3aa8f51a16548d6dc1a07de21c3163ef11/third_party/WebKit/Source/devtools/front_end/persistence/editFileSystemView.css
[modify] https://crrev.com/1d4add3aa8f51a16548d6dc1a07de21c3163ef11/third_party/WebKit/Source/devtools/front_end/persistence/module.json
[modify] https://crrev.com/1d4add3aa8f51a16548d6dc1a07de21c3163ef11/third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js
[modify] https://crrev.com/1d4add3aa8f51a16548d6dc1a07de21c3163ef11/third_party/WebKit/Source/devtools/front_end/sources/OpenFileQuickOpen.js
[modify] https://crrev.com/1d4add3aa8f51a16548d6dc1a07de21c3163ef11/third_party/WebKit/Source/devtools/front_end/sources/SourcesNavigator.js
[modify] https://crrev.com/1d4add3aa8f51a16548d6dc1a07de21c3163ef11/third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js
[modify] https://crrev.com/1d4add3aa8f51a16548d6dc1a07de21c3163ef11/third_party/WebKit/Source/devtools/front_end/sources/SourcesView.js
[delete] https://crrev.com/378959124b9103b0bd426c855ef5a2a74ed0c19b/third_party/WebKit/Source/devtools/front_end/sources/WorkspaceMappingTip.js
[modify] https://crrev.com/1d4add3aa8f51a16548d6dc1a07de21c3163ef11/third_party/WebKit/Source/devtools/front_end/sources/module.json
[modify] https://crrev.com/1d4add3aa8f51a16548d6dc1a07de21c3163ef11/third_party/WebKit/Source/devtools/front_end/sources_test_runner/SourcesTestRunner.js
►

Sign in to add a comment