New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 649825 link

Starred by 2 users

Issue metadata

Status: Archived
Owner: ----
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 641133
issue 646521



Sign in to add a comment

Bisecting into rolls (catapult specifically) seems broken.

Project Member Reported by robert...@chromium.org, Sep 23 2016

Issue description

This is different than failing to bisect into rolls. This is more about results like the ones below. Note that the last good and the first bad revisions should in theory be identical b/c chromium@179 is the roll, and 6dd8 is the last revision in that roll, yet they produce very different results.


===== TESTED REVISIONS =====
Revision                             Mean     Std Dev  N  Good?
chromium@418177                      4475222  137863   5  good
chromium@418178                      4087273  889650   8  good
chromium@418178,catapult@c49b5f9b94  5829497  1943097  8  good
chromium@418178,catapult@6dd8114959  5370724  1392510  5  good
chromium@418179                      9086814  592378   5  bad    <--
chromium@418180                      8616816  770426   5  bad
chromium@418182                      8665877  625060   5  bad
chromium@418186                      8790856  845366   5  bad


(from: https://bugs.chromium.org/p/chromium/issues/detail?id=646521#c13 )
 
It seems the root cause is that the bot_update running ahead of downloading and unzipping the build does not respect the overriden revisions. i.e. in the example above bot_update is not pulling catapult@6dd81 even if the image it downloads and tests was built with it.
Blocking: 641133
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/cb44b4ffbeeff3c92845e0139053ab5ec74fd49c

commit cb44b4ffbeeff3c92845e0139053ab5ec74fd49c
Author: robertocn <robertocn@chromium.org>
Date: Wed Sep 28 21:44:40 2016

Set update gclient config with override deps.

The purpose of this change is to make the bot_update step check out the
appropriate deps revisions when bisecting into rolls, this is the step
that runs locally on the bisect bot prior to unzipping the image with
the build.

R=prasadv
BUG= 649825 

Review-Url: https://codereview.chromium.org/2377113002

[modify] https://crrev.com/cb44b4ffbeeff3c92845e0139053ab5ec74fd49c/scripts/slave/recipe_modules/auto_bisect/api.py
[modify] https://crrev.com/cb44b4ffbeeff3c92845e0139053ab5ec74fd49c/scripts/slave/recipe_modules/auto_bisect/example.expected/android_arm64_bisector.json
[modify] https://crrev.com/cb44b4ffbeeff3c92845e0139053ab5ec74fd49c/scripts/slave/recipe_modules/auto_bisect/example.expected/android_bisector.json
[modify] https://crrev.com/cb44b4ffbeeff3c92845e0139053ab5ec74fd49c/scripts/slave/recipe_modules/auto_bisect/example.expected/basic.json
[modify] https://crrev.com/cb44b4ffbeeff3c92845e0139053ab5ec74fd49c/scripts/slave/recipe_modules/auto_bisect/example.expected/basic_bisect_script.json
[modify] https://crrev.com/cb44b4ffbeeff3c92845e0139053ab5ec74fd49c/scripts/slave/recipe_modules/auto_bisect/example.expected/delayed_build_test.json
[modify] https://crrev.com/cb44b4ffbeeff3c92845e0139053ab5ec74fd49c/scripts/slave/recipe_modules/auto_bisect/example.expected/failed_build_test.json
[modify] https://crrev.com/cb44b4ffbeeff3c92845e0139053ab5ec74fd49c/scripts/slave/recipe_modules/auto_bisect/example.expected/failed_test.json
[modify] https://crrev.com/cb44b4ffbeeff3c92845e0139053ab5ec74fd49c/scripts/slave/recipe_modules/auto_bisect/example.expected/mac_bisector.json
[modify] https://crrev.com/cb44b4ffbeeff3c92845e0139053ab5ec74fd49c/scripts/slave/recipe_modules/auto_bisect/example.expected/missing_metric_test.json
[modify] https://crrev.com/cb44b4ffbeeff3c92845e0139053ab5ec74fd49c/scripts/slave/recipe_modules/auto_bisect/example.expected/reversed_basic.json
[modify] https://crrev.com/cb44b4ffbeeff3c92845e0139053ab5ec74fd49c/scripts/slave/recipe_modules/auto_bisect/example.expected/windows_bisector.json
[modify] https://crrev.com/cb44b4ffbeeff3c92845e0139053ab5ec74fd49c/scripts/slave/recipe_modules/auto_bisect/example.expected/windows_x64_bisector.json
[modify] https://crrev.com/cb44b4ffbeeff3c92845e0139053ab5ec74fd49c/scripts/slave/recipe_modules/auto_bisect/revision_state.py
[modify] https://crrev.com/cb44b4ffbeeff3c92845e0139053ab5ec74fd49c/scripts/slave/recipes/bisect.expected/basic.json
[modify] https://crrev.com/cb44b4ffbeeff3c92845e0139053ab5ec74fd49c/scripts/slave/recipes/bisect.expected/basic_return_code_test.json
[modify] https://crrev.com/cb44b4ffbeeff3c92845e0139053ab5ec74fd49c/scripts/slave/recipes/bisect.expected/broken_bad_revision_test.json
[modify] https://crrev.com/cb44b4ffbeeff3c92845e0139053ab5ec74fd49c/scripts/slave/recipes/bisect.expected/broken_good_revision_test.json

Project Member

Comment 5 by bugdroid1@chromium.org, Sep 28 2016

Project Member

Comment 6 by bugdroid1@chromium.org, Sep 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/12782bff824c4f46290846f8ed649fbd548557f4

commit 12782bff824c4f46290846f8ed649fbd548557f4
Author: recipe-roller <recipe-roller@chromium.org>
Date: Wed Sep 28 22:01:05 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/cb44b4ffbeeff3c92845e0139053ab5ec74fd49c Set update gclient config with override deps. (robertocn@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG= 649825 

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2377153002
Cr-Commit-Position: refs/heads/master@{#421653}

[modify] https://crrev.com/12782bff824c4f46290846f8ed649fbd548557f4/infra/config/recipes.cfg

Project Member

Comment 7 by bugdroid1@chromium.org, Sep 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/75a723e12486696e8bec0e631a485b7ce77baae1

commit 75a723e12486696e8bec0e631a485b7ce77baae1
Author: recipe-roller <recipe-roller@chromium.org>
Date: Wed Sep 28 22:05:28 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/cb44b4ffbeeff3c92845e0139053ab5ec74fd49c Set update gclient config with override deps. (robertocn@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG= 649825 

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2380883002

[modify] https://crrev.com/75a723e12486696e8bec0e631a485b7ce77baae1/infra/config/recipes.cfg

Components: Speed>Bisection
Status: Archived (was: Untriaged)
Haven't seen this recently, think it's obsolete.

Sign in to add a comment