Deprecate WebView#{set,get}HttpAuthUsernamePassword |
||||
Issue descriptionThis was raised internally as b/31318603. These methods ultimately just call HttpAuthDatabase's corresponding methods. Because these ultimately call a singleton, having them as methods of WebView gives the illusion that they operate on each WebView instance separately. Deprecating these methods and moving them to WebViewDatabase makes things clearer to how they operate internally.
,
Sep 24 2016
,
Sep 26 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a1d96e37797afcf6dec6e3967160e1f2f2ede198 commit a1d96e37797afcf6dec6e3967160e1f2f2ede198 Author: ntfschr <ntfschr@chromium.org> Date: Mon Sep 26 22:59:50 2016 Add WebViewDatabaseAdapter#{get,set}HttpAuthUsernamePassword Add these methods to WebViewDatabaseAdapter so that they can be moved to Android's WebViewDatabase and the methods in WebView can be deprecated. BUG= 649816 Review-Url: https://codereview.chromium.org/2366023002 Cr-Commit-Position: refs/heads/master@{#421029} [modify] https://crrev.com/a1d96e37797afcf6dec6e3967160e1f2f2ede198/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromium.java [modify] https://crrev.com/a1d96e37797afcf6dec6e3967160e1f2f2ede198/android_webview/glue/java/src/com/android/webview/chromium/WebViewDatabaseAdapter.java [modify] https://crrev.com/a1d96e37797afcf6dec6e3967160e1f2f2ede198/android_webview/java/src/org/chromium/android_webview/AwContents.java
,
Jan 10 2017
CTS tests have landed, so I'm closing this.
,
Aug 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/03196aef15b20c24ea95a475bedc32ca65b5230e commit 03196aef15b20c24ea95a475bedc32ca65b5230e Author: Nate Fischer <ntfschr@chromium.org> Date: Thu Aug 17 00:03:04 2017 AW: add @Override to new APIs No logic change. This cleans up some TODOs by adding @Override to new methods in the O SDK. Bug: 627248 , 649816 , 706631 Test: ninja system_webview_google_apk && ninja system_webview_apk Change-Id: I1973660491e1ac7a46a9fead3048b976f93cd085 Reviewed-on: https://chromium-review.googlesource.com/618125 Reviewed-by: Bo <boliu@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#495004} [modify] https://crrev.com/03196aef15b20c24ea95a475bedc32ca65b5230e/android_webview/glue/java/src/com/android/webview/chromium/ContentSettingsAdapter.java [modify] https://crrev.com/03196aef15b20c24ea95a475bedc32ca65b5230e/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromium.java [modify] https://crrev.com/03196aef15b20c24ea95a475bedc32ca65b5230e/android_webview/glue/java/src/com/android/webview/chromium/WebViewDatabaseAdapter.java
,
Aug 24
Bulk edit: marking stale 'fixed' bugs as 'verified' since they don't need verification at this point. |
||||
►
Sign in to add a comment |
||||
Comment 1 by hush@chromium.org
, Sep 23 2016