Harmony - Textfields should draw a soft focus ring |
|||||||||
Issue descriptionCurrently textfields draw 1px borders instead of 1pt, and draw the focus state by stroking their border in a saturated blue. Per the revised Harmony spec, the stroke should be 1pt, not 1px, and the focus ring should be a soft 2pt stroke. bettes@ - in the spec the stroke sure looks like a rounded rect, but there's no corner radius specified anywhere. (I think the slightly rounded rect is a little friendlier.) Is the textfield border a hard rect or a slightly rounded rect?
,
Sep 23 2016
Thanks for the correction! The rectangle corners are rounded. I've revised the spec to make this more clear: border: 1pt (inside) #000 0.14a corner radius: 2dp focus ring: 2pt (outer), 0.4a #4285F4 // Same as buttons https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20browser%20(MD)/Secondary%20UI%20Previews%20and%20specs%20(exports)#%2FSPEC-secondary-UI-06-dropdown-texfields.png%3Fz=width
,
Sep 27 2016
,
Sep 27 2016
,
Sep 28 2016
I don't even know what "pt" means in this context. It's different from px and dp? Why are textfields different from buttons (as well as basically all other strokes, i.e. separators, borders, tab outlines, etc) which are stroked at 1px?
,
Sep 28 2016
also I'm pretty sure the layout margins which are specified in px should be specified in dp.
,
Sep 28 2016
bettes@ just told me via chat that he uses "pt" interchangeably with "px"
,
Sep 29 2016
For posterity, all scalable objects are noted as "pt" and non-scalable objects are in "px". I mis-spoke and so the following is true: border: 1px (inside) #000 0.14a corner radius: 2pt focus ring: 2pt (outer), 0.4a #4285F4 // Same as buttons
,
Sep 29 2016
I think the corner radius needs to be 2pt, not 2px? A 10px radius circle at 2x is 1/4 its size at 1x.
,
Sep 29 2016
Nevermind - it's exactly what it needs to be.
,
Oct 1 2016
,
Oct 1 2016
,
Oct 3 2016
I started on this last week --- https://codereview.chromium.org/2380303004/ Please ping me before taking bug ownership.
,
Oct 3 2016
What is the ETA?
,
Oct 3 2016
It's notoriously difficult to predict how long code reviews might take, so I can't give you a good ETA. Why do you ask?
,
Oct 4 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7758d0c238aefe508c4052d589b7418ab8e158e2 commit 7758d0c238aefe508c4052d589b7418ab8e158e2 Author: estade <estade@chromium.org> Date: Tue Oct 04 20:49:32 2016 Refactor MdFocusRing to make it easier to reuse on other controls. BUG= 649815 Review-Url: https://codereview.chromium.org/2383243002 Cr-Commit-Position: refs/heads/master@{#422921} [modify] https://crrev.com/7758d0c238aefe508c4052d589b7418ab8e158e2/ui/views/BUILD.gn [modify] https://crrev.com/7758d0c238aefe508c4052d589b7418ab8e158e2/ui/views/controls/button/md_text_button.cc [modify] https://crrev.com/7758d0c238aefe508c4052d589b7418ab8e158e2/ui/views/controls/button/md_text_button.h [modify] https://crrev.com/7758d0c238aefe508c4052d589b7418ab8e158e2/ui/views/controls/combobox/combobox.cc [add] https://crrev.com/7758d0c238aefe508c4052d589b7418ab8e158e2/ui/views/controls/focus_ring.cc [add] https://crrev.com/7758d0c238aefe508c4052d589b7418ab8e158e2/ui/views/controls/focus_ring.h [modify] https://crrev.com/7758d0c238aefe508c4052d589b7418ab8e158e2/ui/views/controls/focusable_border.cc [modify] https://crrev.com/7758d0c238aefe508c4052d589b7418ab8e158e2/ui/views/controls/focusable_border.h [modify] https://crrev.com/7758d0c238aefe508c4052d589b7418ab8e158e2/ui/views/controls/textfield/textfield.cc
,
Oct 4 2016
|
|||||||||
►
Sign in to add a comment |
|||||||||
/Secondary%20UI%20Previews%20and%20specs%20(exports)#%2FSPEC-secondary-UI-06-dropdown-texfields.png%3Fz=width){kind=link}
Comment 1 by shrike@chromium.org
, Sep 23 2016