Add node_modules to default folder exclude pattern
Reported by
joshung...@gmail.com,
Sep 23 2016
|
|||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/55.0.2868.0 Safari/537.36 Steps to reproduce the problem: 1. Open settings. 2. Click Workspace 3. View excludes. What is the expected behavior? Wouldn't it be helpful if node_modules is excluded by default? What went wrong? No node_modules; JavaScript developer is angry. Did this work before? No Chrome version: 55.0.2868.0 Channel: n/a OS Version: OS X 10.11.1 Flash Version: Shockwave Flash 23.0 r0
,
Oct 11 2016
Excludes by default? This would mean search-across-all-files would never touch those files for anyone, unless they edit the default pattern (which feels pretty weird). Because people use search-across-all-files to find some code that was bundled, we probably wouldn't want to exclude all of that by default. They can be added to excludes a la carte though.. wdyt, joshunger?
,
Oct 11 2016
Indeed, having both node_modules and bower_components folders excluded by default makes sense. These are not the source code you'd like to edit
,
Oct 14 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/aa2f0d4d0ac74793fad896c9f69947d1a2480d8d commit aa2f0d4d0ac74793fad896c9f69947d1a2480d8d Author: lushnikov <lushnikov@chromium.org> Date: Fri Oct 14 01:47:23 2016 DevTools: exclude node_modules and bower_components files These folders don't contain any source code, only third-party content. BUG= 649809 R=paulirish Review-Url: https://codereview.chromium.org/2416113002 Cr-Commit-Position: refs/heads/master@{#425231} [modify] https://crrev.com/aa2f0d4d0ac74793fad896c9f69947d1a2480d8d/third_party/WebKit/Source/devtools/front_end/workspace/IsolatedFileSystemManager.js
,
Oct 15 2016
node_modules's excluded; enjoy on Canary!
,
Feb 24 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by allada@chromium.org
, Oct 7 2016Status: Assigned (was: Unconfirmed)