New issue
Advanced search Search tips

Issue 649794 link

Starred by 2 users
Status: Fixed
Owner:
tbansal@chromium.org
Closed: Sep 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

DRP.ConfigService.HTTPRequests should be recorded only when DRP proxies were absent

Project Member Reported by tbansal@chromium.org, Sep 23 2016 
For a given request, data should be recorded in DataReductionProxy.ConfigService.HTTPRequests only when either (i) DRP proxies were absent because of config service AuthFailure, or (ii) DRP is going to be used for fetching the request.

Currently, it gets recorded even if the DRP is not used for fetching the request because of system proxy, or because of bypass.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 28 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7016bb232e86e08cbc9d999f8ab3dcce40b3cfbb

commit 7016bb232e86e08cbc9d999f8ab3dcce40b3cfbb
Author: tbansal <tbansal@chromium.org>
Date: Wed Sep 28 22:30:58 2016

Improve logging of DRP.ConfigService.HTTPRequests

Record DRP.ConfigService.HTTPRequests only if either Data
Reduction Proxy (DRP) is going to be used for fetching a
request, or if DRP can't be used because no valid DRP
proxy is available.

Also, renamed a histogram to match
DataReductionProxy.ConfigService.* prefix. The new name is
also the one present in histograms.xml.

BUG= 649794 

Review-Url: https://codereview.chromium.org/2365823002
Cr-Commit-Position: refs/heads/master@{#421662}

[modify] https://crrev.com/7016bb232e86e08cbc9d999f8ab3dcce40b3cfbb/components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats_unittest.cc
[modify] https://crrev.com/7016bb232e86e08cbc9d999f8ab3dcce40b3cfbb/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client.cc
[modify] https://crrev.com/7016bb232e86e08cbc9d999f8ab3dcce40b3cfbb/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client_unittest.cc
[modify] https://crrev.com/7016bb232e86e08cbc9d999f8ab3dcce40b3cfbb/components/data_reduction_proxy/core/browser/data_reduction_proxy_delegate.cc
[modify] https://crrev.com/7016bb232e86e08cbc9d999f8ab3dcce40b3cfbb/components/data_reduction_proxy/core/browser/data_reduction_proxy_delegate_unittest.cc

Comment 2 by tbansal@chromium.org, Sep 28 2016

Labels: M-55
Status: Fixed (was: Started)
►

Sign in to add a comment