Did the M-54 you used for testing also include 23.0.0.179?

https://feedback.corp.google.com/product/208/neutron?lView=rd&lRSort=1&lROrder=2&lRFilter=1&lReport=13808146737

Could this be html5 by default?

Yes M-54 use Flash 23.0.0.179.

ihf@ Facebook game still use Flash by default

Is there any strong reason we should block Dev on this?

This sounds like it may not be super serious.

We are nearing beta, this appears to still be broken on canary with 23.0.0.185.

What are our next steps here?

Well, 23.0.0.185 works just fine on M54.

The problem is caused by recent Chrome changes. Problem is I can't even bisect anymore under Linux, as there is so much brokenness in combination between html5 by default and component update (interception). How do I force enable Flash by command line? Can I still force it to use the binary provided via command line?

./bisect-builds.py -f /usr/local/google/home/ihf/.config/google-chrome/PepperFlash/23.0.0.185/libpepflashplayer.so -b 425218 -g 425200 -a linux64

The regression started going from build 8753 to 8754.

From there it gets confusing. It is not in Flash. It is not in Chromium builds using simple Chrome. Not sure I see anything suspicious in this range. Will think about it, possibly toolchain or chrome ebuild change etc.

One suspicion I have is with https://chromium-review.googlesource.com/#/c/368200/
But to verify I will need to checkout M55 chroot (in progress).

Is https://chromium-review.googlesource.com/#/c/368200/ still our suspect?

Yes, I still think this is the suspect, see
https://bugs.chromium.org/p/chromium/issues/detail?id=165239

Mike, I must be doing something wrong trying to revert your 2 changes from  issue 117330 . IMHO it should fix the issue, but it doesn't work for me. Am I missing something or is it just too late in the evening?

it does seem like that's the problem

how about i add an ebuild like chromeos-base/system-locales that will generate & install en_US.UTF8, and then the flash ebuild can rdepend on it.  can you update                flash to run setlocale() during its start up ?  or will the sandbox prevent that from working ?  it should just need read access to the locale-archive file in /usr/lib/locale/.

I can rdepend pepper-flash.ebuild.

I think Chrome already sets the locale for Flash now, will check if this is enough
https://cs.chromium.org/chromium/src/content/ppapi_plugin/ppapi_plugin_main.cc?q=setlocale+flash&sq=package:chromium&l=98&dr=C

on second thought, i don't think we need the flash RDEPEND (although you can add it if you like).  i've added it via virtual/target-os so that things like the crosh shell can utilize it.

that setlocale code looks like it should work.  great!

The chrome locale code doesn't quite work for CrOS. :-(
We still need to revert on M55
https://chromium-review.googlesource.com/#/c/397682/2/libchromeos-ui/chromeos/ui/chromium_command_builder.cc

But then on master we could unify the Chrome code so it works for CrOS as well.

+rickyz
The code in chromium is executed on Chrome OS but has no effect. I assume the CrOS sandbox is preventing us from having an effect?
https://cs.chromium.org/chromium/src/content/ppapi_plugin/ppapi_plugin_main.cc?q=setlocale+flash&sq=package:chromium&l=98&dr=C

Setting either en_US.utf8 (as before) or en_US.UTF-8 (as Chromium attempts to do) in libchromeos-ui is sufficient in combination with the system-locales change.

I'm guessing that setlocale attempts to touch things on the filesystem? Would this be something we could prewarm before dropping filesystem access (https://cs.chromium.org/chromium/src/content/zygote/zygote_main_linux.cc?l=338 - note that anything we do here would affect other processes, like renderers too)?

1) with --no-sandbox the code inside of chromium makes CrOS Flash work (without libchromeos-ui changes).

2) I don't understand how Linux Flash works (it does) - is that sandbox different from CrOS and lets setlocale through? Maybe Flash has a fallback though, but Mac used to not.

In any case, for the sake of other platforms (Mac/Linux) we should make sure the chromium setlocale calls will continue to make it through the sandbox.

The sandbox should all be the same code between desktop Linux and Chrome OS (Mac would be different though) - perhaps there is some other environmental difference here.

+Adobe FYI

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/cc933dc45bd745a81c33e089fef20741d96f286a

commit cc933dc45bd745a81c33e089fef20741d96f286a
Author: Mike Frysinger <vapier@chromium.org>
Date: Tue Oct 25 18:31:52 2016

system-locales: new package to install system locales

For now we only provide en_US.UTF-8.  This is so system processes that
need access to UTF-8 encoding can do so.

BUG= chromium:649787 
TEST=`emerge-{nyan,amd64-generic} system-locales` installs this archive to the right place

Change-Id: I001107aa82f7d5ac75dee0b1b485eb63cfc759b6
Reviewed-on: https://chromium-review.googlesource.com/403328
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Ilja H. Friedel <ihf@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Ilja H. Friedel <ihf@chromium.org>

[add] https://crrev.com/cc933dc45bd745a81c33e089fef20741d96f286a/chromeos-base/system-locales/system-locales-2.19.ebuild
[rename] https://crrev.com/cc933dc45bd745a81c33e089fef20741d96f286a/virtual/target-chromium-os/target-chromium-os-1-r56.ebuild
[modify] https://crrev.com/cc933dc45bd745a81c33e089fef20741d96f286a/virtual/target-chromium-os/target-chromium-os-1.ebuild

Bernie, I'd like to land the fix in R55, for this we need these 2 CLs
https://chromium-review.googlesource.com/#/c/403433/
https://chromium-review.googlesource.com/#/c/403834/

On master we still need to discuss where to set LC_ALL.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/d9877164cb97efe0d7ed7d829020edd1a4cf2f5b

commit d9877164cb97efe0d7ed7d829020edd1a4cf2f5b
Author: Mike Frysinger <vapier@chromium.org>
Date: Tue Oct 25 18:31:52 2016

system-locales: new package to install system locales

For now we only provide en_US.UTF-8.  This is so system processes that
need access to UTF-8 encoding can do so.

BUG= chromium:649787 
TEST=`emerge-{nyan,amd64-generic} system-locales` installs this archive to the right place

Change-Id: I001107aa82f7d5ac75dee0b1b485eb63cfc759b6
Reviewed-on: https://chromium-review.googlesource.com/403328
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Ilja H. Friedel <ihf@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Ilja H. Friedel <ihf@chromium.org>
(cherry picked from commit cc933dc45bd745a81c33e089fef20741d96f286a)
Reviewed-on: https://chromium-review.googlesource.com/403433
Reviewed-by: Mike Frysinger <vapier@chromium.org>
Commit-Queue: Bernie Thompson <bhthompson@chromium.org>
Tested-by: Bernie Thompson <bhthompson@chromium.org>

[add] https://crrev.com/d9877164cb97efe0d7ed7d829020edd1a4cf2f5b/chromeos-base/system-locales/system-locales-2.19.ebuild
[add] https://crrev.com/d9877164cb97efe0d7ed7d829020edd1a4cf2f5b/virtual/target-chromium-os/target-chromium-os-1-r56.ebuild
[modify] https://crrev.com/d9877164cb97efe0d7ed7d829020edd1a4cf2f5b/virtual/target-chromium-os/target-chromium-os-1.ebuild

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/99461a21a2193c2afbb2e685f85f7cb3e4dd722f

commit 99461a21a2193c2afbb2e685f85f7cb3e4dd722f
Author: Ilja H. Friedel <ihf@chromium.org>
Date: Wed Oct 26 18:37:40 2016

Revert "libchromeos-ui: drop LC_ALL env var setting"

This reverts commit 1e9c3dac5c903b32026f247e9af1b7fb8d66a069.

For now revert only on R55. For master discussion on  crbug.com/649787 .

BUG= chromium:117330 
BUG= chromium:652326 
BUG= chromium:649787 

Change-Id: I38f752247add52de3d7c02d2ab2a7adf8ee850c3
Reviewed-on: https://chromium-review.googlesource.com/403834
Reviewed-by: Mike Frysinger <vapier@chromium.org>
Commit-Queue: Bernie Thompson <bhthompson@chromium.org>
Tested-by: Bernie Thompson <bhthompson@chromium.org>

[modify] https://crrev.com/99461a21a2193c2afbb2e685f85f7cb3e4dd722f/libchromeos-ui/chromeos/ui/chromium_command_builder.cc
[modify] https://crrev.com/99461a21a2193c2afbb2e685f85f7cb3e4dd722f/libchromeos-ui/chromeos/ui/chromium_command_builder_unittest.cc

I am assuming with these two changes we should be good to go for 55, so this no longer blocks the beta, if not please let me know.

This should be correct. We only have to decide what to do on master now to not regress Linux and Mac.

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

This appears to have been merge, removing Merge-Approved-55.

Candy Crush still doesn't load on CrOS M56 Build # 8950.0.0 / 56.0.2905.0 - Peppy 

we're aware -- the bug specifically says we've fixed M55 only at this point

rickyz: if we pre-warm setlocale as suggested in #19 would setlocale(LC_ALL, NULL) be sufficient or would we actually have to call setlocale(LC_ALL, "en_US.utf8") already? I wouldn't want to do the latter for other processes on Linux or Mac, as I have no idea what it is going to do there.

Sorry for the slow response - I'm honestly not sure, not having looked at the glibc implementation - my gut feeling would be that we'd need en_US.utf8 to trigger it to load the relevant files.

This is horribly ugly, but it may be possible setlocale to en_US.utf8, then switch back to the original.

1) I searched the tracker for Linux Flash games and did not find anything related.
2) The sandbox on Mac is different ( issue 166050 ,  issue 165239 ).

I think at this stage I don't want to go for the "horribly ugly" prewarming, as we don't seem to need it nor do we know how to verify. I will go back to the status quo of  issue 165239  for ToT CrOS.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/ea9399310a8dcd048442e102f1ad56e8c5367dce

commit ea9399310a8dcd048442e102f1ad56e8c5367dce
Author: Ilja H. Friedel <ihf@chromium.org>
Date: Tue Nov 08 06:22:56 2016

Revert "libchromeos-ui: drop LC_ALL env var setting"

This reverts commit c0be6d55d5aa9454bd848705dbd7ba27507e76d4.

This should fix Facebook games on master.

BUG= chromium:117330 
BUG= chromium:652326 
BUG= chromium:649787 

Change-Id: I160376aa99cb956fa11a1f1c9b265f20fe56771f
Reviewed-on: https://chromium-review.googlesource.com/408818
Commit-Ready: Ilja H. Friedel <ihf@chromium.org>
Tested-by: Ilja H. Friedel <ihf@chromium.org>
Reviewed-by: Ilja H. Friedel <ihf@chromium.org>

[modify] https://crrev.com/ea9399310a8dcd048442e102f1ad56e8c5367dce/libchromeos-ui/chromeos/ui/chromium_command_builder.cc
[modify] https://crrev.com/ea9399310a8dcd048442e102f1ad56e8c5367dce/libchromeos-ui/chromeos/ui/chromium_command_builder_unittest.cc

issue not reproduce on 8992.0.0/56.0.2920.0 & Flash 23.0.0.207