New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 649762 link

Starred by 5 users
Status: Fixed
Owner:
nedngu...@google.com
Closed: Jan 2017
Cc:
serg...@chromium.org
█ kbr@chromium.org
█ phajdan.jr@chromium.org
█ kjellander@chromium.org
eyaich@chromium.org
dpranke@chromium.org
ehmaldonado@chromium.org
estaab@chromium.org
chanli@chromium.org
seanmccullough@chromium.org
liaoyuke@chromium.org
st...@chromium.org
zhangtiff@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 659620
issue 702953
issue 637904



Sign in to add a comment

Migrating telemetry_unittest & telemetry_perf_unittest to produce json test results format

Project Member Reported by nedngu...@google.com, Sep 23 2016 
To make flaky dashboard support telemetry_unittest & telemetry_perf_unittest well, we should migrate them to produce  gtest format output.

It worths noting that these suite use typ, which already has support for gtest format output. It's probably just a matter of updating SwarmedIsolatedScriptTest to support gtest format & change the commandline passing to these scripts.

Comment 1 by nedngu...@google.com, Sep 23 2016

Blocking: 637904

Comment 2 by dpranke@chromium.org, Sep 23 2016

Cc: estaab@chromium.org phajdan.jr@chromium.org serg...@chromium.org
To clarify:

typ supports http://www.chromium.org/developers/the-json-test-results-format , which is a format that the flakiness dashboard supports.

base/test/launcher-based test binaries that are passed the --test-launcher-summary-output flag produce a rather-differently-formatted file, but there's a recipe module (test_results) that converts it to the json-test-results-format .

https://cs.chromium.org/chromium/build/scripts/slave/recipe_modules/test_results/api.py
https://cs.chromium.org/chromium/build/scripts/slave/recipe_modules/test_results/resources/upload_gtest_test_results.py

I don't think native gtest supports anything like this at all.

So, I assume you're talking about "switching to the format that typ supports". Calling it the "gtest format" confuses me, at least :)

Comment 3 by serg...@chromium.org, Sep 24 2016 

According to https://plx.corp.google.com/script/#a=qo%7Ci=google%253A%253Ascript_3b._008d57_0666_4a19_9cf6_69ddda7b7a1c, neither of these steps uploads to test-resuts.appspot.com. In order to be able to upload it, they need to generate JSON in a format described at http://www.chromium.org/developers/the-json-test-results-format as Dirk mentioned.
Project Member

Comment 4 by sheriffbot@chromium.org, Sep 24 2016

Labels: Hotlist-Google

Comment 5 by st...@chromium.org, Sep 26 2016 

qq: for typ format (json-test-results-format that the flakiness dashboard supports), does it include the result of each run of a test if it is run multiple times?

Comment 6 by dpranke@chromium.org, Sep 26 2016 

> qq: for typ format (json-test-results-format that the flakiness 
> dashboard supports), does it include the result of each run of 
> a test if it is run multiple times?

Yes.

Comment 7 by nedngu...@google.com, Sep 26 2016

Summary: Migrating telemetry_unittest & telemetry_perf_unittest to produce json test results format (was: Migrating telemetry_unittest & telemetry_perf_unittest to produce gtest format output)
Sorry for the mixed-up on terminology. I thought json-test-results is the same of gtest format, and what I actually meant is http://www.chromium.org/developers/the-json-test-results-format

Comment 8 by nedngu...@google.com, Sep 26 2016

Owner: nedngu...@google.com
Status: Assigned (was: Untriaged)
I will add support for this format in swarming isolated script test recipe.

Comment 9 by serg...@chromium.org, Sep 27 2016

Cc: -serg...@chromium.org
Please re-add me to CC if you need my input.
Project Member

Comment 10 by bugdroid1@chromium.org, Oct 10 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/7baad31fc4293485a824d4ef6ef7361adc2979a1

commit 7baad31fc4293485a824d4ef6ef7361adc2979a1
Author: nednguyen <nednguyen@google.com>
Date: Mon Oct 10 15:42:38 2016

Add json test results format support for SwarmingIsolatedScriptTest

BUG= 649762 

Review-Url: https://codereview.chromium.org/2375663003

[modify] https://crrev.com/7baad31fc4293485a824d4ef6ef7361adc2979a1/scripts/slave/recipe_modules/chromium_tests/steps.py
[modify] https://crrev.com/7baad31fc4293485a824d4ef6ef7361adc2979a1/scripts/slave/recipe_modules/swarming/api.py
[add] https://crrev.com/7baad31fc4293485a824d4ef6ef7361adc2979a1/scripts/slave/recipe_modules/swarming/results_merger.py
[add] https://crrev.com/7baad31fc4293485a824d4ef6ef7361adc2979a1/scripts/slave/recipe_modules/swarming/tests/results_merger_unittest.py
[modify] https://crrev.com/7baad31fc4293485a824d4ef6ef7361adc2979a1/scripts/slave/recipe_modules/test_utils/api.py
[modify] https://crrev.com/7baad31fc4293485a824d4ef6ef7361adc2979a1/scripts/slave/recipe_modules/test_utils/test_api.py
[modify] https://crrev.com/7baad31fc4293485a824d4ef6ef7361adc2979a1/scripts/slave/recipes/chromium.expected/dynamic_swarmed_passed_isolated_script_test_with_swarming_failure.json
[modify] https://crrev.com/7baad31fc4293485a824d4ef6ef7361adc2979a1/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_failed_isolated_script_test.json
[add] https://crrev.com/7baad31fc4293485a824d4ef6ef7361adc2979a1/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_invalid_format_isolated_script_test.json
[modify] https://crrev.com/7baad31fc4293485a824d4ef6ef7361adc2979a1/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_isolated_chartjson_test_harness_failure.json
[modify] https://crrev.com/7baad31fc4293485a824d4ef6ef7361adc2979a1/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_isolated_script_test_harness_failure.json
[modify] https://crrev.com/7baad31fc4293485a824d4ef6ef7361adc2979a1/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_isolated_script_test_missing_shard.json
[modify] https://crrev.com/7baad31fc4293485a824d4ef6ef7361adc2979a1/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_passed_isolated_script_test.json
[modify] https://crrev.com/7baad31fc4293485a824d4ef6ef7361adc2979a1/scripts/slave/recipes/chromium.py
[modify] https://crrev.com/7baad31fc4293485a824d4ef6ef7361adc2979a1/scripts/slave/unittests/recipe_lint_test.py
Project Member

Comment 11 by bugdroid1@chromium.org, Oct 10 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/91078ea7daa0e4783c416046609d3a885f2ebaf4

commit 91078ea7daa0e4783c416046609d3a885f2ebaf4
Author: recipe-roller <recipe-roller@chromium.org>
Date: Mon Oct 10 16:05:25 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/7baad31fc4293485a824d4ef6ef7361adc2979a1 Add json test results format support for SwarmingIsolatedScriptTest (nednguyen@google.com)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG= 649762 

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2407883002

[modify] https://crrev.com/91078ea7daa0e4783c416046609d3a885f2ebaf4/infra/config/recipes.cfg
Project Member

Comment 12 by bugdroid1@chromium.org, Oct 10 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/caa3b797728c9337fcea7d108a087d005fa7f451

commit caa3b797728c9337fcea7d108a087d005fa7f451
Author: nednguyen <nednguyen@google.com>
Date: Mon Oct 10 19:32:59 2016

[testing/script] Switch run_telemetry_as_googletest.py to produce full json results format

BUG= 649762 

Review-Url: https://codereview.chromium.org/2403913002
Cr-Commit-Position: refs/heads/master@{#424206}

[modify] https://crrev.com/caa3b797728c9337fcea7d108a087d005fa7f451/testing/scripts/run_telemetry_as_googletest.py
Project Member

Comment 13 by bugdroid1@chromium.org, Oct 11 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/12b54d66ba1ce9e7a6c729fdf136b5b5c257b6f2

commit 12b54d66ba1ce9e7a6c729fdf136b5b5c257b6f2
Author: loyso <loyso@chromium.org>
Date: Tue Oct 11 02:05:03 2016

Revert of [testing/script] Switch run_telemetry_as_googletest.py to produce full json results format (patchset #2 id:20001 of https://codereview.chromium.org/2403913002/ )

Reason for revert:
Speculatively reverting this patch (suggested by findit) to see if it fixes Mac telemetry unit tests.

https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.10%20Tests/builds/8276

https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.10%20Tests/builds/8277

Original issue's description:
> [testing/script] Switch run_telemetry_as_googletest.py to produce full json results format
>
> BUG= 649762 
>
> Committed: https://crrev.com/caa3b797728c9337fcea7d108a087d005fa7f451
> Cr-Commit-Position: refs/heads/master@{#424206}

TBR=kbr@chromium.org,dpranke@chromium.org,nednguyen@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 649762 

Review-Url: https://codereview.chromium.org/2408043002
Cr-Commit-Position: refs/heads/master@{#424341}

[modify] https://crrev.com/12b54d66ba1ce9e7a6c729fdf136b5b5c257b6f2/testing/scripts/run_telemetry_as_googletest.py
Project Member

Comment 14 by bugdroid1@chromium.org, Oct 11 2016 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/tools/build_limited/scripts/slave/+/ba74db9f1be6a4fe27b4ba54dddbd195865f3ec1

commit ba74db9f1be6a4fe27b4ba54dddbd195865f3ec1
Author: recipe-roller <recipe-roller@chromium.org>
Date: Tue Oct 11 22:53:53 2016
Project Member

Comment 15 by bugdroid1@chromium.org, Oct 12 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/8151d3c3ab517ed5c99b104b00d2a3fd549cc813

commit 8151d3c3ab517ed5c99b104b00d2a3fd549cc813
Author: nednguyen <nednguyen@google.com>
Date: Wed Oct 12 19:08:41 2016

Rename upload_gtest_test_results.py to upload_test_results.py.

The motivation is to reuse the logic of uploading test results to support other
format such as JSON Test Result format.

*This CL was split from https://crrev.com/2410613002

BUG= 649762 

Review-Url: https://codereview.chromium.org/2411763002

[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipe_modules/test_results/api.py
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipe_modules/test_results/example.expected/upload_and_degrade_to_warning.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipe_modules/test_results/example.expected/upload_success.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipe_modules/test_results/example.expected/upload_without_degrading_failures.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipe_modules/test_results/resources/README.md
[rename] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipe_modules/test_results/resources/upload_test_results.py
[rename] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipe_modules/test_results/resources/upload_test_results_unittest.py
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/dynamic_gtest_android.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/dynamic_instrumentation_nodefault_test.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/dynamic_instrumentation_test.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/dynamic_instrumentation_test_with_timeout_scale.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/dynamic_junit_test.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/dynamic_swarmed_gtest_mac_gpu.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/dynamic_swarmed_serialized_gtests.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_android_Android_Webview_L__dbg_.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_android_Android_Webview_M__dbg_.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_chromiumos_Linux_ChromiumOS_Ozone_Tests__1_.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_chromiumos_Linux_ChromiumOS_Tests__1_.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_chromiumos_Linux_ChromiumOS_Tests__dbg__1_.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_fyi_Android_Asan_Builder_Tests__dbg_.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_fyi_Android_Coverage__dbg_.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_fyi_Android_Remoting_Tests.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTLinuxASan_tester.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTLinuxLLD_tester.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTLinuxUBSanVptr_tester.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTLinux_tester.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTMacASan_tester.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTMac_tester.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTWin64_dbg__tester.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTWin64_dll__tester.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTWin64_tester.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTWin_dbg__tester.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTWin_dll__tester.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTWin_tester.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWinAsanCov_tester.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWinAsan_dll__tester.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWinAsan_tester.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWinClang64_dbg__tester.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWinClang64_dll__tester.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWinClang64_tester.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWinClangLLD64_tester.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWinClangLLD_tester.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWinClang_dbg__tester.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWinClang_shared__tester.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWinClang_tester.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWinClngLLD64dbg_tester.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWinClngLLDdbg_tester.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_fyi_Linux_remote_run_Tester.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_fyi_Win7_Tests__ANGLE_.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_gpu_Linux_Debug__NVIDIA_.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_gpu_Linux_Release__NVIDIA_.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_gpu_Mac_10_10_Debug__Intel_.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_gpu_Mac_10_10_Release__Intel_.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_gpu_Mac_10_10_Retina_Debug__AMD_.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_gpu_Mac_10_10_Retina_Release__AMD_.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_gpu_Win7_Debug__NVIDIA_.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_gpu_Win7_Release__NVIDIA_.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_Fake_Linux_Release__NVIDIA_.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_Linux_Debug__NVIDIA_.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_Linux_Release__NVIDIA_.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_Mac_10_10_Debug__Intel_.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_Mac_10_10_Release__Intel_.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_Mac_10_10_Retina_Debug__AMD_.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_Mac_10_10_Retina_Release__AMD_.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_Mac_Retina_Debug.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_Mac_Retina_Release.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_Optional_Linux_Release__NVIDIA_.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_Optional_Mac_10_10_Release__Intel_.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_Optional_Mac_10_10_Retina_Release__AMD_.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_Optional_Mac_Retina_Release.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_Optional_Win7_Release__ATI_.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_Optional_Win7_Release__NVIDIA_.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_Win7_Debug__ATI_.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_Win7_Debug__NVIDIA_.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_Win7_Release__ATI_.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_Win7_Release__NVIDIA_.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_Win7_x64_Debug__NVIDIA_.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_Win7_x64_Release__NVIDIA_.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_Win8_Debug__NVIDIA_.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_Win8_Release__NVIDIA_.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_linux_Linux_Tests.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_linux_Linux_Tests__dbg__1_.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_linux_Linux_Tests__dbg__1__32_.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_mac_Mac10_9_Tests.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_mac_Mac10_9_Tests__dbg_.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_memory_Linux_ASan_LSan_Tests__1_.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_memory_Linux_ASan_Tests__sandboxed_.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_memory_Linux_Chromium_OS_ASan_LSan_Tests__1_.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_memory_Mac_ASan_64_Tests__1_.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_memory_full_Linux_ChromeOS_MSan_Tests.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_memory_full_Linux_MSan_Tests.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_memory_full_Linux_TSan_Tests.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_perf_fyi_Win_10_Low_End_Perf_Tests.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_webkit_WebKit_Mac10_10.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_webkit_WebKit_Mac10_11.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_webkit_WebKit_Mac10_11__dbg_.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_webkit_WebKit_Win10.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_webkit_WebKit_Win7.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_webkit_WebKit_Win7__dbg_.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_win_Win10_Tests_x64.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_win_Win7_Tests__1_.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_win_Win7_Tests__dbg__1_.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_win_Win7__32__Tests.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_win_Win_7_Tests_x64__1_.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_client_skia_Linux_Tests.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_client_skia_Linux_Tests_Trybot.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_client_skia_Mac10_9_Tests.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_client_skia_Mac10_9_Tests_Trybot.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_client_skia_Win7_Tests__1_.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_client_skia_Win7_Tests__1__Trybot.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_android_android_coverage.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium_trybot.expected/swarming_test_failure.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium_trybot.expected/swarming_test_with_priority_expiration_and_timeout.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/findit/chromium/test.expected/all_test_failed.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/findit/chromium/test.expected/all_test_passed.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/findit/chromium/test.expected/findit_consecutive_culprits.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/findit/chromium/test.expected/findit_culprit_in_first_sub_range.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/findit/chromium/test.expected/findit_culprit_in_last_sub_range.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/findit/chromium/test.expected/findit_culprit_in_middle_sub_range.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/findit/chromium/test.expected/findit_steps_multiple_culprits.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/findit/chromium/test.expected/findit_tests_multiple_culprits.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/findit/chromium/test.expected/only_one_test_passed.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/findit/chromium/test.expected/swarming_tests.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/findit/chromium/test.expected/unaffected_test_skipped_by_analyze.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/findit/chromium/test.expected/use_analyze_set_to_False_for_non_linear_try_job.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/findit/chromium/test.expected/use_build_parameter_for_tests.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/swarming/staging.expected/linux_Debug.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/swarming/staging.expected/linux_Release.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/swarming/staging.expected/mac_Debug.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/swarming/staging.expected/mac_Release.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/swarming/staging.expected/one_fails.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/swarming/staging.expected/win_Debug.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/swarming/staging.expected/win_Release.json
Project Member

Comment 16 by bugdroid1@chromium.org, Oct 12 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/8151d3c3ab517ed5c99b104b00d2a3fd549cc813

commit 8151d3c3ab517ed5c99b104b00d2a3fd549cc813
Author: nednguyen <nednguyen@google.com>
Date: Wed Oct 12 19:08:41 2016

Rename upload_gtest_test_results.py to upload_test_results.py.

The motivation is to reuse the logic of uploading test results to support other
format such as JSON Test Result format.

*This CL was split from https://crrev.com/2410613002

BUG= 649762 

Review-Url: https://codereview.chromium.org/2411763002

[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipe_modules/test_results/api.py
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipe_modules/test_results/example.expected/upload_and_degrade_to_warning.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipe_modules/test_results/example.expected/upload_success.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipe_modules/test_results/example.expected/upload_without_degrading_failures.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipe_modules/test_results/resources/README.md
[rename] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipe_modules/test_results/resources/upload_test_results.py
[rename] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipe_modules/test_results/resources/upload_test_results_unittest.py
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/dynamic_gtest_android.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/dynamic_instrumentation_nodefault_test.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/dynamic_instrumentation_test.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/dynamic_instrumentation_test_with_timeout_scale.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/dynamic_junit_test.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/dynamic_swarmed_gtest_mac_gpu.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/dynamic_swarmed_serialized_gtests.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_android_Android_Webview_L__dbg_.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_android_Android_Webview_M__dbg_.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_chromiumos_Linux_ChromiumOS_Ozone_Tests__1_.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_chromiumos_Linux_ChromiumOS_Tests__1_.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_chromiumos_Linux_ChromiumOS_Tests__dbg__1_.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_fyi_Android_Asan_Builder_Tests__dbg_.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_fyi_Android_Coverage__dbg_.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_fyi_Android_Remoting_Tests.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTLinuxASan_tester.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTLinuxLLD_tester.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTLinuxUBSanVptr_tester.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTLinux_tester.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTMacASan_tester.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTMac_tester.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTWin64_dbg__tester.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTWin64_dll__tester.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTWin64_tester.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTWin_dbg__tester.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTWin_dll__tester.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTWin_tester.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWinAsanCov_tester.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWinAsan_dll__tester.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWinAsan_tester.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWinClang64_dbg__tester.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWinClang64_dll__tester.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWinClang64_tester.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWinClangLLD64_tester.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWinClangLLD_tester.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWinClang_dbg__tester.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWinClang_shared__tester.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWinClang_tester.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWinClngLLD64dbg_tester.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWinClngLLDdbg_tester.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_fyi_Linux_remote_run_Tester.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_fyi_Win7_Tests__ANGLE_.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_gpu_Linux_Debug__NVIDIA_.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_gpu_Linux_Release__NVIDIA_.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_gpu_Mac_10_10_Debug__Intel_.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_gpu_Mac_10_10_Release__Intel_.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_gpu_Mac_10_10_Retina_Debug__AMD_.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_gpu_Mac_10_10_Retina_Release__AMD_.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_gpu_Win7_Debug__NVIDIA_.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_gpu_Win7_Release__NVIDIA_.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_Fake_Linux_Release__NVIDIA_.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_Linux_Debug__NVIDIA_.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_Linux_Release__NVIDIA_.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_Mac_10_10_Debug__Intel_.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_Mac_10_10_Release__Intel_.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_Mac_10_10_Retina_Debug__AMD_.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_Mac_10_10_Retina_Release__AMD_.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_Mac_Retina_Debug.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_Mac_Retina_Release.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_Optional_Linux_Release__NVIDIA_.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_Optional_Mac_10_10_Release__Intel_.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_Optional_Mac_10_10_Retina_Release__AMD_.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_Optional_Mac_Retina_Release.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_Optional_Win7_Release__ATI_.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_Optional_Win7_Release__NVIDIA_.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_Win7_Debug__ATI_.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_Win7_Debug__NVIDIA_.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_Win7_Release__ATI_.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_Win7_Release__NVIDIA_.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_Win7_x64_Debug__NVIDIA_.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_Win7_x64_Release__NVIDIA_.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_Win8_Debug__NVIDIA_.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_Win8_Release__NVIDIA_.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_linux_Linux_Tests.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_linux_Linux_Tests__dbg__1_.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_linux_Linux_Tests__dbg__1__32_.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_mac_Mac10_9_Tests.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_mac_Mac10_9_Tests__dbg_.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_memory_Linux_ASan_LSan_Tests__1_.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_memory_Linux_ASan_Tests__sandboxed_.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_memory_Linux_Chromium_OS_ASan_LSan_Tests__1_.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_memory_Mac_ASan_64_Tests__1_.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_memory_full_Linux_ChromeOS_MSan_Tests.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_memory_full_Linux_MSan_Tests.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_memory_full_Linux_TSan_Tests.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_perf_fyi_Win_10_Low_End_Perf_Tests.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_webkit_WebKit_Mac10_10.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_webkit_WebKit_Mac10_11.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_webkit_WebKit_Mac10_11__dbg_.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_webkit_WebKit_Win10.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_webkit_WebKit_Win7.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_webkit_WebKit_Win7__dbg_.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_win_Win10_Tests_x64.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_win_Win7_Tests__1_.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_win_Win7_Tests__dbg__1_.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_win_Win7__32__Tests.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_chromium_win_Win_7_Tests_x64__1_.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_client_skia_Linux_Tests.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_client_skia_Linux_Tests_Trybot.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_client_skia_Mac10_9_Tests.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_client_skia_Mac10_9_Tests_Trybot.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_client_skia_Win7_Tests__1_.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium.expected/full_client_skia_Win7_Tests__1__Trybot.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_android_android_coverage.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium_trybot.expected/swarming_test_failure.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/chromium_trybot.expected/swarming_test_with_priority_expiration_and_timeout.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/findit/chromium/test.expected/all_test_failed.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/findit/chromium/test.expected/all_test_passed.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/findit/chromium/test.expected/findit_consecutive_culprits.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/findit/chromium/test.expected/findit_culprit_in_first_sub_range.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/findit/chromium/test.expected/findit_culprit_in_last_sub_range.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/findit/chromium/test.expected/findit_culprit_in_middle_sub_range.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/findit/chromium/test.expected/findit_steps_multiple_culprits.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/findit/chromium/test.expected/findit_tests_multiple_culprits.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/findit/chromium/test.expected/only_one_test_passed.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/findit/chromium/test.expected/swarming_tests.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/findit/chromium/test.expected/unaffected_test_skipped_by_analyze.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/findit/chromium/test.expected/use_analyze_set_to_False_for_non_linear_try_job.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/findit/chromium/test.expected/use_build_parameter_for_tests.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/swarming/staging.expected/linux_Debug.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/swarming/staging.expected/linux_Release.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/swarming/staging.expected/mac_Debug.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/swarming/staging.expected/mac_Release.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/swarming/staging.expected/one_fails.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/swarming/staging.expected/win_Debug.json
[modify] https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813/scripts/slave/recipes/swarming/staging.expected/win_Release.json
Project Member

Comment 17 by bugdroid1@chromium.org, Oct 12 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/b034e018fd2402f16e4c9e919267f2c9d4624fa2

commit b034e018fd2402f16e4c9e919267f2c9d4624fa2
Author: recipe-roller <recipe-roller@chromium.org>
Date: Wed Oct 12 20:36:23 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813 Rename upload_gtest_test_results.py to upload_test_results.py. (nednguyen@google.com)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG= 649762 

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2408233005

[modify] https://crrev.com/b034e018fd2402f16e4c9e919267f2c9d4624fa2/infra/config/recipes.cfg
Project Member

Comment 18 by bugdroid1@chromium.org, Oct 12 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/719a2aa71e347064400c73513b72744be07153c9

commit 719a2aa71e347064400c73513b72744be07153c9
Author: recipe-roller <recipe-roller@chromium.org>
Date: Wed Oct 12 21:20:29 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/8151d3c3ab517ed5c99b104b00d2a3fd549cc813 Rename upload_gtest_test_results.py to upload_test_results.py. (nednguyen@google.com)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG= 649762 

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2411413002
Cr-Commit-Position: refs/heads/master@{#424856}

[modify] https://crrev.com/719a2aa71e347064400c73513b72744be07153c9/infra/config/recipes.cfg
Project Member

Comment 19 by bugdroid1@chromium.org, Oct 13 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/1a9df62478f43484695e00ed6a808673461c5736

commit 1a9df62478f43484695e00ed6a808673461c5736
Author: nednguyen <nednguyen@google.com>
Date: Thu Oct 13 10:36:15 2016

Rename --input-gtest-json flag to --input-json flag

This is for generalizing the logic of uploading test results
to support other format such as JSON Test Result format.

BUG= 655520 , 649762 

Review-Url: https://codereview.chromium.org/2409993005

[modify] https://crrev.com/1a9df62478f43484695e00ed6a808673461c5736/scripts/slave/recipe_modules/test_results/resources/upload_test_results.py
Project Member

Comment 20 by bugdroid1@chromium.org, Oct 13 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/e1068b5b44eace8d671ac9b8147dc95dbb77e11c

commit e1068b5b44eace8d671ac9b8147dc95dbb77e11c
Author: recipe-roller <recipe-roller@chromium.org>
Date: Thu Oct 13 11:28:17 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/1a9df62478f43484695e00ed6a808673461c5736 Rename --input-gtest-json flag to --input-json flag (nednguyen@google.com)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG= 649762 , 655520 

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2415923002

[modify] https://crrev.com/e1068b5b44eace8d671ac9b8147dc95dbb77e11c/infra/config/recipes.cfg

Comment 21 by estaab@chromium.org, Oct 13 2016

Components: Infra>Flakiness>Dashboard
I think it was a mistake to change the API of test_results to take either form of json and auto-detect if it's gtest json or test-results json since people conflate the two enough as it is (it even happened earlier in this bug). We can fix it once it's all working, though.

Comment 22 by nedngu...@google.com, Oct 14 2016

Blocking: 637904

Comment 23 by nedngu...@google.com, Oct 26 2016

Blocking: 659620
Project Member

Comment 24 by bugdroid1@chromium.org, Oct 31 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/0f5673778f3f8aa418d5ba97153ba7499ab4ad42

commit 0f5673778f3f8aa418d5ba97153ba7499ab4ad42
Author: nednguyen <nednguyen@google.com>
Date: Mon Oct 31 10:34:11 2016

[recipe_modules/test_results] Refactor the logic of
generating full json results files to a single method

The motivation is we will add logic to not generate full
json results files if the json already has full JSON
results format.

This CL is a pure refactoring CL, there is no intended
behavior change.

BUG= 649762 

Review-Url: https://codereview.chromium.org/2460953002

[modify] https://crrev.com/0f5673778f3f8aa418d5ba97153ba7499ab4ad42/scripts/slave/recipe_modules/test_results/resources/upload_test_results.py
Project Member

Comment 25 by bugdroid1@chromium.org, Oct 31 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/6cf3c6dcbcc7095f11d51e18599e8298fe654db3

commit 6cf3c6dcbcc7095f11d51e18599e8298fe654db3
Author: jbudorick <jbudorick@chromium.org>
Date: Mon Oct 31 17:22:36 2016

Revert of [recipe_modules/test_results] Refactor the logic of generating full json results files (patchset #1 id:1 of https://codereview.chromium.org/2460953002/ )

Reason for revert:
breaks result generation:

Traceback (most recent call last):
  File "/b/rr/tmppE_6sh/rw/checkout/infra/.recipe_deps/build/scripts/slave/recipe_modules/test_results/resources/upload_test_results.py", line 156, in <module>
    sys.exit(main())
  File "/b/rr/tmppE_6sh/rw/checkout/infra/.recipe_deps/build/scripts/slave/recipe_modules/test_results/resources/upload_test_results.py", line 138, in main
    master_name=options.master_name)
TypeError: generate_json_results_file() got an unexpected keyword argument 'builder_number'

e.g. from https://build.chromium.org/p/chromium.android/builders/Lollipop%20Low-end%20Tester/builds/4229/steps/Upload%20to%20test-results%20%5Bandroid_webview_test_apk%5D/logs/stdio

Original issue's description:
> [recipe_modules/test_results] Refactor the logic of
> generating full json results files to a single method
>
> The motivation is we will add logic to not generate full
> json results files if the json already has full JSON
> results format.
>
> This CL is a pure refactoring CL, there is no intended
> behavior change.
>
> BUG= 649762 
>
> Committed: https://chromium.googlesource.com/chromium/tools/build/+/0f5673778f3f8aa418d5ba97153ba7499ab4ad42

TBR=kbr@chromium.org,estaab@chromium.org,phajdan.jr@chromium.org,nednguyen@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 649762 

Review-Url: https://codereview.chromium.org/2464843003

[modify] https://crrev.com/6cf3c6dcbcc7095f11d51e18599e8298fe654db3/scripts/slave/recipe_modules/test_results/resources/upload_test_results.py
Project Member

Comment 26 by bugdroid1@chromium.org, Nov 3 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/181b3c9d2f25c7caa6980daec07ac280144b6cf5

commit 181b3c9d2f25c7caa6980daec07ac280144b6cf5
Author: nednguyen <nednguyen@google.com>
Date: Thu Nov 03 23:34:37 2016

[recipe_modules/test_results] Refactor the logic of generating full json results files to a single method (RELAND)

The motivation is we will add logic to not generate full
json results files if the json already has full JSON
results format.

This CL is a pure refactoring CL, there is no intended
behavior change.

*Reland: this includes the fix & unittest that would catch the error.

BUG= 649762 

Review-Url: https://codereview.chromium.org/2469233003

[modify] https://crrev.com/181b3c9d2f25c7caa6980daec07ac280144b6cf5/scripts/slave/recipe_modules/test_results/resources/upload_test_results.py
[modify] https://crrev.com/181b3c9d2f25c7caa6980daec07ac280144b6cf5/scripts/slave/recipe_modules/test_results/resources/upload_test_results_unittest.py
Project Member

Comment 29 by bugdroid1@chromium.org, Nov 7 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/31c541dea4737f0b5a112d235e5cdebcea18d0bb

commit 31c541dea4737f0b5a112d235e5cdebcea18d0bb
Author: nednguyen <nednguyen@google.com>
Date: Mon Nov 07 16:16:54 2016

Reland of [testing/script] Switch run_telemetry_as_googletest.py to produce full json results format (patchset #1 id:1 of https://codereview.chromium.org/2408043002/ )

Reason for revert:
Mac 10.10 Tests & Mac 10.11 Tests are now swarmed:
https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.10%20Tests/builds/8831

https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.11%20Tests/builds/3344

Original issue's description:
> Revert of [testing/script] Switch run_telemetry_as_googletest.py to produce full json results format (patchset #2 id:20001 of https://codereview.chromium.org/2403913002/ )
>
> Reason for revert:
> Speculatively reverting this patch (suggested by findit) to see if it fixes Mac telemetry unit tests.
>
> https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.10%20Tests/builds/8276
>
> https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.10%20Tests/builds/8277
>
> Original issue's description:
> > [testing/script] Switch run_telemetry_as_googletest.py to produce full json results format
> >
> > BUG= 649762 
> >
> > Committed: https://crrev.com/caa3b797728c9337fcea7d108a087d005fa7f451
> > Cr-Commit-Position: refs/heads/master@{#424206}
>
> TBR=kbr@chromium.org,dpranke@chromium.org,nednguyen@google.com
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG= 649762 
>
> Committed: https://crrev.com/12b54d66ba1ce9e7a6c729fdf136b5b5c257b6f2
> Cr-Commit-Position: refs/heads/master@{#424341}

TBR=kbr@chromium.org,dpranke@chromium.org,loyso@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 649762 

Review-Url: https://codereview.chromium.org/2480273002
Cr-Commit-Position: refs/heads/master@{#430285}

[modify] https://crrev.com/31c541dea4737f0b5a112d235e5cdebcea18d0bb/testing/scripts/run_telemetry_as_googletest.py

Comment 31 by nedngu...@google.com, Nov 9 2016

Status: Started (was: Fixed)
Hmhh, the flakiness report still track failure the whole suite instead of individual test (https://bugs.chromium.org/p/chromium/issues/detail?id=637904#c104). Anyone know which step is still missing?

Comment 32 by serg...@chromium.org, Nov 9 2016 

Looks like the examples from #30 are waterfall builds, while chromium-try-flake only supports tryserver builds. Sorry, if I was unclear before, but now that you wrote support for generating correct JSON format, it should be easy to add support for tryservers as well.

Comment 33 by nedngu...@google.com, Nov 9 2016

Owner: serg...@chromium.org
Thanks Sergiy! Can you help taking the rest of this bug?

Comment 35 by serg...@chromium.org, Nov 9 2016 

Looks like despite the message in the log, the results were not uploaded: https://test-results.appspot.com/testfile?builder=mac_chromium_10.10_rel_ng&name=full_results.json&master=tryserver.chromium.mac&buildnumber=142954. I don't see telemetry_perf_unittests in this list.

I'd love to help, but unfortunately I don't have the time atm.

Comment 36 by serg...@chromium.org, Nov 9 2016

Owner: nedngu...@google.com

Comment 37 by nedngu...@google.com, Nov 9 2016 

Thanks for the clue. It's possible that there is bug in the uploading pipeline.

Comment 38 by kbr@chromium.org, Nov 10 2016

Cc: andyb...@chromium.org
Andy: this is a good example of a crossover team project where help is needed from the Infra team.

Comment 39 by estaab@chromium.org, Nov 10 2016 

Ned, your changes in the recipe module don't seen to perform the actual upload. You can test this by running:

% ./build/scripts/slave/recipe_modules/test_results/resources/upload_test_results.py --master-name tryserver.chromium.mac --builder-name mac_chromium_10.10_rel_ng --test-type telemetry_perf_unittests --test-results-server test-results-test.appspot.com --chrome-revision 430938 --input-json input.json --build-number 142950
Input JSON file probably has full json results format
Uploading JSON files for builder "mac_chromium_10.10_rel_ng" to server "test-results-test.appspot.com"

And then viewing:
https://test-results-test.appspot.com/testfile?builder=mac_chromium_10.10_rel_ng&name=full_results.json&master=tryserver.chromium.mac&testtype=telemetry_perf_unittests&buildnumber=142950
(no results)

Comment 40 by estaab@chromium.org, Nov 10 2016 

Fix sent for review in https://chromium-review.googlesource.com/c/409619/
Project Member

Comment 41 by bugdroid1@chromium.org, Nov 10 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/c120057dff7a54669cca1c5069b80e060ba487b9

commit c120057dff7a54669cca1c5069b80e060ba487b9
Author: Erik Staab <estaab@google.com>
Date: Thu Nov 10 14:39:07 2016

[recipe_modules/test_result] Fix name of file to be explicit.

When using test-results json format the file name was being set
to the base name of the actual file (normally a random string)
instead of full_results.json.

BUG= 649762 

Change-Id: If741e353c8b317360b633aeb7be04ea0f08d6603
Reviewed-on: https://chromium-review.googlesource.com/409619
Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org>
Commit-Queue: Ned Nguyen <nednguyen@google.com>

[modify] https://crrev.com/c120057dff7a54669cca1c5069b80e060ba487b9/scripts/slave/recipe_modules/test_results/resources/upload_test_results.py
Project Member

Comment 42 by bugdroid1@chromium.org, Nov 10 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/aac953f6c8d5c36c28b17a39c34708182ecdb5c4

commit aac953f6c8d5c36c28b17a39c34708182ecdb5c4
Author: Erik Staab <estaab@google.com>
Date: Thu Nov 10 19:27:36 2016

[recipe_modules/test_result] Use full filename instead of base.

The second tuple element is supposed to be the actual file on disk
and uploads are failing because they're looking in the wrong place.

BUG= 649762 

Change-Id: I0d5a25452c558a8fb5ca9b5e80f5352a7caa9044
Reviewed-on: https://chromium-review.googlesource.com/410030
Commit-Queue: Erik Staab <estaab@chromium.org>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>

[modify] https://crrev.com/aac953f6c8d5c36c28b17a39c34708182ecdb5c4/scripts/slave/recipe_modules/test_results/resources/upload_test_results.py

Comment 43 by estaab@chromium.org, Nov 10 2016 

Files are being uploaded now but it looks like build_number is not being set in the file and test-results needs it. I'm not sure how difficult that would be to add to the code generating the json. We could do it in the recipe if we deserialize the json, add it, then serialize it again. Maybe we can pass it outside of the json and let the server read it from there instead.

I think the last option is probably best but I've ran out of time to work on this today. Ned, if you want to keep working on it please go ahead, otherwise I can look again in a few days.

Comment 44 by nedngu...@google.com, Nov 10 2016 

I think monkey patching it to the json in recipe land is the best option as this allows other test harness to not add extra flags as well.

Comment 46 by estaab@chromium.org, Nov 11 2016 

Something is causing the aggregated data to be in the wrong format resulting in load errors, though I can't seem to find a problem with the full_results format.

Here are some links to help with debugging.

aggregated results (results-small.json) for telemetry_perf_unittests vs unit_tests:
http://test-results.appspot.com/testfile?builder=Mac10.11%20Tests&master=chromium.mac&name=results-small.json&testtype=telemetry_perf_unittests
http://test-results.appspot.com/testfile?builder=Mac10.11%20Tests&name=results-small.json&master=chromium.mac&testtype=unit_tests

full_results.json for telemetry_perf_unittests vs unit_tests:
http://test-results.appspot.com/testfile?builder=Mac10.11%20Tests&name=full_results.json&master=chromium.mac&testtype=telemetry_perf_unittests&buildnumber=3551
http://test-results.appspot.com/testfile?builder=Mac10.11%20Tests&name=full_results.json&master=chromium.mac&testtype=unit_tests&buildnumber=3550

The top-level key doesn't have the builder name for results-small.json telemetry_perf_unittests whereas the one for unit_tests does. I suspect this is the problem based on the errors in the console.

Comment 47 by nedngu...@google.com, Nov 12 2016 

Erik: you know which code does the job of converting full result to results-small.json for telemetry_perf_unittests ? If seems to me the data that produced by recipe right before uploading to the dashboard is http://test-results.appspot.com/testfile?builder=Mac10.11%20Tests&master=chromium.mac&name=results-small.json&testtype=telemetry_perf_unittests which does contain the builder name

Comment 48 by estaab@chromium.org, Nov 12 2016 

It should be this:
https://chromium.googlesource.com/infra/infra/+/master/go/src/infra/appengine/test-results/frontend/upload.go#258

We probably want to make a debug binary for testing this outside of appengine.

Comment 49 by nedngu...@google.com, Nov 14 2016 

The telemetry full results looks like:
{
	"tests": {
         ....
        },
	"build_number": "3551",
	"master_name": "chromium.mac",
	"interrupted": false,
	"num_failures_by_type": {
		"FAIL": 0,
		"SKIP": 88,
		"PASS": 225
	},
	"version": 3,
	"builder_name": "Mac10.11 Tests",
	"seconds_since_epoch": 1478900432,
	"path_delimiter": ".",
	"chromium_revision": "431626"
}

Whereas the unittest results look like:
{
	"tests": {
         ....
        }, 
	"build_number": "3550",
	"version": 3,
	"builder_name": "Mac10.11 Tests",
	"seconds_since_epoch": 1478899132,
	"num_failures_by_type": {
		"FAIL": 3,
		"SKIP": 41,
		"PASS": 7386
	},
	"chromium_revision": "431622"
}


I can't really figure out why the go server would fail to extract the builder name to the results-small.json as you mentioned. Erik: can you help with this?

Comment 50 by estaab@chromium.org, Nov 14 2016

Owner: estaab@chromium.org
Status: Assigned (was: Started)
Yeah, this looks to be server-side so I'll see what I can figure out. It's going to take at least a few days to get time to do this, though.

Comment 51 by nedngu...@google.com, Nov 14 2016 

Thanks!

Comment 52 by estaab@chromium.org, Nov 22 2016 

Quick update: I'm able to reproduce this locally from the command line now and I'm working on a fix.

Comment 53 by nedngu...@google.com, Dec 2 2016 

Ping Erik, any update on your fix?

Comment 54 by estaab@chromium.org, Dec 5 2016 

No updates yet. I'm traveling at the moment and it's a busy week so progress may be slow for a few more days. If you're interested I can pass along some test code and test data.

Comment 55 by nedngu...@google.com, Dec 5 2016 

Sure Erik, if you can point those to me, I can take a look while you're busy.

Comment 56 by ehmaldonado@chromium.org, Dec 7 2016

Cc: kjellander@chromium.org ehmaldonado@chromium.org
This might be related:

We're having problems uploading the test results to test-results.appspot.com

Input JSON file probably has full json results format
Uploading JSON files for builder "Mac (swarming)" to server "test-results.appspot.com"
Traceback (most recent call last):
  File "/b/rr/tmpV1Oxa2/rw/checkout/scripts/slave/recipe_modules/test_results/resources/upload_test_results.py", line 200, in <module>
    sys.exit(main(sys.argv[1:]))
  File "/b/rr/tmpV1Oxa2/rw/checkout/scripts/slave/recipe_modules/test_results/resources/upload_test_results.py", line 195, in main
    options.test_results_server, attrs, files, 120)
  File "/b/rr/tmpV1Oxa2/rw/checkout/scripts/slave/recipe_modules/test_results/resources/test_results_uploader.py", line 50, in upload_test_results
    timeout_secs)
  File "/b/rr/tmpV1Oxa2/rw/checkout/scripts/slave/recipe_modules/test_results/resources/test_results_uploader.py", line 132, in _retry_exp_backoff
    % (e.code, e.filename))
test_results_uploader.PermanentError: Received HTTP status 400 loading "http://test-results.appspot.com/testfile/upload".
step returned non-zero exit code: 1

The full build is available at:
https://build.chromium.org/p/client.webrtc.fyi/builders/Mac%20%28swarming%29/builds/123

And the JSON files produced at https://build.chromium.org/p/client.webrtc.fyi/builders/Mac%20%28swarming%29/builds/123/steps/audio_decoder_unittests%20on%20Mac-10.11/logs/outdir_json or http://pastebin.com/Gk8AMFP8 if the logs have expired.

Comment 57 by dpranke@chromium.org, Jan 9 2017 

@estaab - are you still the right owner for this?

Comment 58 by kjellander@chromium.org, Jan 10 2017 

FYI: Edward's comment #56 was later resolved (I think we were uploading in the wrong JSON format).

Comment 59 by benhenry@chromium.org, Jan 11 2017

Labels: -Pri-3 Pri-1
This is listed as a high priority from Perf team. Bumping priority.

Comment 60 by estaab@chromium.org, Jan 12 2017 

I'm still the right owner, I need to clean up a CL with test code and data still.

Comment 61 by andyb...@chromium.org, Jan 18 2017

Cc: -andyb...@chromium.org

Comment 62 by estaab@chromium.org, Jan 19 2017

Owner: nednguyen@chromium.org
Ok, Sergiy pushed a change to the test-results server to clean up corrupted aggregate files, which may have been the problem with these particular uploads given it took a few iterations to get the correct data uploading. When I view results here:
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=telemetry_perf_unittests&builder=chromium.mac%3AMac10.10%20Tests

I see current data with some flaky results. Does this look correct? Does anything else appear to be missing? We may already be done but I want to get signoff in case I've missed something.

Comment 63 by nedngu...@google.com, Jan 19 2017

Owner: nedngu...@google.com

Comment 64 by nedngu...@google.com, Jan 19 2017 

Awesome! I confirm that testTelemetryUsesChromeClockDomain is flaky on every run thanks to the flakiness dashboard. This bug is now fixed!

Comment 65 by nedngu...@google.com, Jan 19 2017

Status: Fixed (was: Assigned)

Comment 66 by estaab@chromium.org, Jan 19 2017

Cc: serg...@chromium.org
Great!! Glad this is finally resolved, thanks Ned and Sergiy for all the work to get this done.

Comment 67 by kbr@chromium.org, Mar 19 2017

Blocking: 702953
►

Sign in to add a comment