New issue
Advanced search Search tips

Issue 649756 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

Angle Histogram Macros Don't Cache Pointers To Histograms

Project Member Reported by bcwh...@chromium.org, Sep 23 2016

Issue description

third_party/angle/src/libANGLE/histogram_macros.h
As of 2016-09-23, the macros defined do a FactoryGet() every time they update a histogram, resulting in the acquisition of a global lock plus a lookup-by-string in a std::map of all histograms known tho the process.

Consider adopting the method in base/metrics/histogram_macros.h and cache a local pointer to the histogram when fetched so that future passes through that macro instantiation can avoid the high lookup cost (90% savings or more).

 
Components: Internals>GPU>ANGLE
Labels: -Pri-3 OS-Windows Pri-2
Status: Assigned (was: Untriaged)
Thanks Brian for the investigation.

Sign in to add a comment