New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 649744 link

Starred by 4 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Chrome , Mac
Pri: 1
Type: Bug

Blocking:
issue 647498



Sign in to add a comment

a user clicking "Kill" on the hung renderer dialog should produce a crash report

Project Member Reported by wfh@chromium.org, Sep 23 2016

Issue description

Version: M53 stable, and M55 Canary
OS: All

What steps will reproduce the problem?
(1) Go to chrome://hang
(2) Wait until hang renderer dialog appears
(3) Click kill

What is the expected output?

Crash appears in chrome://crashes

What do you see instead?

No crash appears on Linux and Mac. Appears to work on Windows.

Please use labels and text to provide additional information.

See also issue 647498 and issue 646914
 

Comment 1 by olka@chromium.org, Oct 19 2016

Blocking: 647498

Comment 2 by olka@chromium.org, Oct 19 2016

Could this be addressed in any near future? We are missing a full picture on what's going on on Linux/Mac for Issue 647498
Cc: pinkerton@chromium.org
Labels: -OS-All OS-Chrome OS-Linux OS-Mac
cc:pinkerton for macOS prioritization. -windows since we know it works there.

Is this something the crash team is looking into? Not having hang reports at all or for non-Windows platforms seems like a worrying blind spot.
Cc: -pinkerton@chromium.org -erikc...@chromium.org shrike@chromium.org
replacing me with shrike@ for prioritization. 
Labels: M-60
Owner: sdy@chromium.org
Status: Assigned (was: Untriaged)
sdy@ - any thoughts on effort needed to get this working on the Mac side?

Comment 6 by mark@chromium.org, May 3 2017

What does the kill button do now, send SIGKILL? We can switch it to send one of these other signals.

https://chromium.googlesource.com/crashpad/crashpad/+/bf2c5155d28f4756a242ead9b6cac25d958e0a91/util/posix/signals.cc#27

Drawback: SIGKILL definitely kills, and these other signals can be caught and made to not kill. We could do something like “first click sends a core-generating signal, second click sends SIGKILL.” I think that this is what macOS’ command-option-escape killer does.

Other drawback: there are a limited number of signals to choose from. This isn’t such a big deal on macOS, because real crashes originating as hardware faults start out life as a Mach exception, and we record that and carry it all the way through with the crash report so that we can tell what they are. But on Linux, we’re stuck with signals, and a crash report for a process killed in the way I’m suggesting would be trickier to distinguish from one for which the kernel raised the signal in response to a hardware fault. It’s not impossible to distinguish, but I don’t know if Breakpad captures this information (Crashpad will) and I don’t think it’s surfaced anywhere on the crash server.

SIGQUIT is my choice for this (in large part because it’s not associated with any hardware cause).

Comment 7 by olka@chromium.org, Jun 27 2017

Hi! Are there any updates on this? thanks!

Comment 8 by olka@chromium.org, Aug 17 2017

Friendly ping
Owner: mark@chromium.org

Sign in to add a comment