Issue 649740 link

Starred by 2 users

Issue metadata

Status:	Verified
Owner:	█ yunlian@chromium.org Last visit > 30 days ago
Closed:	Oct 2016
EstimatedDays:	----
NextAction:	----
OS:	Chrome
Pri:	2
Type:	Bug
Build-Toolchain VerifyIn-55 VerifyIn-56 VerifyIn-57 VerifyIn-58

Blocking:
issue 537368

ccache: ccache trigers -Wparentheses-equality warning.

Project Member Reported by yunlian@chromium.org, Sep 23 2016

Issue description

https://uberchromegw.corp.google.com/i/chromiumos.tryserver/builders/release/builds/6318/steps/BuildPackages%20%5Bafdo_use%5D/logs/stdio


For this code
               if (IS_ERR(bht->hash_desc[cpu].tfm)) {
ccache expands to
        if ((bht->hash_desc[cpu].tfm == __null))

and this triggers a clang warning

/mnt/host/source/src/platform/verity/dm-bht.c:166:32: error: equality comparison with extraneous parentheses [-Werror,-Wparentheses-equality]
  if ((bht->hash_desc[cpu].tfm == __null)) {
       ~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~
/mnt/host/source/src/platform/verity/dm-bht.c:166:32: note: remove extraneous parentheses around the comparison to silence this warning
  if ((bht->hash_desc[cpu].tfm == __null)) {
      ~                        ^        ~

Comment 1 by yunlian@chromium.org, Sep 23 2016

This probably can be solved by setting an environment variable
CCACHE_CPP2=yes

http://petereisentraut.blogspot.com/2011/09/ccache-and-clang-part-2.html

Comment 2 by yunlian@chromium.org, Sep 26 2016

Blocking: 537368

Comment 3 by llozano@chromium.org, Sep 26 2016

Labels: -Pri-3 Pri-2

Project Member

Comment 4 by bugdroid1@chromium.org, Oct 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/848c6d5a63a7f49bc76918e6e44f315538c4ebfe

commit 848c6d5a63a7f49bc76918e6e44f315538c4ebfe
Author: Yunlian Jiang <yunlian@google.com>
Date: Fri Sep 23 17:13:36 2016

gcc: enable ccache for clang build

This enables ccache for clang. It also fixes a bug in the wrapper.
It also sets the environment variable 'CCACHE_CPP2' to 'yes' if
clang is used.

BUG= chromium:649740 
TEST=cbuildbot falco-release oak-release daisy-release --profile=llvm

Change-Id: I3720e0d8bc1f560afe7fce82ef0f790e3b3ef9eb
Reviewed-on: https://chromium-review.googlesource.com/386263
Commit-Ready: Yunlian Jiang <yunlian@chromium.org>
Tested-by: Yunlian Jiang <yunlian@chromium.org>
Reviewed-by: Luis Lozano <llozano@chromium.org>

[rename] https://crrev.com/848c6d5a63a7f49bc76918e6e44f315538c4ebfe/sys-devel/gcc/gcc-4.9.2-r141.ebuild
[modify] https://crrev.com/848c6d5a63a7f49bc76918e6e44f315538c4ebfe/sys-devel/gcc/files/sysroot_wrapper.hardened