Overlapped icons in shelf |
||||||
Issue descriptionThere is quite long bug in shelf view that may cause shelf icon wrong state after sync. Test to reproduce, pin 2 apps on device1, (in my case I use Files and chrome browser). Run device2 and make sure that pins are in the same order as on device1. Run first pinned app (Files in my case) and open Settings. Now you should have on device B App1(Pinned,Running) App2(Pinned), App3(). On device1 unpin first app (Files in my case) and wait sync on Device2. It is animation started on DeviceB and not completed. There is App1 in wrong position overlapping App2 at first position. Expected layout: App2(Pinned), App1(Running), App3().
,
Sep 28 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/57990fca3140d334ac17b2ba2c1412b5b51ee93d commit 57990fca3140d334ac17b2ba2c1412b5b51ee93d Author: khmel <khmel@chromium.org> Date: Wed Sep 28 19:54:33 2016 Fix possible overlapping icons in shelf on sync. This fixes overlapping icons in shelf on sync, refactored pin applying functionality. BUG= 649717 BUG=b/31632644 TEST=unit_tests TEST=Manually on device, no glitches with shelf icon were found. Review-Url: https://codereview.chromium.org/2364983002 Cr-Commit-Position: refs/heads/master@{#421613} [modify] https://crrev.com/57990fca3140d334ac17b2ba2c1412b5b51ee93d/ash/common/shelf/shelf_view.cc [modify] https://crrev.com/57990fca3140d334ac17b2ba2c1412b5b51ee93d/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.cc [modify] https://crrev.com/57990fca3140d334ac17b2ba2c1412b5b51ee93d/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.h [modify] https://crrev.com/57990fca3140d334ac17b2ba2c1412b5b51ee93d/chrome/browser/ui/ash/launcher/launcher_item_controller.h
,
Sep 28 2016
,
Sep 29 2016
Your change meets the bar and is auto-approved for M54 (branch: 2840)
,
Sep 30 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/04fe6ef58602696613bd677a388d2c52d1330197 commit 04fe6ef58602696613bd677a388d2c52d1330197 Author: khmel <khmel@chromium.org> Date: Fri Sep 30 15:36:51 2016 [Merge-M54] Fix possible overlapping icons in shelf on sync. This fixes overlapping icons in shelf on sync, refactored pin applying functionality. TBR=reviewer@chromium.org NOTRY=true NOPRESUBMIT=true BUG= 649717 BUG=b/31632644 TEST=unit_tests TEST=Manually on device, no glitches with shelf icon were found. Review-Url: https://codereview.chromium.org/2364983002 Review-Url: https://codereview.chromium.org/2385753002 Cr-Original-Commit-Position: refs/heads/master@{#421613} Cr-Commit-Position: refs/branch-heads/2840@{#599} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/04fe6ef58602696613bd677a388d2c52d1330197/ash/common/shelf/shelf_view.cc [modify] https://crrev.com/04fe6ef58602696613bd677a388d2c52d1330197/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.cc [modify] https://crrev.com/04fe6ef58602696613bd677a388d2c52d1330197/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.h [modify] https://crrev.com/04fe6ef58602696613bd677a388d2c52d1330197/chrome/browser/ui/ash/launcher/launcher_item_controller.h
,
Sep 30 2016
,
Oct 6 2016
Verified on 54.0.2840.51/8743.57.0
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/04fe6ef58602696613bd677a388d2c52d1330197 commit 04fe6ef58602696613bd677a388d2c52d1330197 Author: khmel <khmel@chromium.org> Date: Fri Sep 30 15:36:51 2016 [Merge-M54] Fix possible overlapping icons in shelf on sync. This fixes overlapping icons in shelf on sync, refactored pin applying functionality. TBR=reviewer@chromium.org NOTRY=true NOPRESUBMIT=true BUG= 649717 BUG=b/31632644 TEST=unit_tests TEST=Manually on device, no glitches with shelf icon were found. Review-Url: https://codereview.chromium.org/2364983002 Review-Url: https://codereview.chromium.org/2385753002 Cr-Original-Commit-Position: refs/heads/master@{#421613} Cr-Commit-Position: refs/branch-heads/2840@{#599} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/04fe6ef58602696613bd677a388d2c52d1330197/ash/common/shelf/shelf_view.cc [modify] https://crrev.com/04fe6ef58602696613bd677a388d2c52d1330197/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.cc [modify] https://crrev.com/04fe6ef58602696613bd677a388d2c52d1330197/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.h [modify] https://crrev.com/04fe6ef58602696613bd677a388d2c52d1330197/chrome/browser/ui/ash/launcher/launcher_item_controller.h |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by khmel@chromium.org
, Sep 23 2016