Issue metadata
Sign in to add a comment
|
GDI leak when hovering natively styled form elements
Reported by
rchlodni...@opera.com,
Sep 23 2016
|
||||||||||||||||||||
Issue descriptionVersion: 55.0.2869.0 canary (64-bit) OS: Windows 7 I'm not sure if/when Chrome uses native styling for form elements. At least we do at Opera and I found a leak in the code that would quite quickly make GDI count reach 10000 objects and crash renderer. This is reproducible when hovering form elements (checkboxes for example), but as I said, it only reproduces with native theme so normally doesn't reproduce in Chrome. Probably caused by https://codereview.chromium.org/2182083002 or some related fixes from the bug.
,
Sep 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4014935dc5f26ad7517ca8427425995bd67d6c85 commit 4014935dc5f26ad7517ca8427425995bd67d6c85 Author: rchlodnicki <rchlodnicki@opera.com> Date: Tue Sep 27 07:53:58 2016 Fix GDI leak in NativeThemeWin::PaintIndirect There was a GDI leak when hovering input elements. Reaching 10000 GDI objects would cause process to crash. Fixed by deleting HBITMAP that was selected onto the HDC. Deleting HDC does not take care of that. The skia utility function was removed and replaced with a custom scoped object at call site as it was used only in one place and making it safe to use for others would be a bit tricky as bitmap needs to be deleted before HDC and there is no easy access to the bitmap after utility function returns HDC. R=pkasting@chromium.org,fmalita@chromium.org,tomhudson@google.com BUG= 649712 Review-Url: https://codereview.chromium.org/2365903002 Cr-Commit-Position: refs/heads/master@{#421142} [modify] https://crrev.com/4014935dc5f26ad7517ca8427425995bd67d6c85/skia/ext/skia_utils_win.cc [modify] https://crrev.com/4014935dc5f26ad7517ca8427425995bd67d6c85/skia/ext/skia_utils_win.h [modify] https://crrev.com/4014935dc5f26ad7517ca8427425995bd67d6c85/ui/native_theme/native_theme_win.cc
,
Sep 27 2016
|
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by rchlodni...@opera.com
, Sep 23 2016