New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 649711 link

Starred by 2 users
Status: Fixed
Owner:
petewil@chromium.org
Closed: Jan 2017
Cc:
█ dim...@chromium.org
dougarnett@chromium.org
petewil@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

[Offline Pages] Improve SnapshotController's right moment detection for better capture on 2G/3G networks

Project Member Reported by dougarnett@chromium.org, Sep 23 2016 
From manual evaluations of top EM visited sites it seems that we may be capturing background loaded snapshots too soon. 

Ideally, we would use better signals from WebKit. Perhaps the FirstMeaningfulPaint signal can help. We might also consider increasing
the time delays after DomContentLoaded and OnLoadCompleted in the
very near term.

Comment 1 by dougarnett@chromium.org, Sep 23 2016

Cc: dim...@chromium.org
Looking at a few EM urls that captured poor snapshots in manual evaluations.
On GIN-2g see this time difference between the DomContentLoaded and OnLoadCompleted:

  http://vagalume.com.br/      30.5 secs
  http://lancenet.com.br/      13 secs
  http://detik.com/            11.5 secs
  https://www.onlinesbi.com/   39 secs
  http://amazon.in/            37.5 secs

Btw, content was much much better waiting for the OnLoadCompleted for these sites. Hopefully FirstMeaningfulPaint could help in these long gaps.

Comment 2 by dewittj@chromium.org, Sep 23 2016 

(triage) Needs design doc/discussion

Comment 3 by dougarnett@chromium.org, Sep 29 2016

Cc: dougarnett@chromium.org
Owner: petewil@chromium.org
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 25 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f13a8e04f192b954e9ce8a301e25dd8ef250dd84

commit f13a8e04f192b954e9ce8a301e25dd8ef250dd84
Author: petewil <petewil@chromium.org>
Date: Tue Oct 25 23:44:10 2016

Skip the OnDomContentLoaded event, and only use the OnLoad event.

In an attempt to improve the right moment detection, we will
no longer take snapshots of the (earlier) OnDomContentLoaded event,
and instead wait later for the OnLoad event.

BUG= 649711 

Review-Url: https://codereview.chromium.org/2420693002
Cr-Commit-Position: refs/heads/master@{#427537}

[modify] https://crrev.com/f13a8e04f192b954e9ce8a301e25dd8ef250dd84/chrome/browser/android/offline_pages/prerendering_loader.cc

Comment 6 by petewil@chromium.org, Oct 26 2016

Labels: Merge-Request-55

Comment 7 by dimu@chromium.org, Oct 26 2016

Labels: -Merge-Request-55 Merge-Approved-55 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M55 (branch: 2883)

Comment 8 by petewil@chromium.org, Oct 26 2016

Labels: -Hotlist-Merge-Approved -Merge-Approved-55
After some discussion, we decided to not push for putting this in M55 after all, so I have removed the M-55 merge tags.

Comment 9 by petewil@chromium.org, Jan 26 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment