Issue metadata
Sign in to add a comment
|
"same member name (loopfilter_sse2.o) in output file used for input files" warning back with macOS 10.12 SDK |
||||||||||||||||||||||||
Issue descriptionAccording to thakis@, this should be filtered out by our libtool wrapper: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/libtool: warning same member name (loopfilter_sse2.o) in output file used for input files: obj/third_party/libvpx/libvpx_intrinsics_sse2/loopfilter_sse2.o and: obj/third_party/libvpx/libvpx_yasm/loopfilter_sse2.o (due to use of basename, truncation, blank padding or duplicate input files)
,
Sep 23 2016
Actually, that looks like a legit warning. fbarchard, is it expected that libvpx/libvpx_intrinsics_sse2/loopfilter_sse2.o and libvpx/libvpx_yasm/loopfilter_sse2.o both get linked in to the same binary? Probably not?
,
Sep 23 2016
Looks like a legit bug, but I dont work on vpx directly. James?
,
Sep 23 2016
One is from vp8 and the other from vp9 (via vpx_dsp), the intrinsics file should be renamed. There's a duplicate basename check in the generator script, but it's only looking at .c files. Maybe it assumed .asm's would end up with a unique suffix, Johann?
,
Sep 23 2016
Apparently this came up before in #628661. Renaming the file is OK, not sure if gn should retain the file suffix to help avoid cases like this elsewhere.
,
Sep 23 2016
oops, bad use of linkification -> crbug.com/628661 .
,
Sep 23 2016
Turns out this warning is printed a brazilion times, so we need to just filter it out. If it's expected that these 2 specific files are both in the build, then just ignore this. Looked unexpected to me, but apparently my intuition was wrong.
,
Sep 23 2016
All right, if you want to handle it that way we can leave it as is. Thanks for the update.
,
Sep 27 2016
Issue 650862 has been merged into this issue.
,
Oct 5 2016
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by thakis@chromium.org
, Sep 23 2016