New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 649698 link

Starred by 4 users

Issue metadata

Status: Duplicate
Merged: issue 628661
Owner: ----
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug-Regression



Sign in to add a comment

"same member name (loopfilter_sse2.o) in output file used for input files" warning back with macOS 10.12 SDK

Project Member Reported by sdy@chromium.org, Sep 23 2016

Issue description

According to thakis@, this should be filtered out by our libtool wrapper:

/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/libtool: warning same member name (loopfilter_sse2.o) in output file used for input files: obj/third_party/libvpx/libvpx_intrinsics_sse2/loopfilter_sse2.o and: obj/third_party/libvpx/libvpx_yasm/loopfilter_sse2.o (due to use of basename, truncation, blank padding or duplicate input files)
 

Comment 1 by thakis@chromium.org, Sep 23 2016

src/build/toolchain/mac/filter_libtool.py is apparently what does this nowadays (in the gn world)

Comment 2 by thakis@chromium.org, Sep 23 2016

Cc: fbarchard@chromium.org
Actually, that looks like a legit warning. fbarchard, is it expected that libvpx/libvpx_intrinsics_sse2/loopfilter_sse2.o and libvpx/libvpx_yasm/loopfilter_sse2.o both get linked in to the same binary? Probably not?
Cc: jzern@chromium.org
Looks like a legit bug, but I dont work on vpx directly.  James?

Comment 4 by jzern@chromium.org, Sep 23 2016

Cc: johannkoenig@chromium.org
One is from vp8 and the other from vp9 (via vpx_dsp), the intrinsics file should be renamed. There's a duplicate basename check in the generator script, but it's only looking at .c files. Maybe it assumed .asm's would end up with a unique suffix, Johann?

Comment 5 by jzern@chromium.org, Sep 23 2016

Apparently this came up before in #628661. Renaming the file is OK, not sure if gn should retain the file suffix to help avoid cases like this elsewhere.

Comment 6 by jzern@chromium.org, Sep 23 2016

oops, bad use of linkification ->  crbug.com/628661 .

Comment 7 by thakis@chromium.org, Sep 23 2016

Turns out this warning is printed a brazilion times, so we need to just filter it out.  If it's expected that these 2 specific files are both in the build, then just ignore this.  Looked unexpected to me, but apparently my intuition was wrong.

Comment 8 by jzern@chromium.org, Sep 23 2016

All right, if you want to handle it that way we can leave it as is. Thanks for the update.
 Issue 650862  has been merged into this issue.
Mergedinto: 628661
Status: Duplicate (was: Untriaged)

Sign in to add a comment