update-w3c-test-expectations invokes rebaseline-cl with non-existent tests. |
||||
Issue descriptionExample build: https://build.chromium.org/p/chromium.infra.cron/builders/w3c-test-autoroller/builds/7716 There are two potential little fixes here: (1) webkit-patch rebaseline-cl should handle the case where it's passed a test that doesn't exist. (2) update-w3c-test-expectations shouldn't need to explicitly pass a list of tests.
,
Sep 28 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/76d0c6c9d29209f0d205af6bf9ded17ee217fcc1 commit 76d0c6c9d29209f0d205af6bf9ded17ee217fcc1 Author: qyearsley <qyearsley@chromium.org> Date: Tue Sep 27 20:48:02 2016 In webkitpy-patch rebaseline-cl, don't try to rebaseline non-existent tests. BUG= 649691 Review-Url: https://codereview.chromium.org/2371803003 Cr-Commit-Position: refs/heads/master@{#421325} [modify] https://crrev.com/76d0c6c9d29209f0d205af6bf9ded17ee217fcc1/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl.py [modify] https://crrev.com/76d0c6c9d29209f0d205af6bf9ded17ee217fcc1/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl_unittest.py
,
Oct 5 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c4e50671c1d6124c8cc4b315f9308a365da79df4 commit c4e50671c1d6124c8cc4b315f9308a365da79df4 Author: qyearsley <qyearsley@chromium.org> Date: Wed Oct 05 18:26:27 2016 Change update-w3c-test-expectations to only rebaseline existing tests. In this CL: - Extract a method get_modified_existing_tests which outputs warnings for tests that don't exist. - In get_modified_existing_tests, when invoking git diff, add --diff-filter so that tests that don't exist shouldn't be gotten in the first place. - Update tests and expand test coverage. BUG= 649691 Review-Url: https://codereview.chromium.org/2389873002 Cr-Commit-Position: refs/heads/master@{#423227} [modify] https://crrev.com/c4e50671c1d6124c8cc4b315f9308a365da79df4/third_party/WebKit/Tools/Scripts/webkitpy/w3c/update_w3c_test_expectations.py [modify] https://crrev.com/c4e50671c1d6124c8cc4b315f9308a365da79df4/third_party/WebKit/Tools/Scripts/webkitpy/w3c/update_w3c_test_expectations_unittest.py
,
Oct 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0d2ce5afae26790b0d859a9b40dce06d6811821c commit 0d2ce5afae26790b0d859a9b40dce06d6811821c Author: qyearsley <qyearsley@chromium.org> Date: Fri Oct 07 17:15:27 2016 Fix command line argument passed to git diff in update-w3c-test-expectations. This is a follow-up fix for http://crrev.com/2389873002. BUG= 649691 Review-Url: https://codereview.chromium.org/2401973002 Cr-Commit-Position: refs/heads/master@{#423893} [modify] https://crrev.com/0d2ce5afae26790b0d859a9b40dce06d6811821c/third_party/WebKit/Tools/Scripts/webkitpy/w3c/update_w3c_test_expectations.py [modify] https://crrev.com/0d2ce5afae26790b0d859a9b40dce06d6811821c/third_party/WebKit/Tools/Scripts/webkitpy/w3c/update_w3c_test_expectations_unittest.py
,
Oct 7 2016
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c4e50671c1d6124c8cc4b315f9308a365da79df4 commit c4e50671c1d6124c8cc4b315f9308a365da79df4 Author: qyearsley <qyearsley@chromium.org> Date: Wed Oct 05 18:26:27 2016 Change update-w3c-test-expectations to only rebaseline existing tests. In this CL: - Extract a method get_modified_existing_tests which outputs warnings for tests that don't exist. - In get_modified_existing_tests, when invoking git diff, add --diff-filter so that tests that don't exist shouldn't be gotten in the first place. - Update tests and expand test coverage. BUG= 649691 Review-Url: https://codereview.chromium.org/2389873002 Cr-Commit-Position: refs/heads/master@{#423227} [modify] https://crrev.com/c4e50671c1d6124c8cc4b315f9308a365da79df4/third_party/WebKit/Tools/Scripts/webkitpy/w3c/update_w3c_test_expectations.py [modify] https://crrev.com/c4e50671c1d6124c8cc4b315f9308a365da79df4/third_party/WebKit/Tools/Scripts/webkitpy/w3c/update_w3c_test_expectations_unittest.py
,
Nov 4 2016
[Automated comment] removing mislabelled merge-merged-2840
,
Nov 16 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/daf1ddbd71f55b0765611a7273c74860dbd3d6b2 commit daf1ddbd71f55b0765611a7273c74860dbd3d6b2 Author: qyearsley <qyearsley@chromium.org> Date: Wed Nov 16 17:52:02 2016 In rebaseline-cl, don't check for local file existence. I originally added filtering of tests to only include files that exist locally in http://crrev.com/2371803003. But now, it seems clearer that this was the wrong choice, since: 1. Virtual tests don't exist on the local file system 2. When --issue is passed (when downloading baselines for try jobs on another CL), the files don't exist locally. In order to stop checking for file existence, another little issue needed to be solved, which was that when getting the list of files that were changed, the list included deleted files, which we don't want to rebaseline; so this CL also fixes that. BUG= 663411 , 656154 , 649691 Review-Url: https://codereview.chromium.org/2507613002 Cr-Commit-Position: refs/heads/master@{#432548} [modify] https://crrev.com/daf1ddbd71f55b0765611a7273c74860dbd3d6b2/third_party/WebKit/Tools/Scripts/webkitpy/common/net/rietveld.py [modify] https://crrev.com/daf1ddbd71f55b0765611a7273c74860dbd3d6b2/third_party/WebKit/Tools/Scripts/webkitpy/common/net/rietveld_unittest.py [modify] https://crrev.com/daf1ddbd71f55b0765611a7273c74860dbd3d6b2/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl.py [modify] https://crrev.com/daf1ddbd71f55b0765611a7273c74860dbd3d6b2/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl_unittest.py |
||||
►
Sign in to add a comment |
||||
Comment 1 by qyears...@chromium.org
, Sep 26 2016Status: Assigned (was: Available)