New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 649682 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug



Sign in to add a comment

EV SSL UI missing from EV sites

Project Member Reported by ellyjo...@chromium.org, Sep 23 2016

Issue description

Known bad version: 55.0.2869.0 (current canary)
Known good version: 55.0.2859.0 (current dev)
OS version: macOS 10.12.1 16B2327e

When navigating to an EV SSL site (I used https://www.paypal.com), no EV UI is shown. Marking Security>UX for triage.
 
Components: Internals>Network>Certificate
Tagging it certificate for awareness, but it does seem that from the //net layer, we're surfacing this as EV qualifying (and complying via SCTs). Checked via NetLog
Tighter regression range: 55.0.2867.0 is known good.
Cc: spqc...@chromium.org emilyschechter@chromium.org shrike@chromium.org
+Sarah and Jayson who may be able to tell what changed.

Comment 5 by shrike@chromium.org, Sep 23 2016

Cc: -spqc...@chromium.org
Labels: -Pri-2 M-55 Pri-1
Owner: spqc...@chromium.org
Status: Assigned (was: Untriaged)
Probably a result of putting the verbose state code behind a flag.

Bingo. I'll change it so that the default case will not hide the EV cert
How is fixing this going?

Comment 8 by shrike@chromium.org, Sep 30 2016

Labels: ReleaseBlock-Beta
Status: Started (was: Assigned)
It's on the way, I'm putting the fix in the same CL as the "Show all with only nonsecure animated" flag change.

Comment 10 by ajha@chromium.org, Oct 3 2016

If possible, please get the fix landed before M-55 branch(probable date: Oct 6th).
A friendly reminder that M55 Beta launch is coming soon! Your bug is labelled as Beta ReleaseBlock, pls make sure to land the fix ASAP. Thank you.
Project Member

Comment 13 by bugdroid1@chromium.org, Oct 5 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8434b579f8ececab58243e97b1ab758b671cccd0

commit 8434b579f8ececab58243e97b1ab758b671cccd0
Author: spqchan <spqchan@chromium.org>
Date: Wed Oct 05 21:24:37 2016

[Material][Mac] Change the default value of material-security-verbose

Change it so that it'll match the current default value for Views, which
is "Show all, animated"

BUG= 649682 

Review-Url: https://codereview.chromium.org/2394793003
Cr-Commit-Position: refs/heads/master@{#423298}

[modify] https://crrev.com/8434b579f8ececab58243e97b1ab758b671cccd0/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm

Labels: -ReleaseBlock-Beta
Status: Fixed (was: Started)
Status: Started (was: Fixed)
Hi spqchan@,

Did you confirm your change on a continuous build? We should not mark it as fixed and -RBB until we know that the change is working as intended in the Canary (or at least the continuous build).
Labels: ReleaseBlock-Beta
Whoops, I accidentally removed the ReleaseBlock

It's not up on Canary yet. Sounds good, I'll wait until it's available
In latest Canary I noticed, that only the first secure tab has an animation. When you open a second tab and visit also a secure page the animation does not appear. Is this intended?

A screencast is attached.
animation.mov
227 KB Download
That's a different bug
What is the bug number for that bug?

653602

Most likely caused by a refactor from a few weeks ago.
The verbose is supposed to animate in if it has been animated out/hidden and is now shwon. For some reason it's not so some variable might not be updated properly. I will look into this once I have the time


**** Bulk edit -  please ignore if not applicable ****

This bug  is reported as M55 Beta blocker and we're getting closer to M55 Beta promotion. 
Please plan to have fix ready and merged to M55 branch (2883) by 5:00 PM PT, Monday(10/10) so it has enough baking time in Dev before Beta promotion. Thank you.
Status: Fixed (was: Started)
Project Member

Comment 23 by bugdroid1@chromium.org, Oct 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d52dccd7192814d740a8bae50fcd32eb00816ce4

commit d52dccd7192814d740a8bae50fcd32eb00816ce4
Author: spqchan <spqchan@chromium.org>
Date: Thu Oct 13 00:15:40 2016

[Material] Update Material Security Verbose Decoration Flag

- Removed "Material" from the flag's name
- Added the option "Show all, only animate nonsecure"
- Set the default flag value to "Show all, non-animated"

BUG= 651991 ,  649682 

Review-Url: https://codereview.chromium.org/2378623007
Cr-Commit-Position: refs/heads/master@{#424917}

[modify] https://crrev.com/d52dccd7192814d740a8bae50fcd32eb00816ce4/chrome/app/generated_resources.grd
[modify] https://crrev.com/d52dccd7192814d740a8bae50fcd32eb00816ce4/chrome/browser/about_flags.cc
[modify] https://crrev.com/d52dccd7192814d740a8bae50fcd32eb00816ce4/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h
[modify] https://crrev.com/d52dccd7192814d740a8bae50fcd32eb00816ce4/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm
[modify] https://crrev.com/d52dccd7192814d740a8bae50fcd32eb00816ce4/chrome/browser/ui/views/location_bar/location_bar_view.cc
[modify] https://crrev.com/d52dccd7192814d740a8bae50fcd32eb00816ce4/chrome/browser/ui/views/location_bar/location_bar_view.h
[modify] https://crrev.com/d52dccd7192814d740a8bae50fcd32eb00816ce4/chrome/common/chrome_switches.cc
[modify] https://crrev.com/d52dccd7192814d740a8bae50fcd32eb00816ce4/chrome/common/chrome_switches.h
[modify] https://crrev.com/d52dccd7192814d740a8bae50fcd32eb00816ce4/tools/metrics/histograms/histograms.xml

Project Member

Comment 24 by bugdroid1@chromium.org, Oct 27 2016

Labels: merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8434b579f8ececab58243e97b1ab758b671cccd0

commit 8434b579f8ececab58243e97b1ab758b671cccd0
Author: spqchan <spqchan@chromium.org>
Date: Wed Oct 05 21:24:37 2016

[Material][Mac] Change the default value of material-security-verbose

Change it so that it'll match the current default value for Views, which
is "Show all, animated"

BUG= 649682 

Review-Url: https://codereview.chromium.org/2394793003
Cr-Commit-Position: refs/heads/master@{#423298}

[modify] https://crrev.com/8434b579f8ececab58243e97b1ab758b671cccd0/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm

Comment 25 by dimu@google.com, Nov 4 2016

Labels: -merge-merged-2840
[Automated comment] removing mislabelled merge-merged-2840
Components: -Security>UX
Labels: Team-Security-UX
Security>UX component is deprecated in favor of the Team-Security-UX label

Sign in to add a comment