EV SSL UI missing from EV sites |
||||||||||||
Issue descriptionKnown bad version: 55.0.2869.0 (current canary) Known good version: 55.0.2859.0 (current dev) OS version: macOS 10.12.1 16B2327e When navigating to an EV SSL site (I used https://www.paypal.com), no EV UI is shown. Marking Security>UX for triage.
,
Sep 23 2016
Tagging it certificate for awareness, but it does seem that from the //net layer, we're surfacing this as EV qualifying (and complying via SCTs). Checked via NetLog
,
Sep 23 2016
Tighter regression range: 55.0.2867.0 is known good.
,
Sep 23 2016
+Sarah and Jayson who may be able to tell what changed.
,
Sep 23 2016
Probably a result of putting the verbose state code behind a flag.
,
Sep 23 2016
Bingo. I'll change it so that the default case will not hide the EV cert
,
Sep 30 2016
How is fixing this going?
,
Sep 30 2016
,
Sep 30 2016
It's on the way, I'm putting the fix in the same CL as the "Show all with only nonsecure animated" flag change.
,
Oct 3 2016
If possible, please get the fix landed before M-55 branch(probable date: Oct 6th).
,
Oct 4 2016
A friendly reminder that M55 Beta launch is coming soon! Your bug is labelled as Beta ReleaseBlock, pls make sure to land the fix ASAP. Thank you.
,
Oct 5 2016
CL in progress: https://codereview.chromium.org/2378623007/
,
Oct 5 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8434b579f8ececab58243e97b1ab758b671cccd0 commit 8434b579f8ececab58243e97b1ab758b671cccd0 Author: spqchan <spqchan@chromium.org> Date: Wed Oct 05 21:24:37 2016 [Material][Mac] Change the default value of material-security-verbose Change it so that it'll match the current default value for Views, which is "Show all, animated" BUG= 649682 Review-Url: https://codereview.chromium.org/2394793003 Cr-Commit-Position: refs/heads/master@{#423298} [modify] https://crrev.com/8434b579f8ececab58243e97b1ab758b671cccd0/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm
,
Oct 5 2016
,
Oct 5 2016
Hi spqchan@, Did you confirm your change on a continuous build? We should not mark it as fixed and -RBB until we know that the change is working as intended in the Canary (or at least the continuous build).
,
Oct 5 2016
Whoops, I accidentally removed the ReleaseBlock It's not up on Canary yet. Sounds good, I'll wait until it's available
,
Oct 6 2016
In latest Canary I noticed, that only the first secure tab has an animation. When you open a second tab and visit also a secure page the animation does not appear. Is this intended? A screencast is attached.
,
Oct 6 2016
That's a different bug
,
Oct 6 2016
What is the bug number for that bug?
,
Oct 6 2016
653602 Most likely caused by a refactor from a few weeks ago. The verbose is supposed to animate in if it has been animated out/hidden and is now shwon. For some reason it's not so some variable might not be updated properly. I will look into this once I have the time
,
Oct 7 2016
**** Bulk edit - please ignore if not applicable **** This bug is reported as M55 Beta blocker and we're getting closer to M55 Beta promotion. Please plan to have fix ready and merged to M55 branch (2883) by 5:00 PM PT, Monday(10/10) so it has enough baking time in Dev before Beta promotion. Thank you.
,
Oct 10 2016
,
Oct 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d52dccd7192814d740a8bae50fcd32eb00816ce4 commit d52dccd7192814d740a8bae50fcd32eb00816ce4 Author: spqchan <spqchan@chromium.org> Date: Thu Oct 13 00:15:40 2016 [Material] Update Material Security Verbose Decoration Flag - Removed "Material" from the flag's name - Added the option "Show all, only animate nonsecure" - Set the default flag value to "Show all, non-animated" BUG= 651991 , 649682 Review-Url: https://codereview.chromium.org/2378623007 Cr-Commit-Position: refs/heads/master@{#424917} [modify] https://crrev.com/d52dccd7192814d740a8bae50fcd32eb00816ce4/chrome/app/generated_resources.grd [modify] https://crrev.com/d52dccd7192814d740a8bae50fcd32eb00816ce4/chrome/browser/about_flags.cc [modify] https://crrev.com/d52dccd7192814d740a8bae50fcd32eb00816ce4/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h [modify] https://crrev.com/d52dccd7192814d740a8bae50fcd32eb00816ce4/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm [modify] https://crrev.com/d52dccd7192814d740a8bae50fcd32eb00816ce4/chrome/browser/ui/views/location_bar/location_bar_view.cc [modify] https://crrev.com/d52dccd7192814d740a8bae50fcd32eb00816ce4/chrome/browser/ui/views/location_bar/location_bar_view.h [modify] https://crrev.com/d52dccd7192814d740a8bae50fcd32eb00816ce4/chrome/common/chrome_switches.cc [modify] https://crrev.com/d52dccd7192814d740a8bae50fcd32eb00816ce4/chrome/common/chrome_switches.h [modify] https://crrev.com/d52dccd7192814d740a8bae50fcd32eb00816ce4/tools/metrics/histograms/histograms.xml
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8434b579f8ececab58243e97b1ab758b671cccd0 commit 8434b579f8ececab58243e97b1ab758b671cccd0 Author: spqchan <spqchan@chromium.org> Date: Wed Oct 05 21:24:37 2016 [Material][Mac] Change the default value of material-security-verbose Change it so that it'll match the current default value for Views, which is "Show all, animated" BUG= 649682 Review-Url: https://codereview.chromium.org/2394793003 Cr-Commit-Position: refs/heads/master@{#423298} [modify] https://crrev.com/8434b579f8ececab58243e97b1ab758b671cccd0/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm
,
Nov 4 2016
[Automated comment] removing mislabelled merge-merged-2840
,
Dec 9 2016
Security>UX component is deprecated in favor of the Team-Security-UX label |
||||||||||||
►
Sign in to add a comment |
||||||||||||
Comment 1 by rsleevi@chromium.org
, Sep 23 2016