New issue
Advanced search Search tips

Issue 649671 link

Starred by 3 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

explore use of specialized types to detect DIP vs DDP bugs

Project Member Reported by rjkroege@chromium.org, Sep 23 2016

Issue description

In the display management and ui code, pixel coordinates are sometimes in DIP or DDP units. Computations are done to convert between these and further, values must be rounded in various places so that float pixel coordinates end up being exact DDP when drawing or pointer positioning.

Explore adding some kind of trait for classes such gfx::Size that require explicit conversion between DDP, DIP and rounded DDP and DIP to improve readability and make it easier to not introduce subtle rounding bugs (i.e. leaving 1 DDP thick artifacts.)



 

Comment 1 by enne@chromium.org, Jan 25 2017

Components: -Internals>Graphics Internals>Compositing
Labels: -Type-Bug Type-Feature

Comment 2 by enne@chromium.org, Jan 30 2017

Status: Available (was: Untriaged)
Components: UI>HighDPI
Labels: Proj-Mustash Proj-Ozone
Project Member

Comment 4 by sheriffbot@chromium.org, Feb 21 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 5 by piman@chromium.org, Feb 26 2018

Labels: -Hotlist-Recharge-Cold
Status: Available (was: Untriaged)
Are we still thinking of doing this?
The fact that we haven't done it keeps resulting in bugs that take developer time. But obviously this change would itself consume a lot of developer time. It's not obvious to me how to estimate and compare the two time costs. I'd welcome opinions on how to measure and compare the costs.
Components: UI>Aura Internals>Views
Labels: -Proj-Mustash

Sign in to add a comment