When and how to show the sign in promo |
||||||||||||||||||
Issue descriptionCurrently, we use the signin state for two things: A) When fetching article suggestions, we pull the signin state and make a signed in request if possible B) When the user signs out, we clear the currently loaded article suggestions, for privacy reasons. We want to let the users know that they can sign in to get better content via A), but currently we never show the signin promo because: - We remove the whole section when clearing snippets (by returning CATEGORY_EXPLICITLY_DISABLED, see crrev.com/2289303006). We could have shown this card there instead. - After that we just stay in the regular AVAILABLE/AVAILABLE_LOADING states to be able to normally show suggestions. This surfaces the issue with how we report state: a section can currently show only one status card at a time. TBD: - When do we show the signin promo? - How does that interact with the content suggestions and the reload button there? - What happens when we dismiss that promo?
,
Sep 23 2016
I much prefer 1. as well: From a technical perspective, because the "category status" is too many things already, we shouldn't add an "AVAILABLE_BUT_SIGNED_OUT" state. And also from a product perspective it seems better to me. If we absolutely have to go with the current PRD (where IIRC the signin promo card shows up only if there are no suggestions), then maybe that card should just be a special case in the UI? That's what it'll be essentially anyway, no point in piping that special case through the whole backend.
,
Sep 27 2016
,
Sep 27 2016
,
Sep 27 2016
,
Sep 28 2016
Approved UI: - Sign in promo shown at the end of the first server-side section (currently: Articles for you) - The card does not come with its own section title, - The card is slightly disconnected from the Articles for you section - Its background color is the previously defined status card background color - Swiping it removes it forever. We don't re-prompt users to sign-in and instead rely on other Chrome-wide sign-in prompts
,
Sep 28 2016
This UI is not approved. :)
,
Sep 28 2016
9patch for testing implementation
,
Oct 3 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fa61ae72913bae84fa7e5fdc0ca6fb4092c858b0 commit fa61ae72913bae84fa7e5fdc0ca6fb4092c858b0 Author: dgn <dgn@chromium.org> Date: Mon Oct 03 18:30:12 2016 [NTP Client] Show the Sign In promo as a separate card from the section BUG= 649670 Review-Url: https://codereview.chromium.org/2378323002 Cr-Commit-Position: refs/heads/master@{#422464} [add] https://crrev.com/fa61ae72913bae84fa7e5fdc0ca6fb4092c858b0/chrome/android/java/res/drawable-hdpi/ntp_signin_promo_card_bottom.9.png [add] https://crrev.com/fa61ae72913bae84fa7e5fdc0ca6fb4092c858b0/chrome/android/java/res/drawable-hdpi/ntp_signin_promo_card_single.9.png [add] https://crrev.com/fa61ae72913bae84fa7e5fdc0ca6fb4092c858b0/chrome/android/java/res/drawable-mdpi/ntp_signin_promo_card_bottom.9.png [add] https://crrev.com/fa61ae72913bae84fa7e5fdc0ca6fb4092c858b0/chrome/android/java/res/drawable-mdpi/ntp_signin_promo_card_single.9.png [add] https://crrev.com/fa61ae72913bae84fa7e5fdc0ca6fb4092c858b0/chrome/android/java/res/drawable-xhdpi/ntp_signin_promo_card_bottom.9.png [add] https://crrev.com/fa61ae72913bae84fa7e5fdc0ca6fb4092c858b0/chrome/android/java/res/drawable-xhdpi/ntp_signin_promo_card_single.9.png [add] https://crrev.com/fa61ae72913bae84fa7e5fdc0ca6fb4092c858b0/chrome/android/java/res/drawable-xxhdpi/ntp_signin_promo_card_bottom.9.png [add] https://crrev.com/fa61ae72913bae84fa7e5fdc0ca6fb4092c858b0/chrome/android/java/res/drawable-xxhdpi/ntp_signin_promo_card_single.9.png [add] https://crrev.com/fa61ae72913bae84fa7e5fdc0ca6fb4092c858b0/chrome/android/java/res/drawable-xxxhdpi/ntp_signin_promo_card_bottom.9.png [add] https://crrev.com/fa61ae72913bae84fa7e5fdc0ca6fb4092c858b0/chrome/android/java/res/drawable-xxxhdpi/ntp_signin_promo_card_single.9.png [modify] https://crrev.com/fa61ae72913bae84fa7e5fdc0ca6fb4092c858b0/chrome/android/java/res/values/dimens.xml [modify] https://crrev.com/fa61ae72913bae84fa7e5fdc0ca6fb4092c858b0/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java [modify] https://crrev.com/fa61ae72913bae84fa7e5fdc0ca6fb4092c858b0/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java [modify] https://crrev.com/fa61ae72913bae84fa7e5fdc0ca6fb4092c858b0/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardViewHolder.java [modify] https://crrev.com/fa61ae72913bae84fa7e5fdc0ca6fb4092c858b0/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java [modify] https://crrev.com/fa61ae72913bae84fa7e5fdc0ca6fb4092c858b0/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageItem.java [add] https://crrev.com/fa61ae72913bae84fa7e5fdc0ca6fb4092c858b0/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SigninPromoItem.java [add] https://crrev.com/fa61ae72913bae84fa7e5fdc0ca6fb4092c858b0/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/StatusCardViewHolder.java [modify] https://crrev.com/fa61ae72913bae84fa7e5fdc0ca6fb4092c858b0/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/StatusItem.java [modify] https://crrev.com/fa61ae72913bae84fa7e5fdc0ca6fb4092c858b0/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticle.java [modify] https://crrev.com/fa61ae72913bae84fa7e5fdc0ca6fb4092c858b0/chrome/android/java/src/org/chromium/chrome/browser/preferences/ChromePreferenceManager.java [modify] https://crrev.com/fa61ae72913bae84fa7e5fdc0ca6fb4092c858b0/chrome/android/java/src/org/chromium/chrome/browser/signin/SigninManager.java [modify] https://crrev.com/fa61ae72913bae84fa7e5fdc0ca6fb4092c858b0/chrome/android/java_sources.gni [modify] https://crrev.com/fa61ae72913bae84fa7e5fdc0ca6fb4092c858b0/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/snippets/ArticleSnippetsTest.java [modify] https://crrev.com/fa61ae72913bae84fa7e5fdc0ca6fb4092c858b0/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java [modify] https://crrev.com/fa61ae72913bae84fa7e5fdc0ca6fb4092c858b0/components/ntp_snippets/remote/ntp_snippets_service.cc [modify] https://crrev.com/fa61ae72913bae84fa7e5fdc0ca6fb4092c858b0/components/ntp_snippets/remote/ntp_snippets_status_service.cc [modify] https://crrev.com/fa61ae72913bae84fa7e5fdc0ca6fb4092c858b0/components/ntp_snippets/remote/ntp_snippets_status_service.h
,
Oct 4 2016
Feedback from rachelis@: It's strange to have the empty state and the sign in state directly beside each other. => Keep about 20dp of space between the two when there are no articles in the section +mock
,
Oct 5 2016
More clarification: - the sign-in promo card can be dismissed - Let's put the sign-in promo card at the end of the feed (in M55 this is no effective change to our previous plans, because Articles for you is the last section. It will become apparent once we launch a second server-side section). - the promo card is not bound to a section (i.e. it is still visible if the section above it is removed, unless:) - the sign-in promo card cannot remain the last visible card - we remove it if it becomes the last card - Making the sign-in promo invisible != discarding the card, i.e. until the user discards the sign-in promo it will come back once content is available again on future NTPs. TBD: We need to decide on the the right kind of transition to use for the sign-in promo becoming invisible
,
Oct 6 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ffa8e3905fed0b1df0d56ab6e4b17791b31cd171 commit ffa8e3905fed0b1df0d56ab6e4b17791b31cd171 Author: dgn <dgn@chromium.org> Date: Thu Oct 06 14:13:23 2016 [NTP Client] Use the separate button style for the NoArticles status Makes the articles and bookmarks sections use the same style of status card when they have no snippets. the hasMoreButton property of categories now only determines whether the action item will be shown when there are suggestions to display. This patch also lets the SuggestionsCategoryInfo be aware of the current category it is describing, and moves various category specific behaviours into the SuggestionsCategoryInfo class. Preview: https://goo.gl/photos/VhceT6cjvME6QS8m7 BUG= 649670 Review-Url: https://codereview.chromium.org/2392943002 Cr-Commit-Position: refs/heads/master@{#423517} [modify] https://crrev.com/ffa8e3905fed0b1df0d56ab6e4b17791b31cd171/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ActionItem.java [modify] https://crrev.com/ffa8e3905fed0b1df0d56ab6e4b17791b31cd171/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java [modify] https://crrev.com/ffa8e3905fed0b1df0d56ab6e4b17791b31cd171/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/StatusItem.java [modify] https://crrev.com/ffa8e3905fed0b1df0d56ab6e4b17791b31cd171/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsCategoryInfo.java [modify] https://crrev.com/ffa8e3905fed0b1df0d56ab6e4b17791b31cd171/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java [modify] https://crrev.com/ffa8e3905fed0b1df0d56ab6e4b17791b31cd171/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java [modify] https://crrev.com/ffa8e3905fed0b1df0d56ab6e4b17791b31cd171/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/snippets/ArticleSnippetsTest.java [modify] https://crrev.com/ffa8e3905fed0b1df0d56ab6e4b17791b31cd171/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/ContentSuggestionsTestUtils.java [modify] https://crrev.com/ffa8e3905fed0b1df0d56ab6e4b17791b31cd171/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java [modify] https://crrev.com/ffa8e3905fed0b1df0d56ab6e4b17791b31cd171/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSectionTest.java [modify] https://crrev.com/ffa8e3905fed0b1df0d56ab6e4b17791b31cd171/chrome/browser/android/ntp/ntp_snippets_bridge.cc [modify] https://crrev.com/ffa8e3905fed0b1df0d56ab6e4b17791b31cd171/components/ntp_snippets_strings.grdp
,
Oct 6 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e38c94250d21597b298ce1cc13cfd1a9bcd926e8 commit e38c94250d21597b298ce1cc13cfd1a9bcd926e8 Author: dgn <dgn@chromium.org> Date: Thu Oct 06 14:34:26 2016 [NTP Client] Spacing and fixes for the sign in promo - Fixes an exception when only the sign in promo is present on the NTP and we attempt to make it peek - Adds 20dp space between the promo and the status card if present - Fixes to the bottom space calculation related to the dismissal of sibling elements. Preview: https://goo.gl/photos/94hhXK5rygGamFqt7 BUG= 649670 ,652578 Review-Url: https://codereview.chromium.org/2396863003 Cr-Commit-Position: refs/heads/master@{#423525} [modify] https://crrev.com/e38c94250d21597b298ce1cc13cfd1a9bcd926e8/chrome/android/java/res/values/dimens.xml [modify] https://crrev.com/e38c94250d21597b298ce1cc13cfd1a9bcd926e8/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardViewHolder.java [modify] https://crrev.com/e38c94250d21597b298ce1cc13cfd1a9bcd926e8/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java [modify] https://crrev.com/e38c94250d21597b298ce1cc13cfd1a9bcd926e8/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerView.java [modify] https://crrev.com/e38c94250d21597b298ce1cc13cfd1a9bcd926e8/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SigninPromoItem.java
,
Oct 6 2016
,
Oct 6 2016
The patch that landed in #15 is breaking tests on Lollipop Phone Tester, Android Tests (dbg) and Marshmallow 64 bit tester. I'm going to revert it so the rest of the tree doesn't turn red. Example failure: https://uberchromegw.corp.google.com/i/chromium.android/builders/Lollipop%20Phone%20Tester/builds/7171/steps/chrome_public_test_apk/logs/stdio C 798.053s Main [FAIL] org.chromium.chrome.browser.widget.OverviewListLayoutTest#testCloseAllIncognito: C 798.053s Main java.lang.NullPointerException: Attempt to invoke virtual method 'boolean org.chromium.chrome.browser.ntp.NewTabPage.isCardsUiEnabled()' on a null object reference C 798.053s Main at org.chromium.chrome.browser.toolbar.ToolbarPhone.onNtpScrollChanged(ToolbarPhone.java:734) C 798.053s Main at org.chromium.chrome.browser.ntp.NewTabPageView.updateSearchBoxOnScroll(NewTabPageView.java:495) C 798.053s Main at org.chromium.chrome.browser.ntp.NewTabPageView.access$000(NewTabPageView.java:76) C 798.053s Main at org.chromium.chrome.browser.ntp.NewTabPageView$9.onScrolled(NewTabPageView.java:568) C 798.053s Main at android.support.v7.widget.RecyclerView.dispatchOnScrolled(RecyclerView.java:4250) C 798.053s Main at android.support.v7.widget.RecyclerView.dispatchLayoutStep3(RecyclerView.java:3348) C 798.053s Main at android.support.v7.widget.RecyclerView.dispatchLayout(RecyclerView.java:3080) C 798.053s Main at android.support.v7.widget.RecyclerView.consumePendingUpdateOperations(RecyclerView.java:1478) C 798.053s Main at android.support.v7.widget.RecyclerView.focusSearch(RecyclerView.java:2158) C 798.053s Main at android.view.ViewGroup.focusSearch(ViewGroup.java:718) C 798.053s Main at android.view.ViewGroup.focusSearch(ViewGroup.java:718) C 798.053s Main at android.view.View.focusSearch(View.java:7295) C 798.053s Main at android.widget.TextView.onCreateInputConnection(TextView.java:5991) C 798.053s Main at android.view.inputmethod.InputMethodManager.startInputInner(InputMethodManager.java:1181) C 798.053s Main at android.view.inputmethod.InputMethodManager.checkFocus(InputMethodManager.java:1345) C 798.053s Main at android.view.inputmethod.InputMethodManager.restartInput(InputMethodManager.java:1121) C 798.053s Main at android.widget.TextView.setText(TextView.java:3977) C 798.053s Main at android.widget.TextView.setText(TextView.java:3915) C 798.053s Main at android.widget.EditText.setText(EditText.java:85) C 798.053s Main at org.chromium.chrome.browser.omnibox.UrlBar.setText(UrlBar.java:865) C 798.053s Main at android.widget.TextView.setText(TextView.java:3890) C 798.053s Main at org.chromium.chrome.browser.omnibox.UrlBar.setUrl(UrlBar.java:747) C 798.053s Main at org.chromium.chrome.browser.omnibox.LocationBarLayout.setUrlBarText(LocationBarLayout.java:2111) C 798.053s Main at org.chromium.chrome.browser.omnibox.LocationBarLayout.setUrlToPageUrl(LocationBarLayout.java:2085) C 798.053s Main at org.chromium.chrome.browser.toolbar.ToolbarManager.updateCurrentTabDisplayStatus(ToolbarManager.java:1133) C 798.053s Main at org.chromium.chrome.browser.toolbar.ToolbarManager.refreshSelectedTab(ToolbarManager.java:1082) C 798.053s Main at org.chromium.chrome.browser.toolbar.ToolbarManager.access$300(ToolbarManager.java:85) C 798.053s Main at org.chromium.chrome.browser.toolbar.ToolbarManager$4.onTabModelSelected(ToolbarManager.java:246) C 798.053s Main at org.chromium.chrome.browser.tabmodel.TabModelSelectorBase.selectModel(TabModelSelectorBase.java:75) C 798.054s Main at org.chromium.chrome.browser.tabmodel.TabModelSelectorImpl.selectModel(TabModelSelectorImpl.java:249) C 798.054s Main at org.chromium.chrome.browser.tabmodel.TabModelImpl.addTab(TabModelImpl.java:166) C 798.054s Main at org.chromium.chrome.browser.tabmodel.IncognitoTabModel.addTab(IncognitoTabModel.java:216) C 798.054s Main at org.chromium.chrome.browser.tabmodel.ChromeTabCreator.createNewTab(ChromeTabCreator.java:164) C 798.054s Main at org.chromium.chrome.browser.tabmodel.ChromeTabCreator.createNewTab(ChromeTabCreator.java:86) C 798.054s Main at org.chromium.chrome.browser.tabmodel.ChromeTabCreator.launchUrl(ChromeTabCreator.java:226) C 798.054s Main at org.chromium.chrome.browser.tabmodel.ChromeTabCreator.launchUrl(ChromeTabCreator.java:208) C 798.054s Main at org.chromium.chrome.browser.ChromeTabbedActivity.onMenuOrKeyboardAction(ChromeTabbedActivity.java:1100) C 798.054s Main at org.chromium.chrome.test.util.MenuUtils$1.run(MenuUtils.java:54) C 798.054s Main at android.app.Instrumentation$SyncRunnable.run(Instrumentation.java:1871) C 798.054s Main at android.os.Handler.handleCallback(Handler.java:739) C 798.054s Main at android.os.Handler.dispatchMessage(Handler.java:95) C 798.054s Main at android.os.Looper.loop(Looper.java:135) C 798.054s Main at android.app.ActivityThread.main(ActivityThread.java:5254) C 798.054s Main at java.lang.reflect.Method.invoke(Native Method) C 798.054s Main at java.lang.reflect.Method.invoke(Method.java:372) C 798.054s Main at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:903) C 798.054s Main at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:698) C 798.054s Main C 798.054s Main [FAIL] org.chromium.chrome.browser.widget.OverviewListLayoutTest#testModelSwitcherVisibility: C 798.054s Main java.lang.NullPointerException: Attempt to invoke virtual method 'boolean org.chromium.chrome.browser.ntp.NewTabPage.isCardsUiEnabled()' on a null object reference C 798.054s Main at org.chromium.chrome.browser.toolbar.ToolbarPhone.onNtpScrollChanged(ToolbarPhone.java:734) C 798.054s Main at org.chromium.chrome.browser.ntp.NewTabPageView.updateSearchBoxOnScroll(NewTabPageView.java:495) C 798.054s Main at org.chromium.chrome.browser.ntp.NewTabPageView.access$000(NewTabPageView.java:76) C 798.054s Main at org.chromium.chrome.browser.ntp.NewTabPageView$9.onScrolled(NewTabPageView.java:568) C 798.055s Main at android.support.v7.widget.RecyclerView.dispatchOnScrolled(RecyclerView.java:4250) C 798.055s Main at android.support.v7.widget.RecyclerView.dispatchLayoutStep3(RecyclerView.java:3348) C 798.055s Main at android.support.v7.widget.RecyclerView.dispatchLayout(RecyclerView.java:3080) C 798.055s Main at android.support.v7.widget.RecyclerView.consumePendingUpdateOperations(RecyclerView.java:1478) C 798.055s Main at android.support.v7.widget.RecyclerView.focusSearch(RecyclerView.java:2158) C 798.055s Main at android.view.ViewGroup.focusSearch(ViewGroup.java:718) C 798.055s Main at android.view.ViewGroup.focusSearch(ViewGroup.java:718) C 798.055s Main at android.view.View.focusSearch(View.java:7295) C 798.055s Main at android.widget.TextView.onCreateInputConnection(TextView.java:5991) C 798.055s Main at android.view.inputmethod.InputMethodManager.startInputInner(InputMethodManager.java:1181) C 798.055s Main at android.view.inputmethod.InputMethodManager.checkFocus(InputMethodManager.java:1345) C 798.055s Main at android.view.inputmethod.InputMethodManager.restartInput(InputMethodManager.java:1121) C 798.055s Main at android.widget.TextView.setText(TextView.java:3977) C 798.055s Main at android.widget.TextView.setText(TextView.java:3915) C 798.055s Main at android.widget.EditText.setText(EditText.java:85) C 798.055s Main at org.chromium.chrome.browser.omnibox.UrlBar.setText(UrlBar.java:865) C 798.055s Main at android.widget.TextView.setText(TextView.java:3890) C 798.055s Main at org.chromium.chrome.browser.omnibox.UrlBar.setUrl(UrlBar.java:747) C 798.055s Main at org.chromium.chrome.browser.omnibox.LocationBarLayout.setUrlBarText(LocationBarLayout.java:2111) C 798.055s Main at org.chromium.chrome.browser.omnibox.LocationBarLayout.setUrlToPageUrl(LocationBarLayout.java:2085) C 798.055s Main at org.chromium.chrome.browser.toolbar.ToolbarManager.updateCurrentTabDisplayStatus(ToolbarManager.java:1133) C 798.055s Main at org.chromium.chrome.browser.toolbar.ToolbarManager.refreshSelectedTab(ToolbarManager.java:1082) C 798.055s Main at org.chromium.chrome.browser.toolbar.ToolbarManager.access$300(ToolbarManager.java:85) C 798.055s Main at org.chromium.chrome.browser.toolbar.ToolbarManager$4.onTabModelSelected(ToolbarManager.java:246) C 798.055s Main at org.chromium.chrome.browser.tabmodel.TabModelSelectorBase.selectModel(TabModelSelectorBase.java:75) C 798.056s Main at org.chromium.chrome.browser.tabmodel.TabModelSelectorImpl.selectModel(TabModelSelectorImpl.java:249) C 798.056s Main at org.chromium.chrome.browser.tabmodel.TabModelImpl.addTab(TabModelImpl.java:166) C 798.056s Main at org.chromium.chrome.browser.tabmodel.IncognitoTabModel.addTab(IncognitoTabModel.java:216) C 798.056s Main at org.chromium.chrome.browser.tabmodel.ChromeTabCreator.createNewTab(ChromeTabCreator.java:164) C 798.056s Main at org.chromium.chrome.browser.tabmodel.ChromeTabCreator.createNewTab(ChromeTabCreator.java:86) C 798.056s Main at org.chromium.chrome.browser.tabmodel.ChromeTabCreator.launchUrl(ChromeTabCreator.java:226) C 798.056s Main at org.chromium.chrome.browser.tabmodel.ChromeTabCreator.launchUrl(ChromeTabCreator.java:208) C 798.056s Main at org.chromium.chrome.browser.ChromeTabbedActivity.onMenuOrKeyboardAction(ChromeTabbedActivity.java:1100) C 798.056s Main at org.chromium.chrome.test.util.MenuUtils$1.run(MenuUtils.java:54) C 798.056s Main at android.app.Instrumentation$SyncRunnable.run(Instrumentation.java:1871) C 798.056s Main at android.os.Handler.handleCallback(Handler.java:739) C 798.056s Main at android.os.Handler.dispatchMessage(Handler.java:95) C 798.056s Main at android.os.Looper.loop(Looper.java:135) C 798.056s Main at android.app.ActivityThread.main(ActivityThread.java:5254) C 798.056s Main at java.lang.reflect.Method.invoke(Native Method) C 798.056s Main at java.lang.reflect.Method.invoke(Method.java:372) C 798.056s Main at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:903) C 798.056s Main at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:698)
,
Oct 6 2016
* the change in #14, [NTP Client] Use the separate button style for the NoArticles status, is what broke the builds.
,
Oct 6 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b5e8956c2c8a10484d10a117b3ef5a33ee58cb6c commit b5e8956c2c8a10484d10a117b3ef5a33ee58cb6c Author: twellington <twellington@chromium.org> Date: Thu Oct 06 17:34:54 2016 Revert of 📰 Use the separate button style for the NoArticles status (patchset #6 id:100001 of https://codereview.chromium.org/2392943002/ ) Reason for revert: Breaking tests on Android bots, see bug comment. Original issue's description: > [NTP Client] Use the separate button style for the NoArticles status > > Makes the articles and bookmarks sections use the same style of status > card when they have no snippets. > > the hasMoreButton property of categories now only determines whether > the action item will be shown when there are suggestions to display. > > This patch also lets the SuggestionsCategoryInfo be aware of the > current category it is describing, and moves various category specific > behaviours into the SuggestionsCategoryInfo class. > > Preview: https://goo.gl/photos/VhceT6cjvME6QS8m7 > > BUG= 649670 > > Committed: https://crrev.com/ffa8e3905fed0b1df0d56ab6e4b17791b31cd171 > Cr-Commit-Position: refs/heads/master@{#423517} TBR=bauerb@chromium.org,dgn@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 649670 Review-Url: https://codereview.chromium.org/2398463005 Cr-Commit-Position: refs/heads/master@{#423573} [modify] https://crrev.com/b5e8956c2c8a10484d10a117b3ef5a33ee58cb6c/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ActionItem.java [modify] https://crrev.com/b5e8956c2c8a10484d10a117b3ef5a33ee58cb6c/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java [modify] https://crrev.com/b5e8956c2c8a10484d10a117b3ef5a33ee58cb6c/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/StatusItem.java [modify] https://crrev.com/b5e8956c2c8a10484d10a117b3ef5a33ee58cb6c/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsCategoryInfo.java [modify] https://crrev.com/b5e8956c2c8a10484d10a117b3ef5a33ee58cb6c/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java [modify] https://crrev.com/b5e8956c2c8a10484d10a117b3ef5a33ee58cb6c/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java [modify] https://crrev.com/b5e8956c2c8a10484d10a117b3ef5a33ee58cb6c/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/snippets/ArticleSnippetsTest.java [modify] https://crrev.com/b5e8956c2c8a10484d10a117b3ef5a33ee58cb6c/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/ContentSuggestionsTestUtils.java [modify] https://crrev.com/b5e8956c2c8a10484d10a117b3ef5a33ee58cb6c/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java [modify] https://crrev.com/b5e8956c2c8a10484d10a117b3ef5a33ee58cb6c/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSectionTest.java [modify] https://crrev.com/b5e8956c2c8a10484d10a117b3ef5a33ee58cb6c/chrome/browser/android/ntp/ntp_snippets_bridge.cc [modify] https://crrev.com/b5e8956c2c8a10484d10a117b3ef5a33ee58cb6c/components/ntp_snippets_strings.grdp
,
Oct 6 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/08c8e081835b2ce5d2294ee36c97efc14c6340f7 commit 08c8e081835b2ce5d2294ee36c97efc14c6340f7 Author: nasko <nasko@chromium.org> Date: Thu Oct 06 20:12:17 2016 Revert of 📰 Spacing and fixes for the sign in promo (patchset #2 id:20001 of https://codereview.chromium.org/2396863003/ ) Reason for revert: Reverting due to test failures in chrome_public_test_apk https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/36518 failures: org.chromium.chrome.browser.widget.OverviewListLayoutTest#testCloseAllIncognito org.chromium.chrome.browser.widget.OverviewListLayoutTest#testModelSwitcherVisibility Original issue's description: > [NTP Client] Spacing and fixes for the sign in promo > > - Fixes an exception when only the sign in promo is present on the NTP > and we attempt to make it peek > > - Adds 20dp space between the promo and the status card if present > > - Fixes to the bottom space calculation related to the dismissal of > sibling elements. > > Preview: https://goo.gl/photos/94hhXK5rygGamFqt7 > > BUG= 649670 ,652578 > > Committed: https://crrev.com/e38c94250d21597b298ce1cc13cfd1a9bcd926e8 > Cr-Commit-Position: refs/heads/master@{#423525} TBR=bauerb@chromium.org,dgn@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 649670 ,652578 Review-Url: https://codereview.chromium.org/2399983002 Cr-Commit-Position: refs/heads/master@{#423644} [modify] https://crrev.com/08c8e081835b2ce5d2294ee36c97efc14c6340f7/chrome/android/java/res/values/dimens.xml [modify] https://crrev.com/08c8e081835b2ce5d2294ee36c97efc14c6340f7/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardViewHolder.java [modify] https://crrev.com/08c8e081835b2ce5d2294ee36c97efc14c6340f7/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java [modify] https://crrev.com/08c8e081835b2ce5d2294ee36c97efc14c6340f7/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerView.java [modify] https://crrev.com/08c8e081835b2ce5d2294ee36c97efc14c6340f7/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SigninPromoItem.java
,
Oct 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/83034cc5fb53f6d66f73f3a8afbfdd0d14b42943 commit 83034cc5fb53f6d66f73f3a8afbfdd0d14b42943 Author: dgn <dgn@chromium.org> Date: Fri Oct 07 14:42:23 2016 Tentative fix for scroll event related crashes on the NTP A crash[1] seems to be caused by events attempting to get data from the NTP while it is not the current page anymore. This CL adds a check to ensure the page processing the events is the currently displayed NTP. [1]: https://crbug.com/649670#c17 BUG= 649670 Review-Url: https://codereview.chromium.org/2400163002 Cr-Commit-Position: refs/heads/master@{#423858} [modify] https://crrev.com/83034cc5fb53f6d66f73f3a8afbfdd0d14b42943/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java [modify] https://crrev.com/83034cc5fb53f6d66f73f3a8afbfdd0d14b42943/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java [modify] https://crrev.com/83034cc5fb53f6d66f73f3a8afbfdd0d14b42943/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java [modify] https://crrev.com/83034cc5fb53f6d66f73f3a8afbfdd0d14b42943/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/snippets/ArticleSnippetsTest.java [modify] https://crrev.com/83034cc5fb53f6d66f73f3a8afbfdd0d14b42943/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java
,
Oct 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/76d61d3752f37395ffcd259925ef6ded78f3d014 commit 76d61d3752f37395ffcd259925ef6ded78f3d014 Author: dgn <dgn@chromium.org> Date: Fri Oct 07 15:33:04 2016 [NTP Client][Reland]Use the separate button style for the NoArticles status Original issue's description: > [NTP Client] Use the separate button style for the NoArticles status > > Makes the articles and bookmarks sections use the same style of status > card when they have no snippets. > > the hasMoreButton property of categories now only determines whether > the action item will be shown when there are suggestions to display. > > This patch also lets the SuggestionsCategoryInfo be aware of the > current category it is describing, and moves various category specific > behaviours into the SuggestionsCategoryInfo class. > > Preview: https://goo.gl/photos/VhceT6cjvME6QS8m7 > > BUG= 649670 > > Committed: https://crrev.com/ffa8e3905fed0b1df0d56ab6e4b17791b31cd171 > Cr-Commit-Position: refs/heads/master@{#423517} > Revert Data: > Committed: https://crrev.com/b5e8956c2c8a10484d10a117b3ef5a33ee58cb6c > Cr-Commit-Position: refs/heads/master@{#423573} BUG= 649670 Review-Url: https://codereview.chromium.org/2401643004 Cr-Commit-Position: refs/heads/master@{#423863} [modify] https://crrev.com/76d61d3752f37395ffcd259925ef6ded78f3d014/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ActionItem.java [modify] https://crrev.com/76d61d3752f37395ffcd259925ef6ded78f3d014/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java [modify] https://crrev.com/76d61d3752f37395ffcd259925ef6ded78f3d014/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/StatusItem.java [modify] https://crrev.com/76d61d3752f37395ffcd259925ef6ded78f3d014/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsCategoryInfo.java [modify] https://crrev.com/76d61d3752f37395ffcd259925ef6ded78f3d014/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java [modify] https://crrev.com/76d61d3752f37395ffcd259925ef6ded78f3d014/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java [modify] https://crrev.com/76d61d3752f37395ffcd259925ef6ded78f3d014/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/snippets/ArticleSnippetsTest.java [modify] https://crrev.com/76d61d3752f37395ffcd259925ef6ded78f3d014/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/ContentSuggestionsTestUtils.java [modify] https://crrev.com/76d61d3752f37395ffcd259925ef6ded78f3d014/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java [modify] https://crrev.com/76d61d3752f37395ffcd259925ef6ded78f3d014/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSectionTest.java [modify] https://crrev.com/76d61d3752f37395ffcd259925ef6ded78f3d014/chrome/browser/android/ntp/ntp_snippets_bridge.cc [modify] https://crrev.com/76d61d3752f37395ffcd259925ef6ded78f3d014/components/ntp_snippets_strings.grdp
,
Oct 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1bb1fb7f5885bfaa43b0dba4b627798cb268c7ac commit 1bb1fb7f5885bfaa43b0dba4b627798cb268c7ac Author: dgn <dgn@chromium.org> Date: Fri Oct 07 15:41:13 2016 [NTP Client][Reland]Spacing and fixes for the sign in promo Original issue's description: > [NTP Client] Spacing and fixes for the sign in promo > > - Fixes an exception when only the sign in promo is present on the NTP > and we attempt to make it peek > > - Adds 20dp space between the promo and the status card if present > > - Fixes to the bottom space calculation related to the dismissal of > sibling elements. > > Preview: https://goo.gl/photos/94hhXK5rygGamFqt7 > > BUG= 649670 ,652578 > > Committed: https://crrev.com/e38c94250d21597b298ce1cc13cfd1a9bcd926e8 > Cr-Commit-Position: refs/heads/master@{#423525} Revert link: > Committed: https://crrev.com/08c8e081835b2ce5d2294ee36c97efc14c6340f7 > Cr-Commit-Position: refs/heads/master@{#423644} BUG= 649670 ,652578 Review-Url: https://codereview.chromium.org/2397573009 Cr-Commit-Position: refs/heads/master@{#423864} [modify] https://crrev.com/1bb1fb7f5885bfaa43b0dba4b627798cb268c7ac/chrome/android/java/res/values/dimens.xml [modify] https://crrev.com/1bb1fb7f5885bfaa43b0dba4b627798cb268c7ac/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardViewHolder.java [modify] https://crrev.com/1bb1fb7f5885bfaa43b0dba4b627798cb268c7ac/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java [modify] https://crrev.com/1bb1fb7f5885bfaa43b0dba4b627798cb268c7ac/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerView.java [modify] https://crrev.com/1bb1fb7f5885bfaa43b0dba4b627798cb268c7ac/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SigninPromoItem.java
,
Oct 12 2016
Requesting to merge the three above commits, comments #21, #22, and #23, to M55.
,
Oct 12 2016
Your change meets the bar and is auto-approved for M55 (branch: 2883)
,
Oct 12 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5d06125ffec380d152ac244963fc2b154ed109da commit 5d06125ffec380d152ac244963fc2b154ed109da Author: Marc Treib <treib@chromium.org> Date: Wed Oct 12 16:05:22 2016 Tentative fix for scroll event related crashes on the NTP A crash[1] seems to be caused by events attempting to get data from the NTP while it is not the current page anymore. This CL adds a check to ensure the page processing the events is the currently displayed NTP. [1]: https://crbug.com/649670#c17 BUG= 649670 Review-Url: https://codereview.chromium.org/2400163002 Cr-Commit-Position: refs/heads/master@{#423858} (cherry picked from commit 83034cc5fb53f6d66f73f3a8afbfdd0d14b42943) Review URL: https://codereview.chromium.org/2410193006 . Cr-Commit-Position: refs/branch-heads/2883@{#62} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} [modify] https://crrev.com/5d06125ffec380d152ac244963fc2b154ed109da/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java [modify] https://crrev.com/5d06125ffec380d152ac244963fc2b154ed109da/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java [modify] https://crrev.com/5d06125ffec380d152ac244963fc2b154ed109da/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java [modify] https://crrev.com/5d06125ffec380d152ac244963fc2b154ed109da/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/snippets/ArticleSnippetsTest.java [modify] https://crrev.com/5d06125ffec380d152ac244963fc2b154ed109da/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java
,
Oct 12 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a30d7b694c5efeb957f41430803a330b629100fc commit a30d7b694c5efeb957f41430803a330b629100fc Author: Marc Treib <treib@chromium.org> Date: Wed Oct 12 16:29:20 2016 [NTP Client][Reland]Use the separate button style for the NoArticles status Original issue's description: > [NTP Client] Use the separate button style for the NoArticles status > > Makes the articles and bookmarks sections use the same style of status > card when they have no snippets. > > the hasMoreButton property of categories now only determines whether > the action item will be shown when there are suggestions to display. > > This patch also lets the SuggestionsCategoryInfo be aware of the > current category it is describing, and moves various category specific > behaviours into the SuggestionsCategoryInfo class. > > Preview: https://goo.gl/photos/VhceT6cjvME6QS8m7 > > BUG= 649670 > > Committed: https://crrev.com/ffa8e3905fed0b1df0d56ab6e4b17791b31cd171 > Cr-Commit-Position: refs/heads/master@{#423517} > Revert Data: > Committed: https://crrev.com/b5e8956c2c8a10484d10a117b3ef5a33ee58cb6c > Cr-Commit-Position: refs/heads/master@{#423573} BUG= 649670 Review-Url: https://codereview.chromium.org/2401643004 Cr-Commit-Position: refs/heads/master@{#423863} (cherry picked from commit 76d61d3752f37395ffcd259925ef6ded78f3d014) Review URL: https://codereview.chromium.org/2410153006 . Cr-Commit-Position: refs/branch-heads/2883@{#63} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} [modify] https://crrev.com/a30d7b694c5efeb957f41430803a330b629100fc/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ActionItem.java [modify] https://crrev.com/a30d7b694c5efeb957f41430803a330b629100fc/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java [modify] https://crrev.com/a30d7b694c5efeb957f41430803a330b629100fc/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/StatusItem.java [modify] https://crrev.com/a30d7b694c5efeb957f41430803a330b629100fc/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsCategoryInfo.java [modify] https://crrev.com/a30d7b694c5efeb957f41430803a330b629100fc/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java [modify] https://crrev.com/a30d7b694c5efeb957f41430803a330b629100fc/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java [modify] https://crrev.com/a30d7b694c5efeb957f41430803a330b629100fc/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/snippets/ArticleSnippetsTest.java [modify] https://crrev.com/a30d7b694c5efeb957f41430803a330b629100fc/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/ContentSuggestionsTestUtils.java [modify] https://crrev.com/a30d7b694c5efeb957f41430803a330b629100fc/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java [modify] https://crrev.com/a30d7b694c5efeb957f41430803a330b629100fc/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSectionTest.java [modify] https://crrev.com/a30d7b694c5efeb957f41430803a330b629100fc/chrome/browser/android/ntp/ntp_snippets_bridge.cc [modify] https://crrev.com/a30d7b694c5efeb957f41430803a330b629100fc/components/ntp_snippets_strings.grdp
,
Oct 12 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8e8893dbdaf6fc2370c289c061bb0cf4ed420093 commit 8e8893dbdaf6fc2370c289c061bb0cf4ed420093 Author: Marc Treib <treib@chromium.org> Date: Wed Oct 12 16:34:57 2016 [NTP Client][Reland]Spacing and fixes for the sign in promo Original issue's description: > [NTP Client] Spacing and fixes for the sign in promo > > - Fixes an exception when only the sign in promo is present on the NTP > and we attempt to make it peek > > - Adds 20dp space between the promo and the status card if present > > - Fixes to the bottom space calculation related to the dismissal of > sibling elements. > > Preview: https://goo.gl/photos/94hhXK5rygGamFqt7 > > BUG= 649670 ,652578 > > Committed: https://crrev.com/e38c94250d21597b298ce1cc13cfd1a9bcd926e8 > Cr-Commit-Position: refs/heads/master@{#423525} Revert link: > Committed: https://crrev.com/08c8e081835b2ce5d2294ee36c97efc14c6340f7 > Cr-Commit-Position: refs/heads/master@{#423644} BUG= 649670 ,652578 Review-Url: https://codereview.chromium.org/2397573009 Cr-Commit-Position: refs/heads/master@{#423864} (cherry picked from commit 1bb1fb7f5885bfaa43b0dba4b627798cb268c7ac) Review URL: https://codereview.chromium.org/2413773002 . Cr-Commit-Position: refs/branch-heads/2883@{#64} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} [modify] https://crrev.com/8e8893dbdaf6fc2370c289c061bb0cf4ed420093/chrome/android/java/res/values/dimens.xml [modify] https://crrev.com/8e8893dbdaf6fc2370c289c061bb0cf4ed420093/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardViewHolder.java [modify] https://crrev.com/8e8893dbdaf6fc2370c289c061bb0cf4ed420093/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java [modify] https://crrev.com/8e8893dbdaf6fc2370c289c061bb0cf4ed420093/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerView.java [modify] https://crrev.com/8e8893dbdaf6fc2370c289c061bb0cf4ed420093/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SigninPromoItem.java
,
Oct 18 2016
Verified in M55-55.0.2883.18
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ffa8e3905fed0b1df0d56ab6e4b17791b31cd171 commit ffa8e3905fed0b1df0d56ab6e4b17791b31cd171 Author: dgn <dgn@chromium.org> Date: Thu Oct 06 14:13:23 2016 [NTP Client] Use the separate button style for the NoArticles status Makes the articles and bookmarks sections use the same style of status card when they have no snippets. the hasMoreButton property of categories now only determines whether the action item will be shown when there are suggestions to display. This patch also lets the SuggestionsCategoryInfo be aware of the current category it is describing, and moves various category specific behaviours into the SuggestionsCategoryInfo class. Preview: https://goo.gl/photos/VhceT6cjvME6QS8m7 BUG= 649670 Review-Url: https://codereview.chromium.org/2392943002 Cr-Commit-Position: refs/heads/master@{#423517} [modify] https://crrev.com/ffa8e3905fed0b1df0d56ab6e4b17791b31cd171/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ActionItem.java [modify] https://crrev.com/ffa8e3905fed0b1df0d56ab6e4b17791b31cd171/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java [modify] https://crrev.com/ffa8e3905fed0b1df0d56ab6e4b17791b31cd171/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/StatusItem.java [modify] https://crrev.com/ffa8e3905fed0b1df0d56ab6e4b17791b31cd171/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsCategoryInfo.java [modify] https://crrev.com/ffa8e3905fed0b1df0d56ab6e4b17791b31cd171/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java [modify] https://crrev.com/ffa8e3905fed0b1df0d56ab6e4b17791b31cd171/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java [modify] https://crrev.com/ffa8e3905fed0b1df0d56ab6e4b17791b31cd171/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/snippets/ArticleSnippetsTest.java [modify] https://crrev.com/ffa8e3905fed0b1df0d56ab6e4b17791b31cd171/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/ContentSuggestionsTestUtils.java [modify] https://crrev.com/ffa8e3905fed0b1df0d56ab6e4b17791b31cd171/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java [modify] https://crrev.com/ffa8e3905fed0b1df0d56ab6e4b17791b31cd171/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSectionTest.java [modify] https://crrev.com/ffa8e3905fed0b1df0d56ab6e4b17791b31cd171/chrome/browser/android/ntp/ntp_snippets_bridge.cc [modify] https://crrev.com/ffa8e3905fed0b1df0d56ab6e4b17791b31cd171/components/ntp_snippets_strings.grdp
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e38c94250d21597b298ce1cc13cfd1a9bcd926e8 commit e38c94250d21597b298ce1cc13cfd1a9bcd926e8 Author: dgn <dgn@chromium.org> Date: Thu Oct 06 14:34:26 2016 [NTP Client] Spacing and fixes for the sign in promo - Fixes an exception when only the sign in promo is present on the NTP and we attempt to make it peek - Adds 20dp space between the promo and the status card if present - Fixes to the bottom space calculation related to the dismissal of sibling elements. Preview: https://goo.gl/photos/94hhXK5rygGamFqt7 BUG= 649670 ,652578 Review-Url: https://codereview.chromium.org/2396863003 Cr-Commit-Position: refs/heads/master@{#423525} [modify] https://crrev.com/e38c94250d21597b298ce1cc13cfd1a9bcd926e8/chrome/android/java/res/values/dimens.xml [modify] https://crrev.com/e38c94250d21597b298ce1cc13cfd1a9bcd926e8/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardViewHolder.java [modify] https://crrev.com/e38c94250d21597b298ce1cc13cfd1a9bcd926e8/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java [modify] https://crrev.com/e38c94250d21597b298ce1cc13cfd1a9bcd926e8/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerView.java [modify] https://crrev.com/e38c94250d21597b298ce1cc13cfd1a9bcd926e8/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SigninPromoItem.java
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b5e8956c2c8a10484d10a117b3ef5a33ee58cb6c commit b5e8956c2c8a10484d10a117b3ef5a33ee58cb6c Author: twellington <twellington@chromium.org> Date: Thu Oct 06 17:34:54 2016 Revert of 📰 Use the separate button style for the NoArticles status (patchset #6 id:100001 of https://codereview.chromium.org/2392943002/ ) Reason for revert: Breaking tests on Android bots, see bug comment. Original issue's description: > [NTP Client] Use the separate button style for the NoArticles status > > Makes the articles and bookmarks sections use the same style of status > card when they have no snippets. > > the hasMoreButton property of categories now only determines whether > the action item will be shown when there are suggestions to display. > > This patch also lets the SuggestionsCategoryInfo be aware of the > current category it is describing, and moves various category specific > behaviours into the SuggestionsCategoryInfo class. > > Preview: https://goo.gl/photos/VhceT6cjvME6QS8m7 > > BUG= 649670 > > Committed: https://crrev.com/ffa8e3905fed0b1df0d56ab6e4b17791b31cd171 > Cr-Commit-Position: refs/heads/master@{#423517} TBR=bauerb@chromium.org,dgn@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 649670 Review-Url: https://codereview.chromium.org/2398463005 Cr-Commit-Position: refs/heads/master@{#423573} [modify] https://crrev.com/b5e8956c2c8a10484d10a117b3ef5a33ee58cb6c/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ActionItem.java [modify] https://crrev.com/b5e8956c2c8a10484d10a117b3ef5a33ee58cb6c/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java [modify] https://crrev.com/b5e8956c2c8a10484d10a117b3ef5a33ee58cb6c/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/StatusItem.java [modify] https://crrev.com/b5e8956c2c8a10484d10a117b3ef5a33ee58cb6c/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsCategoryInfo.java [modify] https://crrev.com/b5e8956c2c8a10484d10a117b3ef5a33ee58cb6c/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java [modify] https://crrev.com/b5e8956c2c8a10484d10a117b3ef5a33ee58cb6c/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java [modify] https://crrev.com/b5e8956c2c8a10484d10a117b3ef5a33ee58cb6c/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/snippets/ArticleSnippetsTest.java [modify] https://crrev.com/b5e8956c2c8a10484d10a117b3ef5a33ee58cb6c/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/ContentSuggestionsTestUtils.java [modify] https://crrev.com/b5e8956c2c8a10484d10a117b3ef5a33ee58cb6c/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java [modify] https://crrev.com/b5e8956c2c8a10484d10a117b3ef5a33ee58cb6c/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSectionTest.java [modify] https://crrev.com/b5e8956c2c8a10484d10a117b3ef5a33ee58cb6c/chrome/browser/android/ntp/ntp_snippets_bridge.cc [modify] https://crrev.com/b5e8956c2c8a10484d10a117b3ef5a33ee58cb6c/components/ntp_snippets_strings.grdp
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/08c8e081835b2ce5d2294ee36c97efc14c6340f7 commit 08c8e081835b2ce5d2294ee36c97efc14c6340f7 Author: nasko <nasko@chromium.org> Date: Thu Oct 06 20:12:17 2016 Revert of 📰 Spacing and fixes for the sign in promo (patchset #2 id:20001 of https://codereview.chromium.org/2396863003/ ) Reason for revert: Reverting due to test failures in chrome_public_test_apk https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/36518 failures: org.chromium.chrome.browser.widget.OverviewListLayoutTest#testCloseAllIncognito org.chromium.chrome.browser.widget.OverviewListLayoutTest#testModelSwitcherVisibility Original issue's description: > [NTP Client] Spacing and fixes for the sign in promo > > - Fixes an exception when only the sign in promo is present on the NTP > and we attempt to make it peek > > - Adds 20dp space between the promo and the status card if present > > - Fixes to the bottom space calculation related to the dismissal of > sibling elements. > > Preview: https://goo.gl/photos/94hhXK5rygGamFqt7 > > BUG= 649670 ,652578 > > Committed: https://crrev.com/e38c94250d21597b298ce1cc13cfd1a9bcd926e8 > Cr-Commit-Position: refs/heads/master@{#423525} TBR=bauerb@chromium.org,dgn@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 649670 ,652578 Review-Url: https://codereview.chromium.org/2399983002 Cr-Commit-Position: refs/heads/master@{#423644} [modify] https://crrev.com/08c8e081835b2ce5d2294ee36c97efc14c6340f7/chrome/android/java/res/values/dimens.xml [modify] https://crrev.com/08c8e081835b2ce5d2294ee36c97efc14c6340f7/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardViewHolder.java [modify] https://crrev.com/08c8e081835b2ce5d2294ee36c97efc14c6340f7/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java [modify] https://crrev.com/08c8e081835b2ce5d2294ee36c97efc14c6340f7/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerView.java [modify] https://crrev.com/08c8e081835b2ce5d2294ee36c97efc14c6340f7/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SigninPromoItem.java
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5d06125ffec380d152ac244963fc2b154ed109da commit 5d06125ffec380d152ac244963fc2b154ed109da Author: Marc Treib <treib@chromium.org> Date: Wed Oct 12 16:05:22 2016 Tentative fix for scroll event related crashes on the NTP A crash[1] seems to be caused by events attempting to get data from the NTP while it is not the current page anymore. This CL adds a check to ensure the page processing the events is the currently displayed NTP. [1]: https://crbug.com/649670#c17 BUG= 649670 Review-Url: https://codereview.chromium.org/2400163002 Cr-Commit-Position: refs/heads/master@{#423858} (cherry picked from commit 83034cc5fb53f6d66f73f3a8afbfdd0d14b42943) Review URL: https://codereview.chromium.org/2410193006 . Cr-Commit-Position: refs/branch-heads/2883@{#62} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} [modify] https://crrev.com/5d06125ffec380d152ac244963fc2b154ed109da/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java [modify] https://crrev.com/5d06125ffec380d152ac244963fc2b154ed109da/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java [modify] https://crrev.com/5d06125ffec380d152ac244963fc2b154ed109da/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java [modify] https://crrev.com/5d06125ffec380d152ac244963fc2b154ed109da/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/snippets/ArticleSnippetsTest.java [modify] https://crrev.com/5d06125ffec380d152ac244963fc2b154ed109da/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a30d7b694c5efeb957f41430803a330b629100fc commit a30d7b694c5efeb957f41430803a330b629100fc Author: Marc Treib <treib@chromium.org> Date: Wed Oct 12 16:29:20 2016 [NTP Client][Reland]Use the separate button style for the NoArticles status Original issue's description: > [NTP Client] Use the separate button style for the NoArticles status > > Makes the articles and bookmarks sections use the same style of status > card when they have no snippets. > > the hasMoreButton property of categories now only determines whether > the action item will be shown when there are suggestions to display. > > This patch also lets the SuggestionsCategoryInfo be aware of the > current category it is describing, and moves various category specific > behaviours into the SuggestionsCategoryInfo class. > > Preview: https://goo.gl/photos/VhceT6cjvME6QS8m7 > > BUG= 649670 > > Committed: https://crrev.com/ffa8e3905fed0b1df0d56ab6e4b17791b31cd171 > Cr-Commit-Position: refs/heads/master@{#423517} > Revert Data: > Committed: https://crrev.com/b5e8956c2c8a10484d10a117b3ef5a33ee58cb6c > Cr-Commit-Position: refs/heads/master@{#423573} BUG= 649670 Review-Url: https://codereview.chromium.org/2401643004 Cr-Commit-Position: refs/heads/master@{#423863} (cherry picked from commit 76d61d3752f37395ffcd259925ef6ded78f3d014) Review URL: https://codereview.chromium.org/2410153006 . Cr-Commit-Position: refs/branch-heads/2883@{#63} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} [modify] https://crrev.com/a30d7b694c5efeb957f41430803a330b629100fc/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ActionItem.java [modify] https://crrev.com/a30d7b694c5efeb957f41430803a330b629100fc/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java [modify] https://crrev.com/a30d7b694c5efeb957f41430803a330b629100fc/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/StatusItem.java [modify] https://crrev.com/a30d7b694c5efeb957f41430803a330b629100fc/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsCategoryInfo.java [modify] https://crrev.com/a30d7b694c5efeb957f41430803a330b629100fc/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java [modify] https://crrev.com/a30d7b694c5efeb957f41430803a330b629100fc/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java [modify] https://crrev.com/a30d7b694c5efeb957f41430803a330b629100fc/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/snippets/ArticleSnippetsTest.java [modify] https://crrev.com/a30d7b694c5efeb957f41430803a330b629100fc/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/ContentSuggestionsTestUtils.java [modify] https://crrev.com/a30d7b694c5efeb957f41430803a330b629100fc/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java [modify] https://crrev.com/a30d7b694c5efeb957f41430803a330b629100fc/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSectionTest.java [modify] https://crrev.com/a30d7b694c5efeb957f41430803a330b629100fc/chrome/browser/android/ntp/ntp_snippets_bridge.cc [modify] https://crrev.com/a30d7b694c5efeb957f41430803a330b629100fc/components/ntp_snippets_strings.grdp
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8e8893dbdaf6fc2370c289c061bb0cf4ed420093 commit 8e8893dbdaf6fc2370c289c061bb0cf4ed420093 Author: Marc Treib <treib@chromium.org> Date: Wed Oct 12 16:34:57 2016 [NTP Client][Reland]Spacing and fixes for the sign in promo Original issue's description: > [NTP Client] Spacing and fixes for the sign in promo > > - Fixes an exception when only the sign in promo is present on the NTP > and we attempt to make it peek > > - Adds 20dp space between the promo and the status card if present > > - Fixes to the bottom space calculation related to the dismissal of > sibling elements. > > Preview: https://goo.gl/photos/94hhXK5rygGamFqt7 > > BUG= 649670 ,652578 > > Committed: https://crrev.com/e38c94250d21597b298ce1cc13cfd1a9bcd926e8 > Cr-Commit-Position: refs/heads/master@{#423525} Revert link: > Committed: https://crrev.com/08c8e081835b2ce5d2294ee36c97efc14c6340f7 > Cr-Commit-Position: refs/heads/master@{#423644} BUG= 649670 ,652578 Review-Url: https://codereview.chromium.org/2397573009 Cr-Commit-Position: refs/heads/master@{#423864} (cherry picked from commit 1bb1fb7f5885bfaa43b0dba4b627798cb268c7ac) Review URL: https://codereview.chromium.org/2413773002 . Cr-Commit-Position: refs/branch-heads/2883@{#64} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} [modify] https://crrev.com/8e8893dbdaf6fc2370c289c061bb0cf4ed420093/chrome/android/java/res/values/dimens.xml [modify] https://crrev.com/8e8893dbdaf6fc2370c289c061bb0cf4ed420093/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardViewHolder.java [modify] https://crrev.com/8e8893dbdaf6fc2370c289c061bb0cf4ed420093/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java [modify] https://crrev.com/8e8893dbdaf6fc2370c289c061bb0cf4ed420093/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerView.java [modify] https://crrev.com/8e8893dbdaf6fc2370c289c061bb0cf4ed420093/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SigninPromoItem.java
,
Nov 4 2016
[Automated comment] removing mislabelled merge-merged-2840 |
||||||||||||||||||
►
Sign in to add a comment |
||||||||||||||||||
Comment 1 by dgn@chromium.org
, Sep 23 2016