New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 649660 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug

Blocking:
issue skia:5612



Sign in to add a comment

[PG] Specifying --cc during upload and adding emails to CC_LIST does not seem to be sending emails

Project Member Reported by rmis...@google.com, Sep 23 2016

Issue description


I tested it in the Skia repo by doing:
git cl upload --cc=benjaminwagner@google.com --bypass-hooks

The refspec looked like this:
refs/for/refs/heads/master%notify=NONE,cc=reviews@skia.org,cc=benjaminwagner@google.com

but Ben (who has an active account in skia-review) did not get any emails (neither did reviews@skia.org).
 

Comment 1 by rmis...@google.com, Sep 23 2016

Blocking: skia:5612
Project Member

Comment 2 by sheriffbot@chromium.org, Sep 23 2016

Labels: Hotlist-Google
Cc: -tandrii@chromium.org
Owner: tandrii@chromium.org
Status: Assigned (was: Untriaged)
Andrii, mind taking a look?
Ah, I got it: notify=NONE! Have you tried git cl upload with -s flag to actually send email? :)
I've uploaded a new issue as a test. If you got email, then it works:

To https://chromium.googlesource.com/infra/infra.git
 * [new branch]      1fd432a2a593d48b2d65e73446b0f149cc866907 -> refs/for/refs/heads/master%notify=ALL,cc=chromium-reviews@chromium.org,cc=infra-reviews+infra@chromium.org,cc=sergiyb@chromium.org,r=rmistry@chromium.org

Comment 6 by rmis...@google.com, Sep 23 2016

Yes I got the email. But I still do not follow-

For things in the CC_LIST how do I send out an email without specifying a reviewer on the commandline? If I do
"git cl upload -s" it says
"Must specify reviewers to send email."
I get the same with -cc and no --reviewers.

For Rietveld, the CC_LIST is added to the issue during upload and stays there for all notifications. Since the CC_LIST is not added to the Gerrit issue all future review comments and notifications done from the UI do not update the CC_LIST like it does in Rietveld.

Comment 7 by rmis...@google.com, Sep 26 2016

Labels: -Pri-2 Pri-1
Upping the priority of this to P1 because we had to pause the Skia dogfood of Gerrit until reviews@skia.org starts receiving emails.

Comment 8 by rmis...@google.com, Sep 26 2016

Cc: mtklein@chromium.org
Also, I am OOO 9/26 and 9/27 so please coordinate with mtklein@ if you need him to test out something for Skia.
TBH, I don't have a good comprehensive solution here.
Project-wide CC list should probably be moved to Gerrit's project-wide config, hereby making skia-reviews@ receive emails from Gerrit about changes in its own way, as opposed to whenever user hits git cl upload with --send-email. 

Comment 10 by rmis...@google.com, Sep 26 2016

Oh, how do I set project-wide CC list?
Is that something I can set here: https://skia-review.googlesource.com/#/admin/projects/All-Projects,access ?

Comment 12 by rmis...@google.com, Sep 26 2016

Made this change: https://skia.googlesource.com/All-Projects/+/8c8003a7a91a29dc9630f6a0d97f22ffc25c3722%5E%21/#F0

Let's see if that works around our CC_LIST problem.
Did the configuration change solve the issue?

Comment 14 by rmis...@google.com, Sep 27 2016

Labels: -Pri-1 Pri-2
Kind of. It sends emails for everything now, even when a change is first uploaded and not ready for review. Also seems to send emails for every new patchset and dry runs.

It is a good workaround for now, but IMO the CC_LIST should be added to the Change by calling the 'Add Reviewer' endpoint from Gerrit's API. Doing that will ensure that the existing functionality of CC_LIST in the various codereview.settings is maintained.

I can look into this when I am back from vacation if somebody does not beat me to it.
Ravi get away from your computer :). Go back to vacation, please.
Labels: Milestone-Fishfood

Comment 17 by rmis...@google.com, Sep 28 2016

Sent out for review https://codereview.chromium.org/2378703002/

Comment 18 by rmis...@google.com, Sep 28 2016

Adding below since bugdroid does not seem to want to update this bug.

Submitted https://codereview.chromium.org/2378703002/ : Add CC_LIST and --cc to Gerrit issues via API to be similar to CCs in Rietveld.


The CC_LIST appears to be now correctly added Eg: https://skia-review.googlesource.com/c/2741/

The problem of too frequent updates still exists though. Sending out an email to the cc list whenever the desc is updated and dry runs are triggered is spammy especially to Rietveld users who will not expect this. Is there an existing bug to address this? should I file one?

wyatta and heisel are looking to improve email product excellence type of bugs. I would file one against polygerrit with your desired flow. I'm too far removed with how emails work in Rietveld (or critique) to give a comprehensive overview of desired behavior. 
Project Member

Comment 20 by bugdroid1@chromium.org, Sep 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/3ca6e8a40b853337432916ce446b00e72b145381

commit 3ca6e8a40b853337432916ce446b00e72b145381
Author: recipe-roller <recipe-roller@chromium.org>
Date: Wed Sep 28 15:34:21 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

depot_tools:
  https://crrev.com/3574740929abd37c45db1d2f8a2c3799bdfe77c5 Add CC_LIST and --cc to Gerrit issues via API to be similar to CCs in Rietveld (rmistry@google.com)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG= chromium:649660 

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2375963004

[modify] https://crrev.com/3ca6e8a40b853337432916ce446b00e72b145381/infra/config/recipes.cfg

Project Member

Comment 21 by bugdroid1@chromium.org, Sep 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/3ca6e8a40b853337432916ce446b00e72b145381

commit 3ca6e8a40b853337432916ce446b00e72b145381
Author: recipe-roller <recipe-roller@chromium.org>
Date: Wed Sep 28 15:34:21 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

depot_tools:
  https://crrev.com/3574740929abd37c45db1d2f8a2c3799bdfe77c5 Add CC_LIST and --cc to Gerrit issues via API to be similar to CCs in Rietveld (rmistry@google.com)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG= chromium:649660 

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2375963004

[modify] https://crrev.com/3ca6e8a40b853337432916ce446b00e72b145381/infra/config/recipes.cfg

Project Member

Comment 22 by bugdroid1@chromium.org, Sep 28 2016

Project Member

Comment 23 by bugdroid1@chromium.org, Sep 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/3ca6e8a40b853337432916ce446b00e72b145381

commit 3ca6e8a40b853337432916ce446b00e72b145381
Author: recipe-roller <recipe-roller@chromium.org>
Date: Wed Sep 28 15:34:21 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

depot_tools:
  https://crrev.com/3574740929abd37c45db1d2f8a2c3799bdfe77c5 Add CC_LIST and --cc to Gerrit issues via API to be similar to CCs in Rietveld (rmistry@google.com)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG= chromium:649660 

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2375963004

[modify] https://crrev.com/3ca6e8a40b853337432916ce446b00e72b145381/infra/config/recipes.cfg

Project Member

Comment 24 by bugdroid1@chromium.org, Sep 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1eca99b81c0f3ab16712c38ea766d4316fcb80d7

commit 1eca99b81c0f3ab16712c38ea766d4316fcb80d7
Author: recipe-roller <recipe-roller@chromium.org>
Date: Wed Sep 28 15:55:23 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/3ca6e8a40b853337432916ce446b00e72b145381 Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
depot_tools:
  https://crrev.com/3574740929abd37c45db1d2f8a2c3799bdfe77c5 Add CC_LIST and --cc to Gerrit issues via API to be similar to CCs in Rietveld (rmistry@google.com)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG= chromium:649660 

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2381563002
Cr-Commit-Position: refs/heads/master@{#421530}

[modify] https://crrev.com/1eca99b81c0f3ab16712c38ea766d4316fcb80d7/infra/config/recipes.cfg

Project Member

Comment 25 by bugdroid1@chromium.org, Sep 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/f100cada231af0b1a0c70845f8d8c06fd9726086

commit f100cada231af0b1a0c70845f8d8c06fd9726086
Author: recipe-roller <recipe-roller@chromium.org>
Date: Wed Sep 28 18:35:17 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/ba86a553518c0321687aff9497624d84f6a17be0 WebRTC: Update tests after renaming AppRTCDemo -> AppRTCMobile. (kjellander@chromium.org)
  https://crrev.com/597c27e7cd712b9a07dd091a44f22af5b957c54a WebRTC: Add android_junit_tests. (ehmaldonado@chromium.org)
  https://crrev.com/22636ece1d2c8507ca8dbebd6b434b0fe9ba6ef1 Revert of WebRTC: Add android_junit_tests. (patchset #8 id:200001 of https://codereview.chromium.org/2354363006/ ) (ehmaldonado@chromium.org)
  https://crrev.com/567475a8f817b58253b6e305bf5eb5c980f04bc6 WebRTC: Add android_junit_tests to FYI bots. (ehmaldonado@chromium.org)
  https://crrev.com/3ca6e8a40b853337432916ce446b00e72b145381 Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
depot_tools:
  https://crrev.com/3574740929abd37c45db1d2f8a2c3799bdfe77c5 Add CC_LIST and --cc to Gerrit issues via API to be similar to CCs in Rietveld (rmistry@google.com)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG= 647390 , chromium:649660 , webrtc:6359 

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2377953004

[modify] https://crrev.com/f100cada231af0b1a0c70845f8d8c06fd9726086/infra/config/recipes.cfg

Project Member

Comment 26 by bugdroid1@chromium.org, Sep 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools.git/+/31d165a5c15c7311e0eed1cf731a5585ac9c7f57

commit 31d165a5c15c7311e0eed1cf731a5585ac9c7f57
Author: tandrii <tandrii@chromium.org>
Date: Thu Sep 29 08:40:46 2016

Revert of Add CC_LIST and --cc to Gerrit issues via API to be similar to CCs in Rietveld (patchset #4 id:60001 of https://codereview.chromium.org/2378703002/ )

Reason for revert:
Actually, it doesn't break uploads, add cc-ed emails post-upload fails with exception and confuses users, and I couldn't find workaround.

Original issue's description:
> Add CC_LIST and --cc to Gerrit issues via API to be similar to CCs in Rietveld
>
> BUG= chromium:649660 
>
> Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/3574740929abd37c45db1d2f8a2c3799bdfe77c5

TBR=rmistry@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= chromium:649660 

Review-Url: https://codereview.chromium.org/2375393002

[modify] https://crrev.com/31d165a5c15c7311e0eed1cf731a5585ac9c7f57/gerrit_util.py
[modify] https://crrev.com/31d165a5c15c7311e0eed1cf731a5585ac9c7f57/git_cl.py
[modify] https://crrev.com/31d165a5c15c7311e0eed1cf731a5585ac9c7f57/tests/git_cl_test.py

Project Member

Comment 27 by bugdroid1@chromium.org, Sep 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/f9511903eb2d5e04717055a3d7b38df53d01b68b

commit f9511903eb2d5e04717055a3d7b38df53d01b68b
Author: recipe-roller <recipe-roller@chromium.org>
Date: Thu Sep 29 08:54:37 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

depot_tools:
  https://crrev.com/31d165a5c15c7311e0eed1cf731a5585ac9c7f57 Revert of Add CC_LIST and --cc to Gerrit issues via API to be similar to CCs in Rietveld (patchset #4 id:60001 of https://codereview.chromium.org/2378703002/ ) (tandrii@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG= chromium:649660 

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2382673002

[modify] https://crrev.com/f9511903eb2d5e04717055a3d7b38df53d01b68b/infra/config/recipes.cfg

Project Member

Comment 28 by bugdroid1@chromium.org, Sep 29 2016

Project Member

Comment 29 by bugdroid1@chromium.org, Sep 29 2016

Project Member

Comment 30 by bugdroid1@chromium.org, Sep 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/92909c7eef49ebc6617025fa59f90f16f2a796c9

commit 92909c7eef49ebc6617025fa59f90f16f2a796c9
Author: recipe-roller <recipe-roller@chromium.org>
Date: Thu Sep 29 09:09:57 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/f9511903eb2d5e04717055a3d7b38df53d01b68b Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
depot_tools:
  https://crrev.com/31d165a5c15c7311e0eed1cf731a5585ac9c7f57 Revert of Add CC_LIST and --cc to Gerrit issues via API to be similar to CCs in Rietveld (patchset #4 id:60001 of https://codereview.chromium.org/2378703002/ ) (tandrii@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG= chromium:649660 

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2376053003
Cr-Commit-Position: refs/heads/master@{#421784}

[modify] https://crrev.com/92909c7eef49ebc6617025fa59f90f16f2a796c9/infra/config/recipes.cfg

Project Member

Comment 31 by bugdroid1@chromium.org, Sep 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/2e5d6d5e1943ac51b1dc862e6143977c1293a94f

commit 2e5d6d5e1943ac51b1dc862e6143977c1293a94f
Author: recipe-roller <recipe-roller@chromium.org>
Date: Thu Sep 29 09:15:00 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/f9511903eb2d5e04717055a3d7b38df53d01b68b Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
depot_tools:
  https://crrev.com/31d165a5c15c7311e0eed1cf731a5585ac9c7f57 Revert of Add CC_LIST and --cc to Gerrit issues via API to be similar to CCs in Rietveld (patchset #4 id:60001 of https://codereview.chromium.org/2378703002/ ) (tandrii@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG= chromium:649660 

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2378283003

[modify] https://crrev.com/2e5d6d5e1943ac51b1dc862e6143977c1293a94f/infra/config/recipes.cfg

Project Member

Comment 33 by bugdroid1@chromium.org, Sep 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/e89dd33e1ad112c84ce73ceb58321eb2b2bb3030

commit e89dd33e1ad112c84ce73ceb58321eb2b2bb3030
Author: recipe-roller <recipe-roller@chromium.org>
Date: Thu Sep 29 11:34:18 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

depot_tools:
  https://crrev.com/8818977467d88125743535010c5b37521694df0a Reland of Add CC_LIST and --cc to Gerrit issues via API to be similar to CCs in Rietveld (tandrii@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG= chromium:649660 

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2379653003

[modify] https://crrev.com/e89dd33e1ad112c84ce73ceb58321eb2b2bb3030/infra/config/recipes.cfg

Project Member

Comment 34 by bugdroid1@chromium.org, Sep 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/e89dd33e1ad112c84ce73ceb58321eb2b2bb3030

commit e89dd33e1ad112c84ce73ceb58321eb2b2bb3030
Author: recipe-roller <recipe-roller@chromium.org>
Date: Thu Sep 29 11:34:18 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

depot_tools:
  https://crrev.com/8818977467d88125743535010c5b37521694df0a Reland of Add CC_LIST and --cc to Gerrit issues via API to be similar to CCs in Rietveld (tandrii@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG= chromium:649660 

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2379653003

[modify] https://crrev.com/e89dd33e1ad112c84ce73ceb58321eb2b2bb3030/infra/config/recipes.cfg

Project Member

Comment 35 by bugdroid1@chromium.org, Sep 29 2016

Project Member

Comment 36 by bugdroid1@chromium.org, Sep 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/62059a1ce785f0eb404ca27f11cd0ca7b04c4882

commit 62059a1ce785f0eb404ca27f11cd0ca7b04c4882
Author: recipe-roller <recipe-roller@chromium.org>
Date: Thu Sep 29 11:50:18 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/e89dd33e1ad112c84ce73ceb58321eb2b2bb3030 Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
depot_tools:
  https://crrev.com/8818977467d88125743535010c5b37521694df0a Reland of Add CC_LIST and --cc to Gerrit issues via API to be similar to CCs in Rietveld (tandrii@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG= chromium:649660 

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2378623004
Cr-Commit-Position: refs/heads/master@{#421801}

[modify] https://crrev.com/62059a1ce785f0eb404ca27f11cd0ca7b04c4882/infra/config/recipes.cfg

Project Member

Comment 37 by bugdroid1@chromium.org, Sep 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/9ddc55f51e60feb0399513ffb5d85510188b7544

commit 9ddc55f51e60feb0399513ffb5d85510188b7544
Author: recipe-roller <recipe-roller@chromium.org>
Date: Thu Sep 29 11:54:53 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/e89dd33e1ad112c84ce73ceb58321eb2b2bb3030 Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
depot_tools:
  https://crrev.com/8818977467d88125743535010c5b37521694df0a Reland of Add CC_LIST and --cc to Gerrit issues via API to be similar to CCs in Rietveld (tandrii@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG= chromium:649660 

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2376333002

[modify] https://crrev.com/9ddc55f51e60feb0399513ffb5d85510188b7544/infra/config/recipes.cfg

Comment 38 by rmis...@google.com, Sep 29 2016

Cc: tandrii@chromium.org
Owner: rmis...@chromium.org
Status: Fixed (was: Assigned)
Filed https://bugs.chromium.org/p/gerrit/issues/detail?id=4673 to talk about the frequent emails from PG vs Rietveld.

I think we can mark this one as fixed because CC_LIST and --cc should be correctly handled now. Please reopen if you disagree.
 Issue 651131  has been merged into this issue.

Sign in to add a comment