Add possibility to store custom geolocations
Reported by
scarys...@googlemail.com,
Sep 23 2016
|
|||||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/53.0.2785.116 Safari/537.36 Steps to reproduce the problem: The dev tools 'Sensors' tab let's you override the geolocation of the device. Custom locations and a set of presets are available. It would be helpful, if a user can save entered custom locations (lat, lng values) for later usage; similar to saving custom device resolutions in the mobile device toolbar. What is the expected behavior? What went wrong? The custom location is deleted when restarting dev tools. Did this work before? N/A Chrome version: 53.0.2785.116 Channel: stable OS Version: OS X 10.11.6 Flash Version:
,
Oct 7 2016
,
Jan 10 2017
Issue 678062 has been merged into this issue.
,
Apr 21 2017
Issue 713204 has been merged into this issue.
,
Apr 21 2017
One of the duplicate tickets discussed including a checkbox to enable persistence of emulated geolocation over refresh. This could also be made into a per-profile setting.
,
Jun 28 2017
Issue 733654 has been merged into this issue.
,
Nov 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/70472dcf47cfb8423e190447b6c61611ba82970b commit 70472dcf47cfb8423e190447b6c61611ba82970b Author: Erik Luo <luoe@chromium.org> Date: Wed Nov 29 01:54:51 2017 DevTools: fix geolocation toSetting() serialization The Geolocation struct used to hold a string-type error property, but was changed into a boolean here: https://codereview.chromium.org/1917543002 There was a mistake in that CL, where it was still expecting a string-type error, causing serialization to always return an empty string. This CL fixes the serializer, allowing the last applied geolocation to be saved. Bug: 649657 Change-Id: I7f65f7844dca9ee2e182970602c6810a3c776973 Reviewed-on: https://chromium-review.googlesource.com/778044 Commit-Queue: Erik Luo <luoe@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#519953} [modify] https://crrev.com/70472dcf47cfb8423e190447b6c61611ba82970b/third_party/WebKit/Source/devtools/front_end/sdk/EmulationModel.js
,
Nov 29 2017
This is helpful, but still not ideal. It would be great to be able to store custom locations permanently in the event you would like to switch. My company has 11 locations. I would like to be able to set my geolocation to appear as if I am in any office at a given time without having to need to enter in Lat-Long each time,
,
Nov 29 2017
I would also very much like to store multiple custom locations, but just to clarify, that is both custom name and position per entry.
,
Jul 25
Hope you will do it, will be very helpful
,
Jul 28
Please add custom location saving! Would love to see this happen! And as Mario.l stated... Custom name and location per entry!
,
Sep 8
Upvote. We, developers, need this.
,
Sep 12
after two years...
,
Sep 19
This would be very useful... I remember looking for this feature a couple of years ago and it is STILL not implemented. Can't complain about a free open source product I guess, but... it sure would be nice.
,
Oct 18
upvote, please implement
,
Dec 11
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/90c853aae4b8e1e538f6b486f0a0a30fa1c655dc commit 90c853aae4b8e1e538f6b486f0a0a30fa1c655dc Author: Pavel Feldman <pfeldman@chromium.org> Date: Tue Dec 11 03:02:56 2018 DevTools: allow for custom geolocation overrides. Bug: 649657 Change-Id: I76bae556b1196336b9da03cf924e31d97a1e238f Reviewed-on: https://chromium-review.googlesource.com/c/1371210 Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#615410} [modify] https://crrev.com/90c853aae4b8e1e538f6b486f0a0a30fa1c655dc/third_party/blink/renderer/devtools/BUILD.gn [delete] https://crrev.com/02de02be61c0564bbbfef0d868e2b543572b3c86/third_party/blink/renderer/devtools/front_end/Images/accelerometer-back.png [add] https://crrev.com/90c853aae4b8e1e538f6b486f0a0a30fa1c655dc/third_party/blink/renderer/devtools/front_end/Images/accelerometer-back.svg [delete] https://crrev.com/02de02be61c0564bbbfef0d868e2b543572b3c86/third_party/blink/renderer/devtools/front_end/Images/accelerometer-front.png [add] https://crrev.com/90c853aae4b8e1e538f6b486f0a0a30fa1c655dc/third_party/blink/renderer/devtools/front_end/Images/accelerometer-front.svg [add] https://crrev.com/90c853aae4b8e1e538f6b486f0a0a30fa1c655dc/third_party/blink/renderer/devtools/front_end/emulation/GeolocationsSettingsTab.js [modify] https://crrev.com/90c853aae4b8e1e538f6b486f0a0a30fa1c655dc/third_party/blink/renderer/devtools/front_end/emulation/SensorsView.js [add] https://crrev.com/90c853aae4b8e1e538f6b486f0a0a30fa1c655dc/third_party/blink/renderer/devtools/front_end/emulation/geolocationsSettingsTab.css [modify] https://crrev.com/90c853aae4b8e1e538f6b486f0a0a30fa1c655dc/third_party/blink/renderer/devtools/front_end/emulation/module.json [modify] https://crrev.com/90c853aae4b8e1e538f6b486f0a0a30fa1c655dc/third_party/blink/renderer/devtools/front_end/emulation/sensors.css
,
Dec 11
,
Dec 11
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by allada@chromium.org
, Oct 7 2016Status: Assigned (was: Unconfirmed)