Regression: Browser crashes on reloading chrome://md-settings/syncSetup page. |
|||||||||
Issue descriptionVersion: 55.0.2868.0 Dev OS: Ubuntu 14.04, Windows What steps will reproduce the problem? (1)Signin to chrome with valid credentials>>Navigate to chrome://md-settings>>Open devtools and emulate (2)Go to advanced and click on clear browsing data button>>Reload the page and click on cancel button in Clear browsing data overlay (3)Click on sync link in people section>> Now click on reload icon and observe browser crash. Expected: Browser should not crash on reloading syncsetup page. Actual: Instead browser crash is seen. Crash id's: 2e0f6d9e00000000 Note: Once browser crashes in emulation view, issue is seen in normal window every time(Without opening devtools) Steps: (1)Signin to chrome with valid credentials>>Navigate to chrome://md-settings>>Go to advanced and click on clear browsing data button>>Reload the page and click on cancel button in overlay. (2)Click on sync link in people section>> Now click on reload icon and observe browser crash This is Regression issue broken in M-55. Will soon update bisect info. Manual bisect info: Good build:55.0.2860.0 Dev Bad build:55.0.2861.0 Dev Attaching screen-cast for reference.
,
Sep 23 2016
Users experienced this crash on the following builds: Mac Canary 55.0.2869.0 - 2.06 CPM, 1 reports, 1 clients (signature settings::ClearBrowsingDataHandler::UpdateCounterText) If this update was incorrect, please add "Fracas-Wrong" label to prevent future updates. - Go/Fracas
,
Sep 26 2016
My change was part of a large-scale automated change. It is expected to make no semantic difference, and judging by the large scale without breaking tests, I have good confidence that is does indeed make no difference. I tried to reproduce the crash with 55.0.2861.0 and 55.0.2869.0, built locally, but did not succeed. Perhaps it only crashes on Chrome-branded builds, or maybe I'm missing some crucial step. I believe I followed the instructions precisely.
,
Sep 26 2016
,
Sep 26 2016
@dpapad, is this already fixed?
,
Sep 26 2016
I have no prior knowledge of this crash. Assigning to @tommycli.
,
Oct 10 2016
Users experienced this crash on the following builds: Mac Canary 56.0.2886.0 - 1.69 CPM, 1 reports, 1 clients (signature settings::ClearBrowsingDataHandler::UpdateCounterText) If this update was incorrect, please add "Fracas-Wrong" label to prevent future updates. - Go/Fracas
,
Nov 29 2016
,
Nov 30 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ff49185dcc63d419a850902ed5220377701d1e3c commit ff49185dcc63d419a850902ed5220377701d1e3c Author: tommycli <tommycli@chromium.org> Date: Wed Nov 30 18:40:38 2016 MD Settings: Fix WebUI lifecycle issues in Clear Browsing Data handler. BUG= 649644 Review-Url: https://codereview.chromium.org/2536003003 Cr-Commit-Position: refs/heads/master@{#435353} [modify] https://crrev.com/ff49185dcc63d419a850902ed5220377701d1e3c/chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.cc
,
Dec 1 2016
I theorize the above patch fixes these crashes. Let's monitor. |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by ajha@chromium.org
, Sep 23 2016Owner: ricea@chromium.org
Status: Assigned (was: Unconfirmed)