New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 649631 link

Starred by 2 users
Status: Fixed
Owner:
█ caryclark@chromium.org
Last visit > 30 days ago
Closed: Sep 2016
Cc:
█ gcasto@chromium.org
ricea@chromium.org
█ mfomitchev@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

webkit_tests (border tests) failing on Win7 and Win 10

Project Member Reported by grunell@chromium.org, Sep 23 2016 
fast/borders/border-styles-split.html
fast/backgrounds/border-radius-split-background.html
fast/backgrounds/border-radius-split-background-image.html

fails on

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win10
and
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20%28dbg%29

For Win 10, first seen in
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win10/builds/15114

A suspicious CL was speculatively reverted in https://codereview.chromium.org/2365523003/ but that wasn't the cause. That's the only suspicious CL I can see in the blamelist.

For Win 7, first seen in
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20%28dbg%29/builds/7442

Comment 1 by grunell@chromium.org, Sep 23 2016

Owner: jbau...@chromium.org
Status: Assigned (was: Untriaged)
Output:

14:15:30.363 4140 worker/3 fast/borders/border-styles-split.html output stderr lines:
14:15:30.363 4140   [5204:6928:0922/141529:2735937:ERROR:mf_helpers.cc(12)] Error in dxva_video_decode_accelerator_win.cc on line 297
14:15:30.429 4140 "E:\b\c\b\win_layout\src\out\Release\image_diff.exe --diff c:\users\chrome~2\appdata\local\temp\tmplgdjye\actual.png c:\users\chrome~2\appdata\local\temp\tmplgdjye\expected.png c:\users\chrome~2\appdata\local\temp\tmplgdjye\diff.png" took 0.06s
14:15:30.445 6520 [5/8] fast/borders/border-styles-split.html failed unexpectedly (image diff)
14:15:30.445 4140 worker/3 fast/borders/border-styles-split.html failed:
14:15:30.445 4140 worker/3  image diff

Similar for the other two failures. (Error in dxva_video_decode_accelerator_win.cc on line 297)

Assigning to jbauman@ to have a look.

Comment 2 by gcasto@chromium.org, Sep 23 2016

Labels: Needs-Bisect
Owner: ----
These errors look like they pre-date the failures. I'm at a loss for what the offending CL is looking at the failing range, they all look innocous. Tagging this for manual bisection since I don't have a Windows machine. Hopefully someone can help pinpoint the CL.

Comment 3 by mfomitchev@chromium.org, Sep 23 2016

Status: Untriaged (was: Assigned)
These tests are consistently failing, so I am planning to disable them until this can be investigated properly.
https://codereview.chromium.org/2369453005/
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 23 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f41ca05a5795ee1ac08f78b808b0b2424e180bbe

commit f41ca05a5795ee1ac08f78b808b0b2424e180bbe
Author: mfomitchev <mfomitchev@chromium.org>
Date: Fri Sep 23 23:40:52 2016

Disabling a few Layout Tests that consistently fail on Win 7 and Win 10

Disabled tests:
fast/borders/border-styles-split.html
fast/backgrounds/border-radius-split-background.html
fast/backgrounds/border-radius-split-background-image.html

TBR=kojii,dpranke

BUG= 649631 

Review-Url: https://codereview.chromium.org/2369453005
Cr-Commit-Position: refs/heads/master@{#420789}

[modify] https://crrev.com/f41ca05a5795ee1ac08f78b808b0b2424e180bbe/third_party/WebKit/LayoutTests/TestExpectations

Comment 5 by mfomitchev@chromium.org, Sep 24 2016

Owner: caryclark@chromium.org
Status: Assigned (was: Untriaged)
Pasting ericrk's comment from  issue 649463  in here:

probably worth continuing to investigate the Win7 flakes which started with this build: https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Win7%20%28dbg%29/builds/7442

fast/backgrounds/border-radius-split-background-image.html
fast/backgrounds/border-radius-split-background.html
fast/borders/border-styles-split.html

From looking at these flakes, I think we just missed/need a Win7 rebaseline - the changes seem pretty harmless.

From looking at the change log, my guess is that these were introduced by:
https://chromium.googlesource.com/skia.git/+/bac104605ef3d9a8ed0022694990f00518b809e9

It seems like suppressions were landed for LayoutTests here: https://codereview.chromium.org/2360393002, but Win7 specific issues may have been missed.

Assigning to caryclark who checked in that CL.

Comment 6 by caryclark@google.com, Sep 26 2016

Status: Started (was: Assigned)

Comment 7 by grunell@chromium.org, Sep 26 2016

Cc: -grunell@chromium.org

Comment 8 by durga.behera@chromium.org, Sep 26 2016

Components: Build
Labels: TE-NeedsTriageHelp
Added TE-NeedsTriageHelp as it can't be triaged by TE team.
Project Member

Comment 9 by bugdroid1@chromium.org, Sep 26 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/08d020a76b9df4b10e24ece45df546bc08a87005

commit 08d020a76b9df4b10e24ece45df546bc08a87005
Author: caryclark <caryclark@google.com>
Date: Mon Sep 26 13:51:28 2016

rebaseline missed conic-related layout tests

Missed these layout tests earlier;
conic to quad changes cause slight
differences and require a rebaseline.

R=fmalita@chromium.org
BUG= 647922 . 649631

Review-Url: https://codereview.chromium.org/2373473002
Cr-Commit-Position: refs/heads/master@{#420886}

[modify] https://crrev.com/08d020a76b9df4b10e24ece45df546bc08a87005/third_party/WebKit/LayoutTests/TestExpectations

Comment 10 by caryclark@google.com, Sep 26 2016

Status: Fixed (was: Started)
►

Sign in to add a comment