New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 649629 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : Folder icon is seen missing in bookmark manager.

Reported by mni...@etouch.net, Sep 23 2016

Issue description

Version: 55.0.2869.0 333a7dd429e44a6562112fc29c667474fa2e92f9-refs/heads/master@{#420536} (32/64-bit)
OS: Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.10.5, 10.11.4)

What steps will reproduce the problem?
1. Launch chrome and navigate to chrome://bookmarks
2. Now click on 'Organize' and add a new folder and observe

Actual: Folder icon is seen missing in bookmark manager 
Expected: Folder icon should be seen after adding new folder in bookmark manager 

This is regression issue, broken in ‘M 55’ and below is manual regression and will soon update other info
Good build : 55.0.2867.0
Bad build : 55.0.2868.0

 
Actual_video.mov
900 KB Download
Expected_bookmark.mov
1.9 MB Download

Comment 1 by mni...@etouch.net, Sep 23 2016

Act_Expe_folder.png
60.9 KB View Download
Cc: brajkumar@chromium.org
Labels: hasbisect-per-revision
Owner: pkasting@chromium.org
Status: Assigned (was: Unconfirmed)
Able to reproduce the issue on Ubuntu 14.04 using chrome latest Dev M55-55.0.2868.0 by following steps mentioned in the original comment. Observed the folder icon is seen missing in bookmark manager.

Using the per-revision bisect providing the bisect results,
Good build:55.0.2867.0(Revision: 419930).
Bad build:55.0.2868.0(Revision: 420217).

You are probably looking for a change made after 419987 (known good), but no later than 419988 (first known bad).

CHANGELOG URL:
---------------
https://chromium.googlesource.com/chromium/src/+log/05d38461379b7a86bc48ef345afd1fc835a00c37..71fa2e9ca7722388da15099748e2772f9f1640e7

From the CL above, assigning the issue to the concern owner 
@pkasting- Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.
Labels: ReleaseBlock-Stable
Adding release block label, please undo if not the case.
This is marked as affecting Linux/Mac/Windows, but the screenshot is of Mac and comment 2 claims repro on Linux.  I cannot repro in 55.0.2868.1 on Windows.  Is this Linux/Mac only?
Never mind, the issue isn't that folder icons never appear, it's that if you add a folder from the context menu of the bookmark manager, it won't have a folder icon if you leave the name "New folder".  Change the name, or move to a different folder and come back, and things look fine.

Odd.

Comment 6 by ajha@chromium.org, Sep 28 2016

Friendly ping to get an update on this.
The update is "I'm aware of this".  It's RBS M-55, and definitely not beta-blocking, so we have time.  It's perf season, so I'm fairly busy ATM, and it doesn't help that no one knows the bookmark manager code and I don't even speak HTML/CSS/JS, so tracking down the problems here is Hard.  Help graciously accepted :)
Cc: tkonch...@chromium.org
Just to update:

The issue is still seen on mac 10.11.6 latest canary 55.0.2880.4 - Folder icon is missing in bookmark manager
Gentle Ping! M55 will be pushed to stable soon, Could anyone let us know is there any latest update available for this issue ? 
There is no update.  I'm completely flooded.  Help from someone who knows web technologies would be appreciated.
Status: Started (was: Assigned)
Possible fix https://codereview.chromium.org/2444373003/
**** Bulk edit -  please ignore if not applicable ****

A friendly reminder that M55 Stable is launch is coming soon! Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and get it merged into the release branch ASAP so it gets enough baking time in Beta (before Stable promotion). Thank you!
Project Member

Comment 13 by bugdroid1@chromium.org, Oct 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/93a5e7c45a78646f04f1de812da3cb41d6667845

commit 93a5e7c45a78646f04f1de812da3cb41d6667845
Author: pkasting <pkasting@chromium.org>
Date: Thu Oct 27 23:07:57 2016

Adding/renaming a folder in the bookmark manager should not hide the icon.

BUG= 649629 
TEST=Select a folder in the bookmark manager and hit F2.  The folder icon should not disappear and the input field for changing the name should have a fully visible border.  Type a name and hit enter; the text should not move between before and after you hit enter.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2444373003
Cr-Commit-Position: refs/heads/master@{#428189}

[modify] https://crrev.com/93a5e7c45a78646f04f1de812da3cb41d6667845/chrome/browser/resources/bookmark_manager/css/bmm.css
[modify] https://crrev.com/93a5e7c45a78646f04f1de812da3cb41d6667845/chrome/browser/resources/bookmark_manager/js/bmm/bookmark_list.js

Labels: Merge-Request-55
Status: Fixed (was: Started)
Fixed in r428189, requesting merge to M55.
Labels: TE-Verified-M56 TE-Verifed-56.0.2903.0
Rechecked this on chrome version 56.0.2903.0 on Windows 10, Mac 10.11.6, Ubuntu 14.04. Fis is working as intended. Able to edit a folder in bookmark manager and text displayed are proper.

Adding TE-Verified labels.

Will verified the same on M55 once the merge is available.

Thanks.!

Comment 16 by dimu@chromium.org, Oct 28 2016

Labels: -Merge-Request-55 Merge-Approved-55 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M55 (branch: 2883)
Project Member

Comment 17 by bugdroid1@chromium.org, Oct 28 2016

Labels: -merge-approved-55 merge-merged-2883
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d6b2e22099b28b7345afa03db4dddecadc729c37

commit d6b2e22099b28b7345afa03db4dddecadc729c37
Author: Peter Kasting <pkasting@google.com>
Date: Fri Oct 28 22:41:58 2016

Adding/renaming a folder in the bookmark manager should not hide the icon.

BUG= 649629 
TEST=Select a folder in the bookmark manager and hit F2.  The folder icon should not disappear and the input field for changing the name should have a fully visible border.  Type a name and hit enter; the text should not move between before and after you hit enter.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2444373003
Cr-Commit-Position: refs/heads/master@{#428189}
(cherry picked from commit 93a5e7c45a78646f04f1de812da3cb41d6667845)

Review URL: https://codereview.chromium.org/2450363005 .

Cr-Commit-Position: refs/branch-heads/2883@{#369}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/d6b2e22099b28b7345afa03db4dddecadc729c37/chrome/browser/resources/bookmark_manager/css/bmm.css
[modify] https://crrev.com/d6b2e22099b28b7345afa03db4dddecadc729c37/chrome/browser/resources/bookmark_manager/js/bmm/bookmark_list.js

Labels: TE-Verified-M55 TE-Verified-55.0.2883.34
Verified the issue on Windows-10, Ubuntu 14.04 and Mac OS 10.12 using chrome latest M55-55.0.2883.34 and observed the folder icon is seen properly as expected. Hence adding TE-Verified label.
Screen Shot 2016-11-01 at 12.01.35 PM.png
152 KB View Download

Sign in to add a comment